Skip to contentSkip to conversation

hwmon: w83795: Fan control option isn't that dangerous

PATCH Applied Jean Delvare 2 participants 2 messages Aug 6, 2019 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: w83795: Fan control option isn't that dangerous

I have been using SENSORS_W83795_FANCTRL for several years and never had any problem. When the driver was added, I had not tested that part of the driver yet so I wanted to be super cautious, but time has shown that it works just fine.

In the long run I even believe that we should drop the option and enable the feature unconditionally. It doesn't do anything until the user explicitly starts twiddling with sysfs attributes anyway.

---
 drivers/hwmon/Kconfig |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/hwmon/Kconfig +1 -6
@@ -1834,17 +1834,12 @@ config SENSORS_W83795
 	  will be called w83795.
 
 config SENSORS_W83795_FANCTRL
-	bool "Include automatic fan control support (DANGEROUS)"
+	bool "Include automatic fan control support"
 	depends on SENSORS_W83795
 	help
 	  If you say yes here, support for automatic fan speed control
 	  will be included in the driver.
 
-	  This part of the code wasn't carefully reviewed and tested yet,
-	  so enabling this option is strongly discouraged on production
-	  servers. Only developers and testers should enable it for the
-	  time being.
-
 	  Please also note that this option will create sysfs attribute
 	  files which may change in the future, so you shouldn't rely
 	  on them being stable.
Signature · 2 lines
Jean Delvare
SUSE L3 Support
maintainer Applied
#1 lore raw
Quoted 10 lines · Jean Delvare

I have been using SENSORS_W83795_FANCTRL for several years and never had any problem. When the driver was added, I had not tested that part of the driver yet so I wanted to be super cautious, but time has shown that it works just fine.

In the long run I even believe that we should drop the option and enable the feature unconditionally. It doesn't do anything until the user explicitly starts twiddling with sysfs attributes anyway.

Applied to hwmon-next. And, yes, dropping the option is fine with me.

Thanks,
Guenter

Quoted 25 lines
---
 drivers/hwmon/Kconfig |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/hwmon/Kconfig +1 -6
@@ -1834,17 +1834,12 @@ config SENSORS_W83795
 	  will be called w83795.
 
 config SENSORS_W83795_FANCTRL
-	bool "Include automatic fan control support (DANGEROUS)"
+	bool "Include automatic fan control support"
 	depends on SENSORS_W83795
 	help
 	  If you say yes here, support for automatic fan speed control
 	  will be included in the driver.
 
-	  This part of the code wasn't carefully reviewed and tested yet,
-	  so enabling this option is strongly discouraged on production
-	  servers. Only developers and testers should enable it for the
-	  time being.
-
 	  Please also note that this option will create sysfs attribute
 	  files which may change in the future, so you shouldn't rely
 	  on them being stable.