i40e: Remove EMPR traces from debugfs facility
Subsystems (2)
PATCH 1/1 i40e: Remove EMPR traces from debugfs facility
Since commit
'5098850c9b9b ("i40e/i40evf: i40e_register.h updates")'
it is no longer possible to trigger an EMP Reset from debugfs, but it's possible to request it either way, to end up with a bad reset request:
echo empr > /sys/kernel/debug/i40e/0002\:01\:00.1/command i40e 0002:01:00.1: debugfs: forcing EMPR
i40e 0002:01:00.1: bad reset request 0x00010000
So let's remove this piece of code and show the available valid commands as it is when any invalid command is issued.
--- drivers/net/ethernet/intel/i40e/i40e.h | 1 - drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 ---- 2 files changed, 5 deletions(-)
drivers/net/ethernet/intel/i40e/i40e.h +0 -1
@@ -131,7 +131,6 @@ enum i40e_state_t { __I40E_PF_RESET_REQUESTED, __I40E_CORE_RESET_REQUESTED, __I40E_GLOBAL_RESET_REQUESTED, - __I40E_EMP_RESET_REQUESTED, __I40E_EMP_RESET_INTR_RECEIVED, __I40E_SUSPENDED, __I40E_PTP_TX_IN_PROGRESS,
drivers/net/ethernet/intel/i40e/i40e_debugfs.c +0 -4
@@ -1125,10 +1125,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,dev_info (&pf->pdev->dev,"debugfs: forcing GlobR\n" );i40e_do_reset_safe (pf,BIT (__I40E_GLOBAL_RESET_REQUESTED)); - }else if (strncmp (cmd_buf,"empr" ,4 ) ==0 ) { -dev_info (&pf->pdev->dev,"debugfs: forcing EMPR\n" ); -i40e_do_reset_safe (pf,BIT (__I40E_EMP_RESET_REQUESTED)); - }else if (strncmp (cmd_buf,"read" ,4 ) ==0 ) {u32 address;u32 value;
Signature · 1 line
2.21.0
Bowers
PATCH 1/1 i40e: Remove EMPR traces from debugfs facility
Quoted 18 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Mauro S. M. Rodrigues
Sent: Tuesday, August 6, 2019 6:38 AM
To: intel-wired-lan at lists.osuosl.org; Kirsher, Jeffrey T <[email protected]>
Subject: [Intel-wired-lan] [PATCH] i40e: Remove EMPR traces from debugfs facilitySince commit
'5098850c9b9b("i40e/i40evf:i40e_register.hupdates")'
it is no longer possible to trigger an EMP Reset from debugfs, but it's possible to request it either way, to end up with a bad reset request:echo empr > /sys/kernel/debug/i40e/0002\:01\:00.1/command
i40e 0002:01:00.1: debugfs: forcing EMPR i40e 0002:01:00.1: bad reset request0x00010000
Quoted 8 lines
So let's remove this piece of code and show the available valid commands as it is when any invalid command is issued.
Signed-off-by Mauro S. M. Rodrigues <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e.h | 1 - drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 ---- 2 files changed, 5 deletions(-)