Skip to contentSkip to conversation

[[email protected]: Re: Back-porting request]

[email protected]: Re: Back-porting request Stephen Suryaputra 1 participant 1 message Aug 6, 2019

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Stephen Suryaputra

author
#0 lore raw

Hi,

How do I request back-porting of commit 5b18f1289808 ("ipv4: reset rt_iif for recirculated mcast/bcast out pkts") quoted below? I think for 4.19, the following diff is needed in addition to the commit:

net/ipv4/route.c +1 -5
index cd84f7f68032..120ef1f284fa 100644
@@ -1652,11 +1652,7 @@ struct rtable *rt_dst_clone(struct net_device *dev, struct rtable *rt)
 		new_rt->rt_iif = rt->rt_iif;
 		new_rt->rt_pmtu = rt->rt_pmtu;
 		new_rt->rt_mtu_locked = rt->rt_mtu_locked;
-		new_rt->rt_gw_family = rt->rt_gw_family;
-		if (rt->rt_gw_family == AF_INET)
-			new_rt->rt_gw4 = rt->rt_gw4;
-		else if (rt->rt_gw_family == AF_INET6)
-			new_rt->rt_gw6 = rt->rt_gw6;
+		new_rt->rt_gateway = rt->rt_gateway;
 		INIT_LIST_HEAD(&new_rt->rt_uncached);
 
 		new_rt->dst.flags |= DST_HOST;

Thanks.

----- Forwarded message from Sasha Levin <[email protected]> -----

Quoted 17 lines · Greg KH
Quoted 16 lines · Stephen Suryaputra

Hello,

I'm requesting this commit to be back-ported to v4.14:
---
commit 5b18f1289808fee5d04a7e6ecf200189f41a4db6

Author: Stephen Suryaputra <[email protected]>
Date:   Wed Jun 26 02:21:16 2019 -0400

ipv4: reset rt_iif for recirculated mcast/bcast out pkts

Multicast or broadcast egress packets have rt_iif set to the oif. These packets might be recirculated back as input and lookup to the raw sockets may fail because they are bound to the incoming interface (skb_iif). If rt_iif is not zero, during the lookup, inet_iif() function returns rt_iif instead of skb_iif. Hence, the lookup fails.

Quoted 7 lines
Quoted 7 lines

v2: Make it non vrf specific (David Ahern). Reword the changelog to
reflect it.

Signed-off-by Stephen Suryaputra <[email protected]>
Reviewed-by David Ahern <[email protected]>
Signed-off-by David S. Miller <[email protected]>

---

[deleted]

Quoted 8 lines

For networking patches to be applied to the stable kernel tree(s), please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

There is a section for how to do this for networking patches as they are accepted a bit differently from other patches.

To clarify a bit more here: technically you're asking for a patch to be included in 4.14, which isn't one of the "last two stable releases", so that document will tell you to send that patch directly to us.

However, this patch isn't in 4.19 either, which is still Dave's domain, and we can't take it in 4.14 if it's not in 4.19 (we don't want to introduce regressions for people who are upgrading their kernels), so this will still need to go through Dave.

--
Thanks,
Sasha

----- End forwarded message -----