Skip to contentSkip to conversation

buildhistory: call a dependency parser only on actual dependency lists

PATCH In review Ross Burton 2 participants 2 messages Aug 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 buildhistory: call a dependency parser only on actual dependency lists

From: Alexander Kanavin <[email protected]>

Previously it was also called on filelists and possibly other items which broke the parser.

---
 meta/lib/oe/buildhistory_analysis.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/buildhistory_analysis.py +1 -1
index ad7fceb8bbc..d3cde4f6509 100644
@@ -127,7 +127,7 @@ class ChangeRecord:
             removed = list(set(aitems) - set(bitems))
             added = list(set(bitems) - set(aitems))
 
-            if not removed and not added:
+            if not removed and not added and self.fieldname in ['RPROVIDES', 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 'RREPLACES', 'RCONFLICTS']:
                 depvera = bb.utils.explode_dep_versions2(self.oldvalue, sort=False)
                 depverb = bb.utils.explode_dep_versions2(self.newvalue, sort=False)
                 for i, j in zip(depvera.items(), depverb.items()):
Signature · 1 line
2.20.1
#1 lore raw

✗ patchtest: failure for buildhistory: call a dependency parser only on actual dependency lists (rev2)

== Series Details ==

Series: buildhistory: call a dependency parser only on actual dependency lists (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/17240/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Errors in your Python code were encountered [test_pylint]
Suggested fix Correct the lines introduced by your patch
Output Please, fix the listed issues:
meta/lib/oe/buildhistory_analysis.py does not exist

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe