tools lib traceevent: Fix buffer overflow in arg_eval
PATCH 1/1 tools lib traceevent: Fix buffer overflow in arg_eval
From: Tony Jones <[email protected]>
Fix buffer overflow observed when running perf test.
The overflow is when trying to evaluate "1ULL << (64 - 1)" which is resulting in -9223372036854775808 which overflows the 20 character buffer.
If is possible this bug has been reported before but I still don't see any fix checked in:
See: https://www.spinics.net/lists/linux-perf-users/msg07714.html
Reported-by Michael Sartain <[email protected]>
Reported-by Mathias Krause <[email protected]>
Signed-off-by Tony Jones <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Fixes f7d82350e597 ("tools/events: Add files to create libtraceevent.a")
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
[
Backport from kernel into the trace-cmd repo.
]
lib/traceevent/event-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/traceevent/event-parse.c +1 -1
@@ -2456,7 +2456,7 @@ static int arg_num_eval(struct tep_print_arg *arg, long long *val)static char *arg_eval (struct tep_print_arg *arg) {long long val; -static char buf[20 ]; +static char buf[24 ];switch (arg->type) {case TEP_PRINT_ATOM :
Signature · 1 line
2.21.0