arm64: KVM: hyp: debug-sr: Mark expected switch fall-throughs
PATCH 1/1 arm64: KVM: hyp: debug-sr: Mark expected switch fall-throughs
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: allmodconfig arm64):
arch/arm64/kvm/hyp/debug-sr.c:20:19: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:21:19: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:22:19: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:23:19: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:24:19: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:25:19: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:26:18: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:27:18: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:28:18: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:29:18: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:30:18: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:31:18: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:32:18: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:33:18: warning: this statement may fall through [-Wimplicit-fallthrough=] arch/arm64/kvm/hyp/debug-sr.c:34:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
--- arch/arm64/kvm/hyp/debug-sr.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
arch/arm64/kvm/hyp/debug-sr.c +30 -0
@@ -18,40 +18,70 @@#define save_debug (ptr,reg,nr) \ switch (nr) { \ case 15: ptr[15] = read_debug(reg, 15); \ +/* Fall through */ \case 14 : ptr[14 ] =read_debug (reg,14 ); \ +/* Fall through */ \case 13 : ptr[13 ] =read_debug (reg,13 ); \ +/* Fall through */ \case 12 : ptr[12 ] =read_debug (reg,12 ); \ +/* Fall through */ \case 11 : ptr[11 ] =read_debug (reg,11 ); \ +/* Fall through */ \case 10 : ptr[10 ] =read_debug (reg,10 ); \ +/* Fall through */ \case 9 : ptr[9 ] =read_debug (reg,9 ); \ +/* Fall through */ \case 8 : ptr[8 ] =read_debug (reg,8 ); \ +/* Fall through */ \case 7 : ptr[7 ] =read_debug (reg,7 ); \ +/* Fall through */ \case 6 : ptr[6 ] =read_debug (reg,6 ); \ +/* Fall through */ \case 5 : ptr[5 ] =read_debug (reg,5 ); \ +/* Fall through */ \case 4 : ptr[4 ] =read_debug (reg,4 ); \ +/* Fall through */ \case 3 : ptr[3 ] =read_debug (reg,3 ); \ +/* Fall through */ \case 2 : ptr[2 ] =read_debug (reg,2 ); \ +/* Fall through */ \case 1 : ptr[1 ] =read_debug (reg,1 ); \ +/* Fall through */ \default : ptr[0 ] =read_debug (reg,0 ); \ }#define restore_debug (ptr,reg,nr) \ switch (nr) { \ case 15: write_debug(ptr[15], reg, 15); \ +/* Fall through */ \case 14 :write_debug (ptr[14 ], reg,14 ); \ +/* Fall through */ \case 13 :write_debug (ptr[13 ], reg,13 ); \ +/* Fall through */ \case 12 :write_debug (ptr[12 ], reg,12 ); \ +/* Fall through */ \case 11 :write_debug (ptr[11 ], reg,11 ); \ +/* Fall through */ \case 10 :write_debug (ptr[10 ], reg,10 ); \ +/* Fall through */ \case 9 :write_debug (ptr[9 ], reg,9 ); \ +/* Fall through */ \case 8 :write_debug (ptr[8 ], reg,8 ); \ +/* Fall through */ \case 7 :write_debug (ptr[7 ], reg,7 ); \ +/* Fall through */ \case 6 :write_debug (ptr[6 ], reg,6 ); \ +/* Fall through */ \case 5 :write_debug (ptr[5 ], reg,5 ); \ +/* Fall through */ \case 4 :write_debug (ptr[4 ], reg,4 ); \ +/* Fall through */ \case 3 :write_debug (ptr[3 ], reg,3 ); \ +/* Fall through */ \case 2 :write_debug (ptr[2 ], reg,2 ); \ +/* Fall through */ \case 1 :write_debug (ptr[1 ], reg,1 ); \ +/* Fall through */ \default :write_debug (ptr[0 ], reg,0 ); \ }
Signature · 1 line
2.22.0
Marc Zyngier
maintainerQuoted 20 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: allmodconfig arm64):
arch/arm64/kvm/hyp/debug-sr.c:20:19: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:21:19: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:22:19: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:23:19: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:24:19: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:25:19: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:26:18: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:27:18: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:28:18: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:29:18: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:30:18: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:31:18: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:32:18: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:33:18: warning: this statement may fall through [-Wimplicit-fallthrough=]arch/arm64/kvm/hyp/debug-sr.c:34:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>
Already fixed (together with all the other KVM/arm warnings/bugs), and pull request sent to Paolo.
Thanks,
M.
Signature · 1 line
Jazz is not dead, it just smells funny...
Quoted 4 lines · Marc Zyngier
Already fixed (together with all the other KVM/arm warnings/bugs), and pull request sent to Paolo.
Awesome. :)
Thanks, Marc.
--
Gustavo