ARM: ep93xx: Mark expected switch fall-through
PATCH 1/1 ARM: ep93xx: Mark expected switch fall-through
Mark switch cases where we are expecting to fall through.
Fix the following warnings (Building: arm-ep93xx_defconfig arm):
arch/arm/mach-ep93xx/crunch.c: In function 'crunch_do':arch/arm/mach-ep93xx/crunch.c:46:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
memset(crunch_state, 0, sizeof(*crunch_state));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm/mach-ep93xx/crunch.c:53:2: note: here
case THREAD_NOTIFY_EXIT:
^~~~Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
--- arch/arm/mach-ep93xx/crunch.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-ep93xx/crunch.c +1 -0
@@ -49,6 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)* FALLTHROUGH: Ensure we don't try to overwrite our newly * initialised state information on the first fault. */ +/* Fall through */ case THREAD_NOTIFY_EXIT :crunch_task_release (thread);
Signature · 7 lines
2.22.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi!
Quoted 13 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
Fix the following warnings (Building: arm-ep93xx_defconfig arm):
arch/arm/mach-ep93xx/crunch.c: In function 'crunch_do':arch/arm/mach-ep93xx/crunch.c:46:3: warning: this statement may fall through [-Wimplicit-fallthrough=]memset(crunch_state, 0, sizeof(*crunch_state)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/arm/mach-ep93xx/crunch.c:53:2: note: here case THREAD_NOTIFY_EXIT: ^~~~
Quoted 4 lines
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Reported-by kbuild test robot <[email protected]>
Quoted 18 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>--- arch/arm/mach-ep93xx/crunch.c | 1 + 1 file changed, 1 insertion(+)arch/arm/mach-ep93xx/crunch.c +1
-0@@ -49,6 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)* FALLTHROUGH: Ensure we don't try to overwrite our newly * initialised state information on the first fault. */ +/* Fall through */ case THREAD_NOTIFY_EXIT :crunch_task_release (thread);