Skip to contentSkip to conversation

Add recipe of xfce4-datetime-setter

PATCH Superseded [email protected] 2 participants 7 messages Aug 8, 2019 – Aug 9, 2019

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add recipe of xfce4-datetime-setter

From: Kai Kang <[email protected]>

v2:
* make xfce4-datetime-setter rdepends on systemd

Kai Kang (2):
xfce4-datetime-setter: add recipe
xfce4-settings: rrecommends xfce4-datetime-setter

 .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
 .../xfce4-settings/xfce4-settings_4.13.7.bb    |  1 +
 2 files changed, 19 insertions(+)
 create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
Signature · 1 line
2.20.0
#1 lore raw

PATCH v2 1/2 xfce4-datetime-setter: add recipe

From: Kai Kang <[email protected]>

Because xfce4-settings turn back to its official upstream, it missing function to set date and time. Add it from Andreas's repo on github. It depends on dbus service org.freedesktop.timedate1 which is provided by systemd, so add systemd to RDEPENDS.

---
 .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +18 -0
new file mode 100644
index 000000000..7a28b6101
@@ -0,0 +1,18 @@
+DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
+It is based upon GTK3 and embedds into recent xfce4-settings."
+HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
+
+DEPENDS = "glib-2.0-native libxfce4ui"
+
+SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
+SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
+
+S = "${WORKDIR}/git"
+
+inherit gettext meson
+
+FILES_${PN} += "${datadir}/icons/hicolor"
+
+RDEPENDS_${PN} = "systemd tzdata"
Signature · 1 line
2.20.0
#2 lore raw

Re: [PATCH v2 1/2] xfce4-datetime-setter: add recipe

Quoted 28 lines · On Thu, Aug 8, 2019 at 2:33 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Because xfce4-settings turn back to its official upstream, it missing function to set date and time. Add it from Andreas's repo on github. It depends on dbus service org.freedesktop.timedate1 which is provided by systemd, so add systemd to RDEPENDS.

---
 .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb
meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +8 -0
new file mode 100644
index 000000000..7a28b6101
@@ -0,0 +1,18 @@
+DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
+It is based upon GTK3 and embedds into recent xfce4-settings."
+HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
+
+DEPENDS = "glib-2.0-native libxfce4ui"
+

meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb line 18

Quoted 10 lines
meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +10 -0
+SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
+SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
+
+S = "${WORKDIR}/git"
+
+inherit gettext meson
+
+FILES_${PN} += "${datadir}/icons/hicolor"
+
+RDEPENDS_${PN} = "systemd tzdata"

On systemd-less systems it wont work

ERROR: Nothing RPROVIDES 'systemd' (but /mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb RDEPENDS on or otherwise requires it)
systemd was skipped: missing required distro feature 'systemd' (not in
DISTRO_FEATURES)

Quoted 3 lines

--
2.20.0

author
#3 lore raw

Re: [PATCH v2 1/2] xfce4-datetime-setter: add recipe

Quoted 40 lines · Khem Raj
Quoted 27 lines · On Thu, Aug 8, 2019 at 2:33 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Because xfce4-settings turn back to its official upstream, it missing function to set date and time. Add it from Andreas's repo on github. It depends on dbus service org.freedesktop.timedate1 which is provided by systemd, so add systemd to RDEPENDS.

---
  .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)

create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb

meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +8 -0
new file mode 100644
index 000000000..7a28b6101
@@ -0,0 +1,18 @@
+DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
+It is based upon GTK3 and embedds into recent xfce4-settings."
+HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
+
+DEPENDS = "glib-2.0-native libxfce4ui"
+

meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb line 18

Quoted 10 lines
meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +10 -0
+SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
+SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
+
+S = "${WORKDIR}/git"
+
+inherit gettext meson
+
+FILES_${PN} += "${datadir}/icons/hicolor"
+
+RDEPENDS_${PN} = "systemd tzdata"

On systemd-less systems it wont work

Quoted 5 lines

ERROR: Nothing RPROVIDES 'systemd' (but /mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb RDEPENDS on or otherwise requires it)
systemd was skipped: missing required distro feature 'systemd' (not in
DISTRO_FEATURES)

It uses functions from dbus service org.freedesktop.timedate1 to set time and date. Without this dbus service, xfce4-datetime-setter doesn't work. And this dbus service is provides by systemd. The alternative is to require distro feature 'systemd'. But I think RRDEPENDS should be more proper.

Regards,
Kai

Quoted 3 lines
Quoted 3 lines

--
2.20.0

Signature · 1 line
Kai Kang
#4 lore raw

Re: [PATCH v2 1/2] xfce4-datetime-setter: add recipe

Quoted 48 lines · Kang Kai
Quoted 40 lines · Khem Raj
Quoted 27 lines · On Thu, Aug 8, 2019 at 2:33 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Because xfce4-settings turn back to its official upstream, it missing function to set date and time. Add it from Andreas's repo on github. It depends on dbus service org.freedesktop.timedate1 which is provided by systemd, so add systemd to RDEPENDS.

---
  .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)

create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb

meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +8 -0
new file mode 100644
index 000000000..7a28b6101
@@ -0,0 +1,18 @@
+DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
+It is based upon GTK3 and embedds into recent xfce4-settings."
+HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
+
+DEPENDS = "glib-2.0-native libxfce4ui"
+

meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb line 18

Quoted 10 lines
meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +10 -0
+SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
+SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
+
+S = "${WORKDIR}/git"
+
+inherit gettext meson
+
+FILES_${PN} += "${datadir}/icons/hicolor"
+
+RDEPENDS_${PN} = "systemd tzdata"

On systemd-less systems it wont work

Quoted 5 lines

ERROR: Nothing RPROVIDES 'systemd' (but /mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb RDEPENDS on or otherwise requires it)
systemd was skipped: missing required distro feature 'systemd' (not in
DISTRO_FEATURES)

Quoted 6 lines

It uses functions from dbus service org.freedesktop.timedate1 to set time and date. Without this dbus service, xfce4-datetime-setter doesn't work.
And this dbus service is provides by systemd. The alternative is to require distro feature 'systemd'. But I think RRDEPENDS should be more proper.

In such cases, it means the package is systemd specific and since we can only have one init system for a distro this package should be guarded with that distro feature as well. rdepends does not know distro nuances.

Quoted 12 lines

Regards,
Kai

Quoted 3 lines
Quoted 3 lines

--
2.20.0

--
Kai Kang

author
#5 lore raw

Re: [PATCH v2 1/2] xfce4-datetime-setter: add recipe

Quoted 53 lines · Khem Raj
Quoted 46 lines · Kang Kai
Quoted 40 lines · Khem Raj
Quoted 27 lines · On Thu, Aug 8, 2019 at 2:33 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Because xfce4-settings turn back to its official upstream, it missing function to set date and time. Add it from Andreas's repo on github. It depends on dbus service org.freedesktop.timedate1 which is provided by systemd, so add systemd to RDEPENDS.

---
   .../xfce4-datetime-setter_3.32.2.bb            | 18 ++++++++++++++++++
   1 file changed, 18 insertions(+)

create mode 100644 meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb

meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +8 -0
new file mode 100644
index 000000000..7a28b6101
@@ -0,0 +1,18 @@
+DESCRIPTION = "A fork of (early) gnome-control-center datetime panel for XFCE. \
+It is based upon GTK3 and embedds into recent xfce4-settings."
+HOMEPAGE = "https://github.com/schnitzeltony/xfce4-datetime-setter"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=75859989545e37968a99b631ef42722e"
+
+DEPENDS = "glib-2.0-native libxfce4ui"
+

meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb line 18

Quoted 10 lines
meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb new file +10 -0
+SRC_URI = "git://github.com/schnitzeltony/xfce4-datetime-setter.git;protocol=https"
+SRCREV = "5c7a73a3824b03b91719e05e2604b97c7a72d50f"
+
+S = "${WORKDIR}/git"
+
+inherit gettext meson
+
+FILES_${PN} += "${datadir}/icons/hicolor"
+
+RDEPENDS_${PN} = "systemd tzdata"

On systemd-less systems it wont work

Quoted 5 lines

ERROR: Nothing RPROVIDES 'systemd' (but /mnt/a/yoe/sources/meta-openembedded/meta-xfce/recipes-apps/xfce4-datetime-setter/xfce4-datetime-setter_3.32.2.bb RDEPENDS on or otherwise requires it)
systemd was skipped: missing required distro feature 'systemd' (not in
DISTRO_FEATURES)

Quoted 6 lines

It uses functions from dbus service org.freedesktop.timedate1 to set time and date. Without this dbus service, xfce4-datetime-setter doesn't work.
And this dbus service is provides by systemd. The alternative is to require distro feature 'systemd'. But I think RRDEPENDS should be more proper.

Quoted 4 lines

In such cases, it means the package is systemd specific and since we can only have one init system for a distro this package should be guarded with that distro feature as well. rdepends does not know distro nuances.

OK. v3 will sent with respecting distro feature systemd.

Kai

Quoted 11 lines
Quoted 11 lines

Regards,
Kai

Quoted 3 lines
Quoted 3 lines

--
2.20.0

--
Kai Kang

Signature · 1 line
Kai Kang
#6 lore raw

PATCH v2 2/2 xfce4-settings: rrecommends xfce4-datetime-setter

In reply to [email protected]

From: Kai Kang <[email protected]>

xfce4-datetime-setter provides function to set date and time. But it depends on dbus service org.freedesktop.timedate1 which is provided by systemd. Make xfce4-settings rrecommends xfce4-datetime-setter only systemd is set in DISTRO_FEATURES.

---
 meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb | 1 +
 1 file changed, 1 insertion(+)
meta-xfce/recipes-xfce/xfce4-settings/xfce4-settings_4.13.7.bb +1 -0
index e79b0ab0b..2d16a02ce 100644
@@ -30,3 +30,4 @@ FILES_${PN} += " \
 RRECOMMENDS_${PN} += "adwaita-icon-theme"
 RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','alsa','libcanberra-alsa','',d)}"
 RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','pulseaudio','libcanberra-pulse','',d)}"
+RRECOMMENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES','systemd','xfce4-datetime-setter','',d)}"
Signature · 1 line
2.20.0