Skip to contentSkip to conversation

module.bbclass: do not strip packages if modules signing is enabled

PATCH In review [email protected] 2 participants 3 messages Aug 8, 2019

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 module.bbclass: do not strip packages if modules signing is enabled

From: Dmitry Eremin-Solenikov <[email protected]>

Stripping kernel modules will also remove signature, thus we have to inhibit package striping in case modules signatures are enabled.

Signed-off-by Dmitry Eremin-Solenikov <[email protected]>
---
 meta/classes/module.bbclass | 3 +++
 1 file changed, 3 insertions(+)
meta/classes/module.bbclass +3 -0
index c0dfa3506133..31d5a2f21adc 100644
@@ -72,3 +72,6 @@ EXPORT_FUNCTIONS do_compile do_install
 KERNEL_MODULES_META_PACKAGE = "${PN}"
 FILES_${PN} = ""
 ALLOW_EMPTY_${PN} = "1"
+
+# Do not strip modules if modules signing is enabled
+INHIBIT_PACKAGE_STRIP ?= "${@bb.utils.contains('DISTRO_FEATURES', 'modsign', '1', '0', d)}"
Signature · 1 line
2.20.1
author
#2 lore raw

чт, 8 авг. 2019 г. в 14:44, Mittal, Anuj <[email protected]>:

Quoted 11 lines · On Thu, 2019-08-08 at 12:57 +0300, [email protected] wrote:
Quoted 5 lines

From: Dmitry Eremin-Solenikov <[email protected]>

Stripping kernel modules will also remove signature, thus we have to inhibit package striping in case modules signatures are enabled.

Isn't this already being taken care of here:

https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=8fc56faa5d76927f42a4e7cca2418556e231938f

Hmm, true. I missed that commit.

Signature · 2 lines
With best wishes
Dmitry