selftests: Fix detection of nettest command in fcnal-test
Subsystems (3)
PATCH 1/1 selftests: Fix detection of nettest command in fcnal-test
From: David Ahern <[email protected]>
Most of the tests run by fcnal-test.sh relies on the nettest command. Rather than trying to cover all of the individual tests, check for the binary only at the beginning.
Also removes the need for log_error which is undefined.
Fixes 6f9d5cacfe07 ("selftests: Setup for functional tests for fib and socket lookups")
Signed-off-by David Ahern <[email protected]>
--- tools/testing/selftests/net/fcnal-test.sh | 38 +++++-------------------------- 1 file changed, 6 insertions(+), 32 deletions(-)
tools/testing/selftests/net/fcnal-test.sh +6 -32
@@ -998,13 +998,6 @@ ipv4_tcp_vrf() ipv4_tcp() { log_section "IPv4/TCP" - - which nettest >/dev/null - if [ $? -ne 0 ]; then - log_error "nettest not found; skipping tests" - return - fi - log_subsection "No VRF" setup
@@ -1375,12 +1368,6 @@ ipv4_udp_vrf() ipv4_udp() { - which nettest >/dev/null - if [ $? -ne 0 ]; then - log_error "nettest not found; skipping tests" - return - fi - log_section "IPv4/UDP" log_subsection "No VRF"
@@ -2314,13 +2301,6 @@ ipv6_tcp_vrf() ipv6_tcp() { log_section "IPv6/TCP" - - which nettest >/dev/null - if [ $? -ne 0 ]; then - log_error "nettest not found; skipping tests" - return - fi - log_subsection "No VRF" setup
@@ -3156,12 +3136,6 @@ netfilter_icmp() ipv4_netfilter() { - which nettest >/dev/null - if [ $? -ne 0 ]; then - log_error "nettest not found; skipping tests" - return - fi - log_section "IPv4 Netfilter" log_subsection "TCP reset"
@@ -3219,12 +3193,6 @@ netfilter_icmp6() ipv6_netfilter() { - which nettest >/dev/null - if [ $? -ne 0 ]; then - log_error "nettest not found; skipping tests" - return - fi - log_section "IPv6 Netfilter" log_subsection "TCP reset"
@@ -3422,6 +3390,12 @@ elif [ "$TESTS" = "ipv6" ]; then TESTS="$TESTS_IPV6" fi +which nettest >/dev/null +if [ $? -ne 0 ]; then + echo "'nettest' command not found; skipping tests" + exit 0 +fi + declare -i nfail=0 declare -i nsuccess=0
Signature · 1 line
2.11.0
From: David Ahern <[email protected]>
Date: Fri, 9 Aug 2019 16:13:38 -0700
Quoted 10 lines
From: David Ahern <[email protected]>
Most of the tests run by
fcnal-test.shrelies on the nettest command. Rather than trying to cover all of the individual tests, check for the binary only at the beginning.Also removes the need for
log_errorwhich is undefined.Fixes 6f9d5cacfe07 ("selftests: Setup for functional tests for fib and socket lookups")Signed-off-by David Ahern <[email protected]>
Applied, thanks David.