Skip to contentSkip to conversation

sh: kernel: hw_breakpoint: Fix missing break in switch statement

PATCH In review Gustavo A. R. Silva 4 participants 4 messages Aug 10, 2019 – Aug 13, 2019 SuperH

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 sh: kernel: hw_breakpoint: Fix missing break in switch statement

Add missing break statement in order to prevent the code from erroneously falling through to case SH_BREAKPOINT_WRITE.

Fixes 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
Cc [email protected]
Signed-off-by Gustavo A. R. Silva <[email protected]>

---

If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.

 arch/sh/kernel/hw_breakpoint.c | 1 +
 1 file changed, 1 insertion(+)
arch/sh/kernel/hw_breakpoint.c +1 -0
index 3bd010b4c55f..f10d64311127 100644
@@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
 	switch (sh_type) {
 	case SH_BREAKPOINT_READ:
 		*gen_type = HW_BREAKPOINT_R;
+		break;
 	case SH_BREAKPOINT_WRITE:
 		*gen_type = HW_BREAKPOINT_W;
 		break;
Signature · 1 line
2.22.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

Add missing break statement in order to prevent the code from erroneously falling through to case SH_BREAKPOINT_WRITE.

Fixes 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
Cc [email protected]
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Reviewed-by Tested-by on v1 1/1
#2 lore raw
In reply to Gustavo A. R. Silva
Quoted 6 lines · Gustavo A. R. Silva

Add missing break statement in order to prevent the code from erroneously falling through to case SH_BREAKPOINT_WRITE.

Fixes 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
Cc [email protected]
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Tested-by Guenter Roeck <[email protected]>
Quoted 22 lines

---

If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.

 arch/sh/kernel/hw_breakpoint.c | 1 +
 1 file changed, 1 insertion(+)
arch/sh/kernel/hw_breakpoint.c +1 -0
index 3bd010b4c55f..f10d64311127 100644
@@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
 	switch (sh_type) {
 	case SH_BREAKPOINT_READ:
 		*gen_type = HW_BREAKPOINT_R;
+		break;
 	case SH_BREAKPOINT_WRITE:
 		*gen_type = HW_BREAKPOINT_W;
 		break;
Signature · 1 line
2.22.0
maintainer
#3 lore raw
In reply to Gustavo A. R. Silva
Quoted 29 lines · Gustavo A. R. Silva

Add missing break statement in order to prevent the code from erroneously falling through to case SH_BREAKPOINT_WRITE.

Fixes 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
Cc [email protected]
Signed-off-by Gustavo A. R. Silva <[email protected]>

---

If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.

 arch/sh/kernel/hw_breakpoint.c | 1 +
 1 file changed, 1 insertion(+)
arch/sh/kernel/hw_breakpoint.c +1 -0
index 3bd010b4c55f..f10d64311127 100644
@@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
 	switch (sh_type) {
 	case SH_BREAKPOINT_READ:
 		*gen_type = HW_BREAKPOINT_R;
+		break;
 	case SH_BREAKPOINT_WRITE:
 		*gen_type = HW_BREAKPOINT_W;
 		break;
Signature · 1 line
2.22.0

Applied sh-next.
Thanks.

Signature · 1 line
Yosinori Sato