caif: no need to check return value of debugfs_create functions
Subsystems (2)
PATCH 1/1 caif: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Richard Fontana <[email protected]>
Cc Steve Winslow <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/net/caif/caif_serial.c | 26 ++++++++++---------------- drivers/net/caif/caif_virtio.c | 6 +----- 2 files changed, 11 insertions(+), 21 deletions(-)
drivers/net/caif/caif_serial.c +10 -16
@@ -94,26 +94,20 @@ static inline void update_tty_status(struct ser_device *ser) }static inline void debugfs_init (struct ser_device *ser,struct tty_struct *tty) { - ser->debugfs_tty_dir = -debugfs_create_dir (tty->name, debugfsdir); -if (!IS_ERR (ser->debugfs_tty_dir)) { -debugfs_create_blob ("last_tx_msg" ,0400 , - ser->debugfs_tty_dir, - &ser->tx_blob); + ser->debugfs_tty_dir =debugfs_create_dir (tty->name, debugfsdir); -debugfs_create_blob ("last_rx_msg" ,0400 , - ser->debugfs_tty_dir, - &ser->rx_blob); +debugfs_create_blob ("last_tx_msg" ,0400 , ser->debugfs_tty_dir, + &ser->tx_blob); -debugfs_create_x32 ("ser_state" ,0400 , - ser->debugfs_tty_dir, - (u32 *)&ser->state); +debugfs_create_blob ("last_rx_msg" ,0400 , ser->debugfs_tty_dir, + &ser->rx_blob); -debugfs_create_x8 ("tty_status" ,0400 , - ser->debugfs_tty_dir, - &ser->tty_status); +debugfs_create_x32 ("ser_state" ,0400 , ser->debugfs_tty_dir, + (u32 *)&ser->state); + +debugfs_create_x8 ("tty_status" ,0400 , ser->debugfs_tty_dir, + &ser->tty_status); - } ser->tx_blob.data = ser->tx_data; ser->tx_blob.size =0 ; ser->rx_blob.data = ser->rx_data;
drivers/net/caif/caif_virtio.c +1 -5
@@ -623,11 +623,7 @@ static void cfv_netdev_setup(struct net_device *netdev)/* Create debugfs counters for the device */ static inline void debugfs_init (struct cfv_info *cfv) { - cfv->debugfs = -debugfs_create_dir (netdev_name (cfv->ndev),NULL ); - -if (IS_ERR (cfv->debugfs)) -return ; + cfv->debugfs =debugfs_create_dir (netdev_name (cfv->ndev),NULL );debugfs_create_u32 ("rx-napi-complete" ,0400 , cfv->debugfs, &cfv->stats.rx_napi_complete);
Signature · 1 line
2.22.0
From: Greg Kroah-Hartman <[email protected]>
Date: Sat, 10 Aug 2019 12:42:43 +0200
Quoted 8 lines
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Richard Fontana <[email protected]>Cc Steve Winslow <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Applied.