Skip to contentSkip to conversation

blk-sysfs: Make structure queue_attr_group constant

PATCH New Nishka Dasgupta 1 participant 1 message Aug 13, 2019 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blk-sysfs: Make structure queue_attr_group constant

The static structure queue_attr_group is used only once, when it is passed as the second argument to the function sysfs_create_group(). However, the second parameter of sysfs_create_group() is already defined as constant. Hence make queue_attr_group itself constant, as it is never modified.
Issue found with Coccinelle.

---
 block/blk-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-sysfs.c +1 -1
index 977c659dcd18..9401b0cc2e29 100644
@@ -783,7 +783,7 @@ static umode_t queue_attr_visible(struct kobject *kobj, struct attribute *attr,
 	return attr->mode;
 }
 
-static struct attribute_group queue_attr_group = {
+static const struct attribute_group queue_attr_group = {
 	.attrs = queue_attrs,
 	.is_visible = queue_attr_visible,
 };
Signature · 1 line
2.19.1