nvme-tcp: Make nvme_tcp_mq_ops constant
PATCH 1/1 nvme-tcp: Make nvme_tcp_mq_ops constant
Static structure nvme_tcp_mq_ops, of type blk_mq_ops, is not used except to be assigned to field ops of variable set. Variable set itself has type blk_mq_tag_set, whose field ops is declared as const. Hence nvme_tcp_mq_ops cannot be modified after being assigned to field ops of variable set. Therefore declare nvme_tcp_mq_ops const as well. Issue found with Coccinelle.
--- drivers/nvme/host/tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/host/tcp.c +2 -2
@@ -117,7 +117,7 @@ struct nvme_tcp_ctrl {static LIST_HEAD (nvme_tcp_ctrl_list);static DEFINE_MUTEX (nvme_tcp_ctrl_mutex);static struct workqueue_struct *nvme_tcp_wq; -static struct blk_mq_ops nvme_tcp_mq_ops; +static const struct blk_mq_ops nvme_tcp_mq_ops;static struct blk_mq_ops nvme_tcp_admin_mq_ops;static inline struct nvme_tcp_ctrl *to_tcp_ctrl (struct nvme_ctrl *ctrl)
@@ -2159,7 +2159,7 @@ static int nvme_tcp_map_queues(struct blk_mq_tag_set *set)return 0 ; } -static struct blk_mq_ops nvme_tcp_mq_ops = { +static const struct blk_mq_ops nvme_tcp_mq_ops = { .queue_rq = nvme_tcp_queue_rq, .complete = nvme_complete_rq, .init_request = nvme_tcp_init_request,
Signature · 1 line
2.19.1
Sagi Grimberg
maintainerPATCH 1/1 nvme-tcp: Make nvme_tcp_mq_ops constant
Quoted 8 lines
Static structure
nvme_tcp_mq_ops, of typeblk_mq_ops, is not used except to be assigned to field ops of variable set. Variable set itself has typeblk_mq_tag_set, whose field ops is declared as const. Hencenvme_tcp_mq_opscannot be modified after being assigned to field ops of variable set. Therefore declarenvme_tcp_mq_opsconst as well. Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <nishkadg.linux at gmail.com>
Looks fine,
Can you please respin a patch that applies cleanly on nvme-5.4?
You can add my: Reviewed-by: Sagi Grimberg <sagi at grimberg.me>