Skip to contentSkip to conversation

Regression in Linux next with show wakeup sources stats in sysfs

DISCUSSION Tony Lindgren 2 participants 4 messages Aug 14, 2019 Power supply

lore
Share & tools
lore
#0 lore raw

Hi all,

Looks like commit 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs") has caused a regression in Linux next where I can now get some errors like this during the boot:

kobject_add_internal failed for wakeup10 (error: -2 parent: usb)

Any ideas why this might be happening? Maybe some deferred probe related issue?

Regards,

Tony

#1 lore raw

Quoting Tony Lindgren (2019-08-13 23:38:03)

Quoted 11 lines

Hi all,

Looks like commit 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs") has caused a regression in Linux next where I can now get some errors like this during the boot:

kobject_add_internal failed for wakeup10 (error: -2 parent: usb)

Any ideas why this might be happening? Maybe some deferred probe related issue?

Yeah! Take a look at this thread[1] and please test out patches I'm throwing out there like a total cowboy(d).

[1] https://lkml.kernel.org/r/[email protected]

#2 lore raw
Quoted 9 lines · Stephen Boyd

Quoting Tony Lindgren (2019-08-13 23:38:03)

Quoted 8 lines

Hi all,

Looks like commit 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs") has caused a regression in Linux next where I can now get some errors like this during the boot:

kobject_add_internal failed for wakeup10 (error: -2 parent: usb)

Quoted 8 lines
Quoted 3 lines

Any ideas why this might be happening? Maybe some deferred probe related issue?

Yeah! Take a look at this thread[1] and please test out patches I'm throwing out there like a total cowboy(d).

[1] https://lkml.kernel.org/r/[email protected]

Oh OK thanks, looks like I'm a bit behind then. My test case turned out to be caused by device_init_wakeup() called before device_add() for power_supply in case that helps. In that case create_dir() will fail for kobject_add_internal(). Doing something like below fixes the issue, but seems like we probably have other similar issues as well. Adding Sebastian to Cc in case this might be a real problem despite the other issues.

Regards,

Tony

8< -----------------------

drivers/power/supply/power_supply_core.c +5 -5
@@ -1051,14 +1051,14 @@ __power_supply_register(struct device *parent,
 	}
 
 	spin_lock_init(&psy->changed_lock);
-	rc = device_init_wakeup(dev, ws);
-	if (rc)
-		goto wakeup_init_failed;
-
 	rc = device_add(dev);
 	if (rc)
 		goto device_add_failed;
 
+	rc = device_init_wakeup(dev, ws);
+	if (rc)
+		goto wakeup_init_failed;
+
 	rc = psy_register_thermal(psy);
 	if (rc)
 		goto register_thermal_failed;
@@ -1100,9 +1100,9 @@ __power_supply_register(struct device *parent,
 register_cooler_failed:
 	psy_unregister_thermal(psy);
 register_thermal_failed:
+wakeup_init_failed:
 	device_del(dev);
 device_add_failed:
-wakeup_init_failed:
 check_supplies_failed:
 dev_set_name_failed:
 	put_device(dev);
#3 lore raw

Quoting Tony Lindgren (2019-08-14 00:32:34)

Quoted 19 lines · Stephen Boyd
Quoted 9 lines

Quoting Tony Lindgren (2019-08-13 23:38:03)

Quoted 8 lines

Hi all,

Looks like commit 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs") has caused a regression in Linux next where I can now get some errors like this during the boot:

kobject_add_internal failed for wakeup10 (error: -2 parent: usb)

Quoted 8 lines
Quoted 3 lines

Any ideas why this might be happening? Maybe some deferred probe related issue?

Yeah! Take a look at this thread[1] and please test out patches I'm throwing out there like a total cowboy(d).

[1] https://lkml.kernel.org/r/[email protected]

Quoted 8 lines

Oh OK thanks, looks like I'm a bit behind then. My test case turned out to be caused by device_init_wakeup() called before device_add() for power_supply in case that helps. In that case create_dir() will fail for kobject_add_internal(). Doing something like below fixes the issue, but seems like we probably have other similar issues as well. Adding Sebastian to Cc in case this might be a real problem despite the other issues.

Ah yeah. I sent a patch for power supply earlier[2], but now I'm thinking that it would be better to take the approach in the thread I mentioned where we just don't add sysfs stuff until when device_add() is called.

[2] https://lkml.kernel.org/r/[email protected]