src: json: fix constant parsing on bigendian
Florian Westphal
maintainerPATCH 1/1 src: json: fix constant parsing on bigendian
json restore is broken on big-endian because we errounously passed uint8_t with 64 bit size indicator.
On bigendian, this causes all values to get shifted by 56 bit, this will then cause the eval step to bail because all values are outside of the 8bit 0-255 protocol range.
Signed-off-by Florian Westphal <[email protected]>
--- src/parser_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/parser_json.c +1 -1
@@ -304,7 +304,7 @@ static struct expr *json_parse_constant(struct json_ctx *ctx, const char *name)return constant_expr_alloc (int_loc, constant_tbl[i].dtype,BYTEORDER_HOST_ENDIAN , -8 *BITS_PER_BYTE , +BITS_PER_BYTE , &constant_tbl[i].data); }json_error (ctx,"Unknown constant '%s'." , name);
Signature · 1 line
2.21.0
Quoted 8 lines · Florian Westphal
json restore is broken on big-endian because we errounously passed
uint8_twith 64 bit size indicator.On bigendian, this causes all values to get shifted by 56 bit, this will then cause the eval step to bail because all values are outside of the 8bit 0-255 protocol range.
Signed-off-by Florian Westphal <[email protected]>