Add support for ethtool via TARGET_SIOCETHTOOL ioctls.
PATCH 1/1 Add support for ethtool via TARGET_SIOCETHTOOL ioctls.
The ioctl numeric values are platform-independent and determined by the file include/uapi/linux/sockios.h in Linux kernel source code:
#define SIOCETHTOOL 0x8946
These ioctls get (or set) the field ifr_data of type char* in the structure ifreq. Such functionality is achieved in QEMU by using MK_STRUCT() and MK_PTR() macros with an appropriate argument, as it was done for existing similar cases.
--- linux-user/ioctls.h | 1 + linux-user/syscall_defs.h | 2 ++ 2 files changed, 3 insertions(+)
linux-user/ioctls.h +1 -0
@@ -208,6 +208,7 @@ IOCTL(SIOCGIFINDEX, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_int_ifreq))) IOCTL(SIOCSIFPFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) IOCTL(SIOCGIFPFLAGS, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) + IOCTL(SIOCETHTOOL, IOC_R | IOC_W, MK_PTR(MK_STRUCT(STRUCT_ptr_ifreq))) IOCTL(SIOCSIFLINK, 0, TYPE_NULL)IOCTL_SPECIAL (SIOCGIFCONF ,IOC_W |IOC_R , do_ioctl_ifconf,MK_PTR (MK_STRUCT (STRUCT_ifconf)))
linux-user/syscall_defs.h +2 -0
@@ -819,6 +819,8 @@ struct target_pollfd {#define TARGET_SIOCGIFTXQLEN 0x8942/* Get the tx queue length */ #define TARGET_SIOCSIFTXQLEN 0x8943/* Set the tx queue length */ +#define TARGET_SIOCETHTOOL 0x8946/* Ethtool interface */ +/* ARP cache control calls. */ #define TARGET_OLD_SIOCDARP 0x8950/* old delete ARP table entry */ #define TARGET_OLD_SIOCGARP 0x8951/* old get ARP table entry */
Signature · 1 line
2.23.0.rc1.153.gdeed80330f-goog
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series seems to have some coding style problems. See output below for more information:
Type: series
Subject: [Qemu-devel] [PATCH] Add support for ethtool via TARGET_SIOCETHTOOL ioctls.
Message-id: [email protected]
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/[email protected] -> patchew/[email protected]
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp'
Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3'
Cloning into 'roms/edk2'...
Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54'
Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3' Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl' Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'CryptoPkg/Library/OpensslLib/openssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687' Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl'
Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5'
Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography'
Cloning into 'boringssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f' Cloning into 'krb5'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168' Cloning into 'pyca-cryptography'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f' Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 'c79e0ecb84f4f1ee3f73f521622e264edd1bf174'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/opensbi'...
Submodule path 'roms/opensbi': checked out 'ce228ee0919deb9957192d723eecc8aaae2697c6'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 'bf0e13698872450164fa7040da36a95d2d4b326f'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a5cab58e9a3fb6e168aba919c5669bea406573b4'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '0f4fe84658165e96ce35870fd19fc634e182e77b'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out '261ca8e779e5138869a45f174caa49be6a274501'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd3689267f92c5956e09cc7d1baa4700141662bff'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'slirp'...
Submodule path 'slirp': checked out '126c04acbabd7ad32c2b018fe10dfac2a3bc1210'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
d320ddf Add support for ethtool via TARGET_SIOCETHTOOL ioctls.
=== OUTPUT BEGIN ===
ERROR: Author email address is mangled by the mailing list #2:
Author: Shu-Chun Weng via Qemu-devel <[email protected]>
WARNING: line over 80 characters
#40: FILE: linux-user/syscall_defs.h:822:
+#define TARGET_SIOCETHTOOL 0x8946 /* Ethtool interface */
total: 1 errors, 1 warnings, 15 lines checked
Commit d320ddf9402b (Add support for ethtool via TARGET_SIOCETHTOOL ioctls.) has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]
16.08.2019. 23.28, "Shu-Chun Weng via Qemu-devel" <[email protected]> је написао/ла:
Quoted 6 lines
The ioctl numeric values are platform-independent and determined by the file
include/uapi/linux/sockios.hin Linux kernel source code:#define SIOCETHTOOL 0x8946
Quoted 7 lines
These ioctls get (or set) the field
ifr_dataof type char* in the structure ifreq. Such functionality is achieved in QEMU by usingMK_STRUCT()andMK_PTR()macros with an appropriate argument, as it was done for existing similar cases.Signed-off-by Shu-Chun Weng <[email protected]>---
Shu-Chun, hi, and welcome!
Just a couple of cosmetic things:
- by convention, the title of this patch should start with "linux-user:",
since this patch affects linux user QEMU module;
- the patch title is too long (and has some minor mistakes) -
"linux-user: Add support for SIOCETHTOOL ioctl" should be good enough;
- the lenght of the code lines that you add or modify must not be greater
than 80.
Sincerely,
Aleksandar
linux-user/ioctls.h line 210
Quoted 12 lines
linux-user/ioctls.h | 1 + linux-user/syscall_defs.h | 2 ++ 2 files changed, 3 insertions(+)linux-user/ioctls.h +0
-0@@ -208,6 +208,7 @@ IOCTL(SIOCGIFINDEX, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_int_ifreq))) IOCTL(SIOCSIFPFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) IOCTL(SIOCGIFPFLAGS, IOC_W | IOC_R,
MK_PTR(MK_STRUCT(STRUCT_short_ifreq)))
linux-user/syscall_defs.h struct target_pollfd { · line 819
Quoted 10 lines
linux-user/ioctls.h +1
-0+ IOCTL(SIOCETHTOOL, IOC_R | IOC_W, MK_PTR(MK_STRUCT(STRUCT_ptr_ifreq))) IOCTL(SIOCSIFLINK, 0, TYPE_NULL)IOCTL_SPECIAL (SIOCGIFCONF ,IOC_W |IOC_R , do_ioctl_ifconf,MK_PTR (MK_STRUCT (STRUCT_ifconf)))linux-user/syscall_defs.h +0
-0@@ -819,6 +819,8 @@ struct target_pollfd {#define TARGET_SIOCGIFTXQLEN 0x8942/* Get the tx queue
length */
linux-user/syscall_defs.h struct target_pollfd { · line 820
Quoted 1 line
linux-user/syscall_defs.h +0
-0#define TARGET_SIOCSIFTXQLEN 0x8943/* Set the tx queue
length */
linux-user/syscall_defs.h struct target_pollfd { · line 821
Quoted 2 lines
linux-user/syscall_defs.h +1
-0+#define TARGET_SIOCETHTOOL 0x8946/* Ethtool interface
*/
linux-user/syscall_defs.h struct target_pollfd {
Quoted 3 lines
linux-user/syscall_defs.h +1
-0+/* ARP cache control calls. */ #define TARGET_OLD_SIOCDARP 0x8950/* old delete ARP table
entry */
linux-user/syscall_defs.h struct target_pollfd { · line 825
Quoted 1 line
linux-user/syscall_defs.h +0
-0#define TARGET_OLD_SIOCGARP 0x8951/* old get ARP table
entry */
Quoted 4 lines
linux-user/syscall_defs.h +0
-1--2.23.0.rc1.153.gdeed80330f-goog
Thank you Aleksandar,
I've updated the patch description and will send out v2 soon.
As for the length of the line: all lines in file syscall_defs.h are of length 81 with a fixed width comment at the end. I'm not sure if making the one line I add 80-character-wide is the right choice.
Shu-Chun
Quoted 74 lines · Aleksandar Markovic
16.08.2019. 23.28, "Shu-Chun Weng via Qemu-devel" <[email protected]> је написао/ла:
Quoted 6 lines
The ioctl numeric values are platform-independent and determined by the file
include/uapi/linux/sockios.hin Linux kernel source code:#define SIOCETHTOOL 0x8946Quoted 7 lines
These ioctls get (or set) the field
ifr_dataof type char* in the structure ifreq. Such functionality is achieved in QEMU by usingMK_STRUCT()andMK_PTR()macros with an appropriate argument, as it was done for existing similar cases.Signed-off-by Shu-Chun Weng <[email protected]>---
Shu-Chun, hi, and welcome!
Just a couple of cosmetic things:
- by convention, the title of this patch should start with
"linux-user:", since this patch affects linux user QEMU module;- the patch title is too long (and has some minor mistakes) -
"linux-user: Add support for SIOCETHTOOL ioctl" should be good enough;- the lenght of the code lines that you add or modify must not be
greater than 80.Sincerely,
Aleksandarlinux-user/ioctls.h line 208
Quoted 10 lines
linux-user/ioctls.h | 1 + linux-user/syscall_defs.h | 2 ++ 2 files changed, 3 insertions(+)linux-user/ioctls.h +0
-0@@ -208,6 +208,7 @@ IOCTL(SIOCGIFINDEX, IOC_W | IOC_R,MK_PTR(MK_STRUCT(STRUCT_int_ifreq)))
linux-user/ioctls.h line 210
Quoted 2 lines
linux-user/ioctls.h +0
-0IOCTL(SIOCSIFPFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) IOCTL(SIOCGIFPFLAGS, IOC_W | IOC_R,MK_PTR(MK_STRUCT(STRUCT_short_ifreq)))
linux-user/syscall_defs.h struct target_pollfd { · line 819
Quoted 10 lines
linux-user/ioctls.h +1
-0+ IOCTL(SIOCETHTOOL, IOC_R | IOC_W, MK_PTR(MK_STRUCT(STRUCT_ptr_ifreq))) IOCTL(SIOCSIFLINK, 0, TYPE_NULL)IOCTL_SPECIAL (SIOCGIFCONF ,IOC_W |IOC_R , do_ioctl_ifconf,MK_PTR (MK_STRUCT (STRUCT_ifconf)))linux-user/syscall_defs.h +0
-0@@ -819,6 +819,8 @@ struct target_pollfd {#define TARGET_SIOCGIFTXQLEN 0x8942/* Get the tx queue length */
linux-user/syscall_defs.h struct target_pollfd { · line 820
Quoted 1 line
linux-user/syscall_defs.h +0
-0#define TARGET_SIOCSIFTXQLEN 0x8943/* Set the tx queue length */
linux-user/syscall_defs.h struct target_pollfd { · line 821
Quoted 2 lines
linux-user/syscall_defs.h +1
-0+#define TARGET_SIOCETHTOOL 0x8946/* Ethtool interface */linux-user/syscall_defs.h struct target_pollfd {
Quoted 3 lines
linux-user/syscall_defs.h +1
-0+/* ARP cache control calls. */ #define TARGET_OLD_SIOCDARP 0x8950/* old delete ARP table entry */
linux-user/syscall_defs.h struct target_pollfd { · line 825
Quoted 1 line
linux-user/syscall_defs.h +0
-0#define TARGET_OLD_SIOCGARP 0x8951/* old get ARP table entry */
Quoted 4 lines
linux-user/syscall_defs.h +0
-1--2.23.0.rc1.153.gdeed80330f-goog
PATCH v2 1/1 linux-user: Add support for SIOCETHTOOL ioctl
In reply to Aleksandar MarkovicThe ioctl numeric values are platform-independent and determined by the file include/uapi/linux/sockios.h in Linux kernel source code:
#define SIOCETHTOOL 0x8946
These ioctls get (or set) the field ifr_data of type char* in the structure ifreq. Such functionality is achieved in QEMU by using MK_STRUCT() and MK_PTR() macros with an appropriate argument, as it was done for existing similar cases.
--- linux-user/ioctls.h | 1 + linux-user/syscall_defs.h | 2 ++ 2 files changed, 3 insertions(+)
linux-user/ioctls.h +1 -0
@@ -208,6 +208,7 @@ IOCTL(SIOCGIFINDEX, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_int_ifreq))) IOCTL(SIOCSIFPFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) IOCTL(SIOCGIFPFLAGS, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) + IOCTL(SIOCETHTOOL, IOC_R | IOC_W, MK_PTR(MK_STRUCT(STRUCT_ptr_ifreq))) IOCTL(SIOCSIFLINK, 0, TYPE_NULL)IOCTL_SPECIAL (SIOCGIFCONF ,IOC_W |IOC_R , do_ioctl_ifconf,MK_PTR (MK_STRUCT (STRUCT_ifconf)))
linux-user/syscall_defs.h +2 -0
@@ -819,6 +819,8 @@ struct target_pollfd {#define TARGET_SIOCGIFTXQLEN 0x8942/* Get the tx queue length */ #define TARGET_SIOCSIFTXQLEN 0x8943/* Set the tx queue length */ +#define TARGET_SIOCETHTOOL 0x8946/* Ethtool interface */ +/* ARP cache control calls. */ #define TARGET_OLD_SIOCDARP 0x8950/* old delete ARP table entry */ #define TARGET_OLD_SIOCGARP 0x8951/* old get ARP table entry */
Signature · 1 line
2.23.0.rc1.153.gdeed80330f-goog
Re: [Qemu-devel] [PATCH v2] linux-user: Add support for SIOCETHTOOL ioctl
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series seems to have some coding style problems. See output below for more information:
Type: series
Subject: [Qemu-devel] [PATCH v2] linux-user: Add support for SIOCETHTOOL ioctl
Message-id: [email protected]
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/[email protected] -> patchew/[email protected]
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp'
Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3'
Cloning into 'roms/edk2'...
Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54'
Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3' Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl' Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'CryptoPkg/Library/OpensslLib/openssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687' Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl'
Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5'
Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography'
Cloning into 'boringssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f' Cloning into 'krb5'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168' Cloning into 'pyca-cryptography'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f' Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 'c79e0ecb84f4f1ee3f73f521622e264edd1bf174'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/opensbi'...
Submodule path 'roms/opensbi': checked out 'ce228ee0919deb9957192d723eecc8aaae2697c6'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 'bf0e13698872450164fa7040da36a95d2d4b326f'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a5cab58e9a3fb6e168aba919c5669bea406573b4'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '0f4fe84658165e96ce35870fd19fc634e182e77b'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out '261ca8e779e5138869a45f174caa49be6a274501'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd3689267f92c5956e09cc7d1baa4700141662bff'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'slirp'...
Submodule path 'slirp': checked out '126c04acbabd7ad32c2b018fe10dfac2a3bc1210'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
3d17f40 linux-user: Add support for SIOCETHTOOL ioctl
=== OUTPUT BEGIN ===
ERROR: Author email address is mangled by the mailing list #2:
Author: Shu-Chun Weng via Qemu-devel <[email protected]>
WARNING: line over 80 characters
#40: FILE: linux-user/syscall_defs.h:822:
+#define TARGET_SIOCETHTOOL 0x8946 /* Ethtool interface */
total: 1 errors, 1 warnings, 15 lines checked
Commit 3d17f40c72b6 (linux-user: Add support for SIOCETHTOOL ioctl) has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]
Hi Shu-Chun Weng via Qemu-devel!
We received your email, but were unable to deliver it because it contains content which has been blacklisted by the list admin. Please remove your application/pkcs7-signature attachments and send again.
You are also advised to configure your email client to send emails in plain text to avoid additional errors in the future:
If you have any questions, please reply to this email to reach the mail admin. We apologise for the inconvenience.
Re: [Qemu-devel] [PATCH v2] linux-user: Add support for SIOCETHTOOL ioctl
In reply to Shu-Chun Weng via Qemu-develLe 17/08/2019 à 02:07, Shu-Chun Weng via Qemu-devel a écrit :
Quoted 9 lines
The ioctl numeric values are platform-independent and determined by the file
include/uapi/linux/sockios.hin Linux kernel source code:#define SIOCETHTOOL 0x8946These ioctls get (or set) the field
ifr_dataof type char* in the structure ifreq. Such functionality is achieved in QEMU by usingMK_STRUCT()andMK_PTR()macros with an appropriate argument, as it was done for existing similar cases.
I think it's a little bit more complicated...
According to kernel code in dev_ethtool(), ifr_data points to 32bit value which is a sub-command (ETHTOOL_*), so this value must be converted to the good endianness.
Then this sub-command can have parameters and thus these parameters must be converted too.
Thanks,
Laurent