ipvs: change type of delta and previous_delta in ip_vs_seq.
Subsystems (4)
PATCH 1/1 ipvs: change type of delta and previous_delta in ip_vs_seq.
In NAT forwarding mode, Applications may decrease the size of packets, and TCP sequences will get smaller, so both of variables will be negetive values in this case.
Signed-off-by zhang kai <[email protected]>
--- include/net/ip_vs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/net/ip_vs.h +2 -2
@@ -346,8 +346,8 @@ enum ip_vs_sctp_states {*/ struct ip_vs_seq {__u32 init_seq;/* Add delta from this seq */ -__u32 delta;/* Delta in sequence numbers */ -__u32 previous_delta;/* Delta in sequence numbers +__s32 delta;/* Delta in sequence numbers */ +__s32 previous_delta;/* Delta in sequence numbers * before last resized pkt */ };
Signature · 1 line
2.17.1
Julian Anastasov
maintainerHello,
Cc list trimmed...
Quoted 3 lines · zhang kai
In NAT forwarding mode, Applications may decrease the size of packets, and TCP sequences will get smaller, so both of variables will be negetive values in this case.
As long as nobody cares about their sign, the type should not
matter. You can not solve all signed/unsigned mismatches with such small patch. Or you are seeing some problem, may be in debug?
Quoted 23 lines
Signed-off-by zhang kai <[email protected]>--- include/net/ip_vs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)include/net/ip_vs.h +2
-2@@ -346,8 +346,8 @@ enum ip_vs_sctp_states {*/ struct ip_vs_seq {__u32 init_seq;/* Add delta from this seq */ -__u32 delta;/* Delta in sequence numbers */ -__u32 previous_delta;/* Delta in sequence numbers +__s32 delta;/* Delta in sequence numbers */ +__s32 previous_delta;/* Delta in sequence numbers * before last resized pkt */ };Signature · 1 line
2.17.1
Regards