Skip to contentSkip to conversation

tracing: Drop static keyword for exported ftrace_set_clr_event()

PATCH In review Andy Shevchenko 2 participants 4 messages Aug 30, 2019 – Sep 4, 2019 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: Drop static keyword for exported ftrace_set_clr_event()

When we export something, it shan't be static.

Fixes f45d1225adb0 ("tracing: Kernel access to Ftrace instances")
Cc Divya Indi <[email protected]>
---
 include/linux/trace_events.h | 1 +
 kernel/trace/trace_events.c  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
include/linux/trace_events.h +1 -0
index 5150436783e8..30a8cdcfd4a4 100644
@@ -548,6 +548,7 @@ extern int trace_event_get_offsets(struct trace_event_call *call);
 
 #define is_signed_type(type)	(((type)(-1)) < (type)1)
 
+int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set);
 int trace_set_clr_event(const char *system, const char *event, int set);
 
 /*
kernel/trace/trace_events.c +1 -1
index 5a189fb8ec23..b89cdfe20bc1 100644
@@ -787,7 +787,7 @@ static int __ftrace_set_clr_event(struct trace_array *tr, const char *match,
 	return ret;
 }
 
-static int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
+int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
 {
 	char *event = NULL, *sub = NULL, *match;
 	int ret;
Signature · 1 line
2.23.0.rc1
maintainer
#1 lore raw
Quoted 1 line · On Fri, 30 Aug 2019 22:32:28 +0300 Andy Shevchenko…

When we export something, it shan't be static.

I'm finally getting around to my patch queue (it's unfortunately much bigger than I should be). But my punishment is duplicate patches.

Someone beat you to it...

http://lkml.kernel.org/r/[email protected]

-- Steve

Quoted 34 lines
Fixes f45d1225adb0 ("tracing: Kernel access to Ftrace instances")
Cc Divya Indi <[email protected]>
---
 include/linux/trace_events.h | 1 +
 kernel/trace/trace_events.c  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
include/linux/trace_events.h +1 -0
index 5150436783e8..30a8cdcfd4a4 100644
@@ -548,6 +548,7 @@ extern int trace_event_get_offsets(struct trace_event_call *call);
 
 #define is_signed_type(type)	(((type)(-1)) < (type)1)
 
+int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set);
 int trace_set_clr_event(const char *system, const char *event, int set);
 
 /*
kernel/trace/trace_events.c +1 -1
index 5a189fb8ec23..b89cdfe20bc1 100644
@@ -787,7 +787,7 @@ static int __ftrace_set_clr_event(struct trace_array *tr, const char *match,
 	return ret;
 }
 
-static int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
+int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
 {
 	char *event = NULL, *sub = NULL, *match;
 	int ret;
#2 lore raw
Quoted 11 lines · Steven Rostedt
Quoted 1 line · On Fri, 30 Aug 2019 22:32:28 +0300 Andy Shevchenko…

When we export something, it shan't be static.

I'm finally getting around to my patch queue (it's unfortunately much bigger than I should be). But my punishment is duplicate patches.

Someone beat you to it...

http://lkml.kernel.org/r/[email protected]

Looking to the original patch and taking into account that there is no user for it, I guess the best option to simple revert original one (it will clean up export table).

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#3 lore raw
Quoted 9 lines · On Mon, 2 Sep 2019 12:34:06 +0300 Andy Shevchenko…
Quoted 8 lines · Steven Rostedt
Quoted 1 line · On Fri, 30 Aug 2019 22:32:28 +0300 Andy Shevchenko…

When we export something, it shan't be static.

I'm finally getting around to my patch queue (it's unfortunately much bigger than I should be). But my punishment is duplicate patches.

Quoted 8 lines
Quoted 3 lines

Someone beat you to it...

http://lkml.kernel.org/r/[email protected]

Looking to the original patch and taking into account that there is no user for it, I guess the best option to simple revert original one (it will clean up export table).

Except there will be.

http://lkml.kernel.org/r/[email protected]

-- Steve