Commit 4659d637e271d7f2814c6763035553331cca3a3f seems broken

I got builds error with 4659d637e271d7f2814c6763035553331cca3a3f, but not with dcca03f27879701d7377109517176a3aae86619f.

[bruno@laptop2 src]$ make KERNELDIR=/lib/modules/5.3.0-0.rc6.git2.2.fc32.x86_64/build clean all

 CLEAN   /home/bruno/WireGuard/src
 CLEAN   /home/bruno/WireGuard/src/Module.symvers
 CLEAN   /home/bruno/WireGuard/src/tools/{wg,*.o,*.d}
 CC [M]  /home/bruno/WireGuard/src/main.o
 CC [M]  /home/bruno/WireGuard/src/noise.o
 CC [M]  /home/bruno/WireGuard/src/device.o
 CC [M]  /home/bruno/WireGuard/src/peer.o
 CC [M]  /home/bruno/WireGuard/src/timers.o
 CC [M]  /home/bruno/WireGuard/src/queueing.o
 CC [M]  /home/bruno/WireGuard/src/send.o
 CC [M]  /home/bruno/WireGuard/src/receive.o
 CC [M]  /home/bruno/WireGuard/src/socket.o
 CC [M]  /home/bruno/WireGuard/src/peerlookup.o
 CC [M]  /home/bruno/WireGuard/src/allowedips.o
 CC [M]  /home/bruno/WireGuard/src/ratelimiter.o
 CC [M]  /home/bruno/WireGuard/src/cookie.o
 CC [M]  /home/bruno/WireGuard/src/netlink.o
 CC [M]  /home/bruno/WireGuard/src/crypto/zinc/chacha20/chacha20.o
 PERLASM /home/bruno/WireGuard/src/crypto/zinc/chacha20/chacha20-x86_64.S
 AS [M]  /home/bruno/WireGuard/src/crypto/zinc/chacha20/chacha20-x86_64.o
 CC [M]  /home/bruno/WireGuard/src/crypto/zinc/poly1305/poly1305.o
 PERLASM /home/bruno/WireGuard/src/crypto/zinc/poly1305/poly1305-x86_64.S
 AS [M]  /home/bruno/WireGuard/src/crypto/zinc/poly1305/poly1305-x86_64.o
 CC [M]  /home/bruno/WireGuard/src/crypto/zinc/chacha20poly1305.o
 CC [M]  /home/bruno/WireGuard/src/crypto/zinc/blake2s/blake2s.o
 AS [M]  /home/bruno/WireGuard/src/crypto/zinc/blake2s/blake2s-x86_64.o
 CC [M]  /home/bruno/WireGuard/src/crypto/zinc/curve25519/curve25519.o
 LD [M]  /home/bruno/WireGuard/src/wireguard.o
 Building modules, stage 2.
 MODPOST 1 modules
 CC      /home/bruno/WireGuard/src/wireguard.mod.o
 LD [M]  /home/bruno/WireGuard/src/wireguard.ko
 CC      /home/bruno/WireGuard/src/tools/wg.o
 CC      /home/bruno/WireGuard/src/tools/config.o
 CC      /home/bruno/WireGuard/src/tools/show.o
 CC      /home/bruno/WireGuard/src/tools/mnlg.o
 CC      /home/bruno/WireGuard/src/tools/terminal.o
 CC      /home/bruno/WireGuard/src/tools/ipc.o
ipc.c: In function ‘userspace_get_wireguard_interfaces’:
ipc.c:189:8: warning: implicit declaration of function ‘userspace_has_wireguard_interface’; did you mean ‘userspace_get_wireguard_interfaces’? [-Wimplicit-function-declaration]
 189 |   if (!userspace_has_wireguard_interface(ent->d_name))
     |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     |        userspace_get_wireguard_interfaces
At top level:
ipc.c:143:13: warning: ‘userspace_has_wireguard_iface’ defined but not used [-Wunused-function]
 143 | static bool userspace_has_wireguard_iface(const char *iface)
     |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 CC      /home/bruno/WireGuard/src/tools/encoding.o
 CC      /home/bruno/WireGuard/src/tools/curve25519.o
 CC      /home/bruno/WireGuard/src/tools/setconf.o
 CC      /home/bruno/WireGuard/src/tools/genkey.o
 CC      /home/bruno/WireGuard/src/tools/showconf.o
 CC      /home/bruno/WireGuard/src/tools/pubkey.o
 CC      /home/bruno/WireGuard/src/tools/set.o
 LD      /home/bruno/WireGuard/src/tools/wg

/usr/bin/ld: ipc.o: in function `ipc_list_devices':
ipc.c:(.text+0xf39): undefined reference to userspace_has_wireguard_interface' /usr/bin/ld: ipc.o: in function ipc_get_device':
ipc.c:(.text+0x109a): undefined reference to userspace_has_wireguard_interface' /usr/bin/ld: ipc.o: in function ipc_set_device':
ipc.c:(.text+0x1e64): undefined reference to `userspace_has_wireguard_interface'
collect2: error: ld returned 1 exit status
make[1]: *** [<builtin>: wg] Error 1
make: *** [Makefile:59: tools] Error 2

_______________________________________________
WireGuard mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/wireguard

Hi Bruno,

Thanks for reporting this. I just sent a patch through to the mailing list that should resolve this.

Cheers,
Steven

_______________________________________________
WireGuard mailing list
[email protected]
https://lists.zx2c4.com/mailman/listinfo/wireguard