dm writecache: skip writecache_wait for pmem mode
PATCH 1/1 dm writecache: skip writecache_wait for pmem mode
From: Huaisheng Ye <[email protected]>
The array bio_in_progress[2] only have chance to be increased and decreased with ssd mode. For pmem mode, they are not involved at all. So skip writecache_wait_for_ios in writecache_flush for pmem.
--- drivers/md/dm-writecache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/md/dm-writecache.c +2 -1
@@ -726,7 +726,8 @@ static void writecache_flush(struct dm_writecache *wc) }writecache_commit_flushed (wc); -writecache_wait_for_ios (wc,WRITE ); +if (!WC_MODE_PMEM (wc)) +writecache_wait_for_ios (wc,WRITE ); wc->seq_count++;pmem_assign (sb (wc)->seq_count,cpu_to_le64 (wc->seq_count));
Signature · 1 line
1.8.3.1
Mikulas Patocka
maintainerQuoted 28 lines · Huaisheng Ye
From: Huaisheng Ye <[email protected]>
The array bio_in_progress[2] only have chance to be increased and decreased with ssd mode. For pmem mode, they are not involved at all. So skip
writecache_wait_for_iosinwritecache_flushfor pmem.Suggested-by Doris Yu <[email protected]>Signed-off-by Huaisheng Ye <[email protected]>--- drivers/md/dm-writecache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/md/dm-writecache.c +2
-1@@ -726,7 +726,8 @@ static void writecache_flush(struct dm_writecache *wc) }writecache_commit_flushed (wc); -writecache_wait_for_ios (wc,WRITE ); +if (!WC_MODE_PMEM (wc)) +writecache_wait_for_ios (wc,WRITE ); wc->seq_count++;pmem_assign (sb (wc)->seq_count,cpu_to_le64 (wc->seq_count));Signature · 1 line
1.8.3.1
I think this is not needed - wait_event in writecache_wait_for_ios exits immediatelly if the condition is true.
This code path is not so hot that we would need microoptimizations like this to avoid function calls.
Mikulas
Quoted 37 lines
-----Original Message-----
From: Mikulas Patocka <[email protected]>
Sent: Wednesday, September 4, 2019 4:49 PMQuoted 27 lines · Huaisheng Ye
From: Huaisheng Ye <[email protected]>
The array bio_in_progress[2] only have chance to be increased and decreased with ssd mode. For pmem mode, they are not involved at all. So skip
writecache_wait_for_iosinwritecache_flushfor pmem.Suggested-by Doris Yu <[email protected]>Signed-off-by Huaisheng Ye <[email protected]>--- drivers/md/dm-writecache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/md/dm-writecache.c +2
-2@@ -726,7 +726,8 @@ static void writecache_flush(struct dm_writecache *wc) }writecache_commit_flushed (wc); -writecache_wait_for_ios (wc,WRITE ); +if (!WC_MODE_PMEM (wc)) +writecache_wait_for_ios (wc,WRITE ); wc->seq_count++;pmem_assign (sb (wc)->seq_count,cpu_to_le64 (wc->seq_count)); --Quoted 1 line
1.8.3.1
I think this is not needed -
wait_eventinwritecache_wait_for_iosexits immediatelly if the condition is true.
Quoted 2 lines
This code path is not so hot that we would need microoptimizations like this to avoid function calls.
Hi Mikulas,
Thanks for your reply, I see what you mean, but I can't agree with you.
For pmem mode, this code path (writecache_flush) is much more hot than SSD mode.
Because in the code, the AUTOCOMMIT_BLOCKS_PMEM has been defined to 64, which means if more than 64 blocks have been inserted to cache device, also called uncommitted, writecache_flush would be called.
Otherwise, there is a timer callback function will be called every 1000 milliseconds.
#define AUTOCOMMIT_BLOCKS_SSD 65536
#define AUTOCOMMIT_BLOCKS_PMEM 64
#define AUTOCOMMIT_MSEC 1000
So when dm-writecache running in working mode, there are continuous WRITE operations has been mapped to writecache_map, writecache_flush will be used much more often than SSD mode.
Cheers,
Huaisheng Ye
Quoted 55 lines · On Wed, 4 Sep 2019, Huaisheng HS1 Ye wrote:
Quoted 37 lines
-----Original Message-----
From: Mikulas Patocka <[email protected]>
Sent: Wednesday, September 4, 2019 4:49 PMQuoted 27 lines · Huaisheng Ye
From: Huaisheng Ye <[email protected]>
The array bio_in_progress[2] only have chance to be increased and decreased with ssd mode. For pmem mode, they are not involved at all. So skip
writecache_wait_for_iosinwritecache_flushfor pmem.Suggested-by Doris Yu <[email protected]>Signed-off-by Huaisheng Ye <[email protected]>--- drivers/md/dm-writecache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/md/dm-writecache.c +2
-2@@ -726,7 +726,8 @@ static void writecache_flush(struct dm_writecache *wc) }writecache_commit_flushed (wc); -writecache_wait_for_ios (wc,WRITE ); +if (!WC_MODE_PMEM (wc)) +writecache_wait_for_ios (wc,WRITE ); wc->seq_count++;pmem_assign (sb (wc)->seq_count,cpu_to_le64 (wc->seq_count)); --Quoted 1 line
1.8.3.1
I think this is not needed -
wait_eventinwritecache_wait_for_iosexits immediatelly if the condition is true.Quoted 2 lines
This code path is not so hot that we would need microoptimizations like this to avoid function calls.
Hi Mikulas,
Thanks for your reply, I see what you mean, but I can't agree with you.
For pmem mode, this code path (
writecache_flush) is much more hot than SSD mode. Because in the code, theAUTOCOMMIT_BLOCKS_PMEMhas been defined to 64, which means if more than 64 blocks have been inserted to cache device, also called uncommitted,writecache_flushwould be called. Otherwise, there is a timer callback function will be called every 1000 milliseconds.#define
AUTOCOMMIT_BLOCKS_SSD65536
#defineAUTOCOMMIT_BLOCKS_PMEM64
#defineAUTOCOMMIT_MSEC1000
Quoted 6 lines
So when dm-writecache running in working mode, there are continuous WRITE operations has been mapped to
writecache_map,writecache_flushwill be used much more often than SSD mode.Cheers,
Huaisheng Ye
So, you save one instruction cache line for every 64*4096 bytes written to persistent memory.
If you insist on it, I can acknowledge it, but I think it is really an over-optimization.
Mikulas