Skip to contentSkip to conversation

eeprom: Deprecate the legacy eeprom driver

PATCH In review Jean Delvare 2 participants 4 messages Sep 2, 2019 – Sep 6, 2019 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eeprom: Deprecate the legacy eeprom driver

Time has come to get rid of the old eeprom driver. The at24 driver should be used instead. So mark the eeprom driver as deprecated and give users some time to migrate. Then we can remove the legacy eeprom driver completely.

Cc Arnd Bergmann <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/misc/eeprom/Kconfig |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/misc/eeprom/Kconfig +4 -1
@@ -45,13 +45,16 @@ config EEPROM_AT25
 	  will be called at25.
 
 config EEPROM_LEGACY
-	tristate "Old I2C EEPROM reader"
+	tristate "Old I2C EEPROM reader (DEPRECATED)"
 	depends on I2C && SYSFS
 	help
 	  If you say yes here you get read-only access to the EEPROM data
 	  available on modern memory DIMMs and Sony Vaio laptops via I2C. Such
 	  EEPROMs could theoretically be available on other devices as well.
 
+	  This driver is deprecated and will be removed soon, please use the
+	  better at24 driver instead.
+
 	  This driver can also be built as a module.  If so, the module
 	  will be called eeprom.
 
Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw
Quoted 10 lines · Jean Delvare

Time has come to get rid of the old eeprom driver. The at24 driver should be used instead. So mark the eeprom driver as deprecated and give users some time to migrate. Then we can remove the legacy eeprom driver completely.

---
 drivers/misc/eeprom/Kconfig |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

You might also want to add a big printk() message when the driver is loaded that it shouldn't be used.

thanks,

greg k-h

#2 lore raw

Hi Greg,

Quoted 6 lines · Greg Kroah-Hartman
Quoted 5 lines · Jean Delvare

Time has come to get rid of the old eeprom driver. The at24 driver should be used instead. So mark the eeprom driver as deprecated and give users some time to migrate. Then we can remove the legacy eeprom driver completely.

Quoted 8 lines
Quoted 5 lines
---
 drivers/misc/eeprom/Kconfig |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)  

You might also want to add a big printk() message when the driver is loaded that it shouldn't be used.

Good idea, although unfortunately this means expanding module_i2c_driver. Or maybe I can use printk_once() in eeprom_probe(). Or even just a dev_warn() there to really spam the kernel log in a very visible way.

Would you prefer a v2 of this patch including that change, or a separate, incremental patch?

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#3 lore raw
Quoted 15 lines · Jean Delvare

Hi Greg,

Quoted 12 lines · Greg Kroah-Hartman
Quoted 10 lines · Jean Delvare

Time has come to get rid of the old eeprom driver. The at24 driver should be used instead. So mark the eeprom driver as deprecated and give users some time to migrate. Then we can remove the legacy eeprom driver completely.

---
 drivers/misc/eeprom/Kconfig |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)  
Quoted 7 lines
Quoted 2 lines

You might also want to add a big printk() message when the driver is loaded that it shouldn't be used.

Good idea, although unfortunately this means expanding module_i2c_driver. Or maybe I can use printk_once() in eeprom_probe(). Or even just a dev_warn() there to really spam the kernel log in a very visible way.

What ever you want is fine with me.

Quoted 2 lines

Would you prefer a v2 of this patch including that change, or a separate, incremental patch?

An incremental patch as I've already applied this one.

thanks,

greg k-h