Skip to contentSkip to conversation

rt-tests: backfire: Don't include asm/uaccess.h directly

PATCH In review Sultan Alsawaf 4 participants 7 messages Sep 3, 2019 – Sep 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rt-tests: backfire: Don't include asm/uaccess.h directly

From: Sultan Alsawaf <[email protected]>

Architecture-specific uaccess.h headers can have dependencies on linux/uaccess.h (i.e., VERIFY_WRITE), so it cannot be included directly. Since linux/uaccess.h includes asm/uaccess.h, just do that instead.

This fixes compile errors with certain kernels and architectures.

---
 src/backfire/backfire.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/backfire/backfire.c +1 -1
index aaf9c4a..a8ac9f5 100644
@@ -30,8 +30,8 @@
 #include <linux/miscdevice.h>
 #include <linux/proc_fs.h>
 #include <linux/spinlock.h>
+#include <linux/uaccess.h>
 
-#include <asm/uaccess.h>
 #include <asm/system.h>
 
 #define BACKFIRE_MINOR MISC_DYNAMIC_MINOR
Signature · 1 line
2.23.0
#1 lore raw
Quoted 31 lines · Sultan Alsawaf

From: Sultan Alsawaf <[email protected]>

Architecture-specific uaccess.h headers can have dependencies on linux/uaccess.h (i.e., VERIFY_WRITE), so it cannot be included directly. Since linux/uaccess.h includes asm/uaccess.h, just do that instead.

This fixes compile errors with certain kernels and architectures.

---
 src/backfire/backfire.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/backfire/backfire.c +1 -1
index aaf9c4a..a8ac9f5 100644
@@ -30,8 +30,8 @@
 #include <linux/miscdevice.h>
 #include <linux/proc_fs.h>
 #include <linux/spinlock.h>
+#include <linux/uaccess.h>
 
-#include <asm/uaccess.h>
 #include <asm/system.h>
 
 #define BACKFIRE_MINOR MISC_DYNAMIC_MINOR
Signature · 1 line
2.23.0

But please in the future
1. Don't cc lkml on this
2. Include the maintainers in your patch

Thanks

#2 lore raw
Quoted 4 lines · John Kacur

But please in the future
1. Don't cc lkml on this
2. Include the maintainers in your patch

Hi,

Thanks for the sign-off. I was following the instructions listed here:
https://wiki.linuxfoundation.org/realtime/communication/send_rt_patches

I couldn't find any documentation of how to send patches for rt-tests. Is there a different set of patch submission instructions on a wiki somewhere I missed?

Thanks,
Sultan

#3 lore raw
In reply to Sultan Alsawaf

Hi,

Quoted 10 lines · Sultan Alsawaf
Quoted 4 lines · John Kacur

But please in the future
1. Don't cc lkml on this
2. Include the maintainers in your patch

Hi,

Thanks for the sign-off. I was following the instructions listed here:
https://wiki.linuxfoundation.org/realtime/communication/send_rt_patches

I guess, that's for rt kernel patches.

Quoted 4 lines

I couldn't find any documentation of how to send patches for rt-tests. Is there a different set of patch submission instructions on a wiki somewhere I missed?

For rt-tests see the top level MAINTAINERS file on how to send patches.

Quoted 3 lines

Thanks,
Sultan

Thanks,
Kurt

#6 lore raw
In reply to Sebastian Andrzej Siewior
Quoted 11 lines · Sebastian Andrzej Siewior
Quoted 1 line · John Kacur

Hmmm. I remember this thing came up years ago in the Debian BTS and then that backfire module got removed from the Debian package because there was no need for it.
Just to clarify: is there any need to keep this module or do I mix up things?

Sebastian

The cost of carrying the code should anyone wish to revive this is very small, and it wouldn't take much effort to get it going again.

It could go either way, I'm fine with carrying it for now.

John

#4 lore raw
In reply to Sultan Alsawaf
Quoted 10 lines · Sultan Alsawaf
Quoted 4 lines · John Kacur

But please in the future
1. Don't cc lkml on this
2. Include the maintainers in your patch

Hi,

Thanks for the sign-off. I was following the instructions listed here:
https://wiki.linuxfoundation.org/realtime/communication/send_rt_patches

Those are the instructions for rt kernel code.
rt-tests is a users space program to test the performance of the rt kernel.

Always just check if there is a MAINTAINERS file (there is) when you clone the git repo.

Thanks

John

Quoted 7 lines

I couldn't find any documentation of how to send patches for rt-tests. Is there a different set of patch submission instructions on a wiki somewhere I missed?

Thanks,
Sultan