usb: cdns3: Fix use after free in probe error handling

PATCH New Dan Carpenter 1 participant 1 message Sep 4, 2019

Subsystems (3)

USB Kernel janitors Cadence USB3 DRD IP driver

lore

Share & tools

lore

Dan Carpenter

author

2019-09-04 10:01 UTC #0 lore raw

PATCH 1/1 usb: cdns3: Fix use after free in probe error handling

We can't use "wrap" after it has been freed.

Fixes 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/usb/cdns3/cdns3-pci-wrap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/usb/cdns3/cdns3-pci-wrap.c +2 -1

index c41ddb61b857..b0a29efe7d31 100644
@@ -159,8 +159,9 @@ static int cdns3_pci_probe(struct pci_dev *pdev,
 		wrap->plat_dev = platform_device_register_full(&plat_info);
 		if (IS_ERR(wrap->plat_dev)) {
 			pci_disable_device(pdev);
+			err = PTR_ERR(wrap->plat_dev);
 			kfree(wrap);
-			return PTR_ERR(wrap->plat_dev);
+			return err;
 		}
 	}

Signature · 1 line

2.20.1