Skip to contentSkip to conversation

qcom: Add firmware files for Adreno A200

PATCH In review Fabio Estevam 5 participants 6 messages Sep 4, 2019 – Sep 6, 2019 Arm Qualcomm mailing list

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qcom: Add firmware files for Adreno A200

Add firmware files for Adreno A200.

These firmware files are needed for running the adreno kernel driver on i.MX51 and i.MX53 SoCs.

---
 WHENCE             |   2 ++
 qcom/yamato_pfp.fw | Bin 0 -> 1156 bytes
 qcom/yamato_pm4.fw | Bin 0 -> 9220 bytes
 3 files changed, 2 insertions(+)
 create mode 100644 qcom/yamato_pfp.fw
 create mode 100644 qcom/yamato_pm4.fw
WHENCE +2 -0
index a8ec628..5e46d33 100644
@@ -4418,6 +4418,8 @@ File: qcom/a530_zap.b00
 File: qcom/a530_zap.b01
 File: qcom/a530_zap.b02
 File: qcom/a530_zap.mdt
+File: qcom/yamato_pfp.fw
+File: qcom/yamato_pm4.fw
 
 Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
 
qcom/yamato_pfp.fw new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..61a576eb997ce2ee0d32b135adc5d8c789d8e118
GIT binary patch
qcom/yamato_pm4.fw new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..b45ea20ba5773ef6da25e21abd29914ea9162c07
GIT binary patch
Signature · 1 line
2.17.1
#1 lore raw

hi Fabio,

Quoted 20 lines · Fabio Estevam

Add firmware files for Adreno A200.

These firmware files are needed for running the adreno kernel driver on i.MX51 and i.MX53 SoCs.

---
 WHENCE             |   2 ++
 qcom/yamato_pfp.fw | Bin 0 -> 1156 bytes
 qcom/yamato_pm4.fw | Bin 0 -> 9220 bytes
 3 files changed, 2 insertions(+)
 create mode 100644 qcom/yamato_pfp.fw
 create mode 100644 qcom/yamato_pm4.fw
WHENCE +0 -0
index a8ec628..5e46d33 100644

WHENCE File: qcom/a530_zap.b00 · line 4422

Quoted 5 lines
WHENCE +2 -0
@@ -4418,6 +4418,8 @@ File: qcom/a530_zap.b00
 File: qcom/a530_zap.b01
 File: qcom/a530_zap.b02
 File: qcom/a530_zap.mdt
+File: qcom/yamato_pfp.fw
+File: qcom/yamato_pm4.fw

Where did you get these files from in the first place? On which devices do you expect these firmware files to work? We were recently discussing how to structure /lib/firmware/qcom more carefully. And the general consensus that we reached with Rob C. and Bjorn is that if a firmware is expected to work on a specific device (maybe it is signed) it should be placed in /lib/firmware/qcom/<device> and if it's unsigned and can be used on several devices based on the same SoC (dev boards, ..) then it should be /lib/firmware/qcom/<SOC>.

WHENCE File: qcom/a530_zap.b00 · line 4424

Quoted 2 lines
WHENCE +0 -0
 Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details

Are they really distributed under these license terms? That's a specific license that we came up with with Qualcomm a couple of years ago based on their Dragonboard offers.

Quoted 86 lines
qcom/yamato_pfp.fw new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..61a576eb997ce2ee0d32b135adc5d8c789d8e118
GIT binary patch
qcom/yamato_pm4.fw new file binary +0 -1
new file mode 100644
index 0000000000000000000000000000000000000000..b45ea20ba5773ef6da25e21abd29914ea9162c07
GIT binary patch
 
--

2.17.1

#2 lore raw
Quoted 30 lines · Nicolas Dechesne

hi Fabio,

Quoted 20 lines · Fabio Estevam

Add firmware files for Adreno A200.

These firmware files are needed for running the adreno kernel driver on i.MX51 and i.MX53 SoCs.

---
 WHENCE             |   2 ++
 qcom/yamato_pfp.fw | Bin 0 -> 1156 bytes
 qcom/yamato_pm4.fw | Bin 0 -> 9220 bytes
 3 files changed, 2 insertions(+)
 create mode 100644 qcom/yamato_pfp.fw
 create mode 100644 qcom/yamato_pm4.fw
WHENCE +0 -0
index a8ec628..5e46d33 100644

WHENCE File: qcom/a530_zap.b00 · line 4422

Quoted 5 lines
WHENCE +2 -0
@@ -4418,6 +4418,8 @@ File: qcom/a530_zap.b00
 File: qcom/a530_zap.b01
 File: qcom/a530_zap.b02
 File: qcom/a530_zap.mdt
+File: qcom/yamato_pfp.fw
+File: qcom/yamato_pm4.fw
Quoted 8 lines

Where did you get these files from in the first place? On which devices do you expect these firmware files to work? We were recently discussing how to structure /lib/firmware/qcom more carefully. And the general consensus that we reached with Rob C. and Bjorn is that if a firmware is expected to work on a specific device (maybe it is signed) it should be placed in /lib/firmware/qcom/<device> and if it's unsigned and can be used on several devices based on the same SoC (dev boards, ..) then it should be /lib/firmware/qcom/<SOC>.

fwiw, the pfp/pm4 fw (later replaced by sqe) are not signed, so /lib/firmware/qcom/ location is fine for these

BR,
-R

#3 lore raw
In reply to Nicolas Dechesne
Quoted 40 lines · Nicolas Dechesne

hi Fabio,

Quoted 20 lines · Fabio Estevam

Add firmware files for Adreno A200.

These firmware files are needed for running the adreno kernel driver on i.MX51 and i.MX53 SoCs.

---
 WHENCE             |   2 ++
 qcom/yamato_pfp.fw | Bin 0 -> 1156 bytes
 qcom/yamato_pm4.fw | Bin 0 -> 9220 bytes
 3 files changed, 2 insertions(+)
 create mode 100644 qcom/yamato_pfp.fw
 create mode 100644 qcom/yamato_pm4.fw
WHENCE +0 -0
index a8ec628..5e46d33 100644

WHENCE File: qcom/a530_zap.b00 · line 4422

Quoted 5 lines
WHENCE +2 -0
@@ -4418,6 +4418,8 @@ File: qcom/a530_zap.b00
 File: qcom/a530_zap.b01
 File: qcom/a530_zap.b02
 File: qcom/a530_zap.mdt
+File: qcom/yamato_pfp.fw
+File: qcom/yamato_pm4.fw

Where did you get these files from in the first place? On which devices do you expect these firmware files to work? We were recently discussing how to structure /lib/firmware/qcom more carefully. And the general consensus that we reached with Rob C. and Bjorn is that if a firmware is expected to work on a specific device (maybe it is signed) it should be placed in /lib/firmware/qcom/<device> and if it's unsigned and can be used on several devices based on the same SoC (dev boards, ..) then it should be /lib/firmware/qcom/<SOC>.

Quoted 1 line
Quoted 5 lines
Quoted 1 line

Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details

Are they really distributed under these license terms? That's a specific license that we came up with with Qualcomm a couple of years ago based on their Dragonboard offers.

So everyone understands, I'm not pulling this for now. If there are questions on provenance of the firmware and the license it's under, that's a big red flag for me. Ideally we'd see someone from qcom add a Signed-off-by or otherwise acknowledge these are meant to be redistributable.

josh

Quoted 85 lines
Quoted 85 lines
qcom/yamato_pfp.fw new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..61a576eb997ce2ee0d32b135adc5d8c789d8e118
GIT binary patch
qcom/yamato_pm4.fw new file binary +0 -1
new file mode 100644
index 0000000000000000000000000000000000000000..b45ea20ba5773ef6da25e21abd29914ea9162c07
GIT binary patch
 
--

2.17.1

#4 lore raw

Hi All,

I'll start by saying that I'm no expert on this subject! My understanding with this Adreno 2xx firmware though is that these two firmware files are generally equivalent to what was distributed previously in an include file in the following two files for the NXP i.MX51 and i.MX53 which utilize the Adreno 200:

https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/mxc/amd-gpu/common/pm4_microcode.inl?h=imx_2.6.35_1.1.0_caf&id=61ade304d0eddc3f44fb2ee0b2b7ccf3ffcf85d5
https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/mxc/amd-gpu/common/pfp_microcode_nrt.inl?h=imx_2.6.35_1.1.0_caf&id=61ade304d0eddc3f44fb2ee0b2b7ccf3ffcf85d5

I'm not suggesting we don't get someone from qcom to provide a Signed-off-by. I'm only pointing out that it looks like this firmware was previously made available and that it did have a license that perhaps we can continue to use for this firmware that's also for the Adreno 200?

Regards,

Chris

Quoted 142 lines · Josh Boyer
Quoted 40 lines · Nicolas Dechesne

hi Fabio,

Quoted 20 lines · Fabio Estevam

Add firmware files for Adreno A200.

These firmware files are needed for running the adreno kernel driver on i.MX51 and i.MX53 SoCs.

---
 WHENCE             |   2 ++
 qcom/yamato_pfp.fw | Bin 0 -> 1156 bytes
 qcom/yamato_pm4.fw | Bin 0 -> 9220 bytes
 3 files changed, 2 insertions(+)
 create mode 100644 qcom/yamato_pfp.fw
 create mode 100644 qcom/yamato_pm4.fw
WHENCE +0 -0
index a8ec628..5e46d33 100644

WHENCE File: qcom/a530_zap.b00 · line 4422

Quoted 5 lines
WHENCE +2 -0
@@ -4418,6 +4418,8 @@ File: qcom/a530_zap.b00
 File: qcom/a530_zap.b01
 File: qcom/a530_zap.b02
 File: qcom/a530_zap.mdt
+File: qcom/yamato_pfp.fw
+File: qcom/yamato_pm4.fw

Where did you get these files from in the first place? On which devices do you expect these firmware files to work? We were recently discussing how to structure /lib/firmware/qcom more carefully. And the general consensus that we reached with Rob C. and Bjorn is that if a firmware is expected to work on a specific device (maybe it is signed) it should be placed in /lib/firmware/qcom/<device> and if it's unsigned and can be used on several devices based on the same SoC (dev boards, ..) then it should be /lib/firmware/qcom/<SOC>.

Quoted 1 line
Quoted 5 lines
Quoted 1 line

Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details

Are they really distributed under these license terms? That's a specific license that we came up with with Qualcomm a couple of years ago based on their Dragonboard offers.

So everyone understands, I'm not pulling this for now. If there are questions on provenance of the firmware and the license it's under, that's a big red flag for me. Ideally we'd see someone from qcom add a Signed-off-by or otherwise acknowledge these are meant to be redistributable.

josh

Quoted 85 lines
Quoted 85 lines
qcom/yamato_pfp.fw new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..61a576eb997ce2ee0d32b135adc5d8c789d8e118
GIT binary patch
qcom/yamato_pm4.fw new file binary +0 -1
new file mode 100644
index 0000000000000000000000000000000000000000..b45ea20ba5773ef6da25e21abd29914ea9162c07
GIT binary patch
 
--

2.17.1

#5 lore raw
Quoted 9 lines · Chris Healy

Hi All,

I'll start by saying that I'm no expert on this subject! My understanding with this Adreno 2xx firmware though is that these two firmware files are generally equivalent to what was distributed previously in an include file in the following two files for the NXP i.MX51 and i.MX53 which utilize the Adreno 200:

Quoted 8 lines

https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/mxc/amd-gpu/common/pm4_microcode.inl?h=imx_2.6.35_1.1.0_caf&id=61ade304d0eddc3f44fb2ee0b2b7ccf3ffcf85d5
https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/mxc/amd-gpu/common/pfp_microcode_nrt.inl?h=imx_2.6.35_1.1.0_caf&id=61ade304d0eddc3f44fb2ee0b2b7ccf3ffcf85d5

I'm not suggesting we don't get someone from qcom to provide a Signed-off-by. I'm only pointing out that it looks like this firmware was previously made available and that it did have a license that perhaps we can continue to use for this firmware that's also for the Adreno 200?

I was not saying the firmware can't be distributed, I was just pointing out that most likely using LICENSE.qcom was wrong. I was involved when we created LICENSE.qcom and submitted it first, and I know that the i.MX firmware can't be distributed with these license terms. If the firmware have been released previously , especially on codeaurora.org then they are definitely good candidates for linux-firmware, but the license and WHENCE need to be adjusted accordingly.

Quoted 148 lines

Regards,

Chris

Quoted 142 lines · Josh Boyer
Quoted 40 lines · Nicolas Dechesne

hi Fabio,

Quoted 20 lines · Fabio Estevam

Add firmware files for Adreno A200.

These firmware files are needed for running the adreno kernel driver on i.MX51 and i.MX53 SoCs.

---
 WHENCE             |   2 ++
 qcom/yamato_pfp.fw | Bin 0 -> 1156 bytes
 qcom/yamato_pm4.fw | Bin 0 -> 9220 bytes
 3 files changed, 2 insertions(+)
 create mode 100644 qcom/yamato_pfp.fw
 create mode 100644 qcom/yamato_pm4.fw
WHENCE +0 -0
index a8ec628..5e46d33 100644

WHENCE File: qcom/a530_zap.b00 · line 4422

Quoted 5 lines
WHENCE +2 -0
@@ -4418,6 +4418,8 @@ File: qcom/a530_zap.b00
 File: qcom/a530_zap.b01
 File: qcom/a530_zap.b02
 File: qcom/a530_zap.mdt
+File: qcom/yamato_pfp.fw
+File: qcom/yamato_pm4.fw

Where did you get these files from in the first place? On which devices do you expect these firmware files to work? We were recently discussing how to structure /lib/firmware/qcom more carefully. And the general consensus that we reached with Rob C. and Bjorn is that if a firmware is expected to work on a specific device (maybe it is signed) it should be placed in /lib/firmware/qcom/<device> and if it's unsigned and can be used on several devices based on the same SoC (dev boards, ..) then it should be /lib/firmware/qcom/<SOC>.

Quoted 1 line
Quoted 5 lines
Quoted 1 line

Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details

Are they really distributed under these license terms? That's a specific license that we came up with with Qualcomm a couple of years ago based on their Dragonboard offers.

So everyone understands, I'm not pulling this for now. If there are questions on provenance of the firmware and the license it's under, that's a big red flag for me. Ideally we'd see someone from qcom add a Signed-off-by or otherwise acknowledge these are meant to be redistributable.

josh

Quoted 85 lines
Quoted 85 lines
qcom/yamato_pfp.fw new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..61a576eb997ce2ee0d32b135adc5d8c789d8e118
GIT binary patch
qcom/yamato_pm4.fw new file binary +0 -1
new file mode 100644
index 0000000000000000000000000000000000000000..b45ea20ba5773ef6da25e21abd29914ea9162c07
GIT binary patch
 
--

2.17.1