Skip to contentSkip to conversation

oeqa/selftest/cases/glibc.py: Don't install python3 and pexpect

PATCH In review Nathan Rossi 2 participants 5 messages Sep 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 oeqa/selftest/cases/glibc.py: Don't install python3 and pexpect

When running the system emulation test case, do not include python3 or pexpect in the image. The test cases that use these also need gdb (with python configured).

---
 meta/lib/oeqa/selftest/cases/glibc.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/lib/oeqa/selftest/cases/glibc.py +2 -2
index f836367094..6a34da39d9 100644
@@ -60,8 +60,8 @@ class GlibcSelfTestSystemEmulated(GlibcSelfTest):
         "libstdc++",
         "libatomic",
         "libgomp",
-        "python3",
-        "python3-pexpect",
+        # "python3",
+        # "python3-pexpect",
         "nfs-utils",
         ]
 

---
2.23.0.rc1

#1 lore raw

PATCH 2/4 oeqa/selftest: For toolchain tests do not fail if a test failed

Do not fail the running selftest test case if the test suite has a failed test case. Currently toolchain tests suites (binutils, gcc, glibc) fail but this does not indicate failure to execute the tests.

Also remove the logging of each test that failed.

---
 meta/lib/oeqa/selftest/cases/binutils.py | 6 ------
 meta/lib/oeqa/selftest/cases/gcc.py      | 6 ------
 meta/lib/oeqa/selftest/cases/glibc.py    | 5 -----
 3 files changed, 17 deletions(-)
meta/lib/oeqa/selftest/cases/binutils.py +0 -6
index 4edee09390..7f887959e4 100644
@@ -52,13 +52,7 @@ class BinutilsCrossSelfTest(OESelftestTestCase):
         if not os.path.exists(sumspath):
             sumspath = os.path.join(builddir, suite, "testsuite", "{0}.sum".format(suite))
 
-        failed = 0
         with open(sumspath, "r") as f:
             for test, result in parse_values(f):
                 self.tc.extraresults["ptestresult.{}.{}".format(ptestsuite, test)] = {"status" : result}
-                if result == "FAIL":
-                    self.logger.info("failed: '{}'".format(test))
-                    failed += 1
-
-        self.assertEqual(failed, 0)
 
meta/lib/oeqa/selftest/cases/gcc.py +0 -6
index 0ad6e21d6b..4f7ffdcb2a 100644
@@ -71,7 +71,6 @@ class GccSelfTest(OESelftestTestCase):
         bb_vars = get_bb_vars(["B", "TARGET_SYS"], recipe)
         builddir, target_sys = bb_vars["B"], bb_vars["TARGET_SYS"]
 
-        failed = 0
         for suite in suites:
             sumspath = os.path.join(builddir, "gcc", "testsuite", suite, "{0}.sum".format(suite))
             if not os.path.exists(sumspath): # check in target dirs
@@ -84,11 +83,6 @@ class GccSelfTest(OESelftestTestCase):
             with open(sumspath, "r") as f:
                 for test, result in parse_values(f):
                     self.tc.extraresults["ptestresult.{}.{}".format(ptestsuite, test)] = {"status" : result}
-                    if result == "FAIL":
-                        self.logger.info("failed: '{}'".format(test))
-                        failed += 1
-
-        self.assertEqual(failed, 0)
 
 class GccSelfTestSystemEmulated(GccSelfTest):
     default_installed_packages = ["libgcc", "libstdc++", "libatomic", "libgomp"]
meta/lib/oeqa/selftest/cases/glibc.py +0 -5
index 6a34da39d9..7992ea6bf2 100644
@@ -43,15 +43,10 @@ class GlibcSelfTest(OESelftestTestCase):
 
         builddir = get_bb_var("B", "glibc-testsuite")
 
-        failed = 0
         self.tc.extraresults["ptestresult.sections"]["glibc"] = {}
         with open(os.path.join(builddir, "tests.sum"), "r") as f:
             for test, result in parse_values(f):
                 self.tc.extraresults["ptestresult.glibc.{}".format(test)] = {"status" : result}
-                if result == "FAIL":
-                    self.logger.info("failed: '{}'".format(test))
-                    failed += 1
-        self.assertEqual(failed, 0)
 
 class GlibcSelfTestSystemEmulated(GlibcSelfTest):
     default_installed_packages = [

---
2.23.0.rc1

#2 lore raw

PATCH 3/4 maintainers.inc: Add entries for toolchain related recipes

In reply to Nathan Rossi

Add entries for the added toolchain related recipes including binutils-cross-testsuite and glibc-testsuite setting the maintainer as Khem to match existing definitions. Also and entry for dejagnu setting Nathan Rossi as the maintainer.

---
 meta/conf/distro/include/maintainers.inc | 3 +++
 1 file changed, 3 insertions(+)
meta/conf/distro/include/maintainers.inc +3 -0
index 0757230b1a..aaae55ac86 100644
@@ -66,6 +66,7 @@ RECIPE_MAINTAINER_pn-bind = "Armin Kuster <[email protected]>"
 RECIPE_MAINTAINER_pn-binutils = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-binutils-cross-${TARGET_ARCH} = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "Khem Raj <[email protected]>"
+RECIPE_MAINTAINER_pn-binutils-cross-testsuite = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-binutils-crosssdk-${SDK_SYS} = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-bison = "Chen Qi <[email protected]>"
 RECIPE_MAINTAINER_pn-bjam-native = "Alexander Kanavin <[email protected]>"
@@ -142,6 +143,7 @@ RECIPE_MAINTAINER_pn-dbus-glib = "Chen Qi <[email protected]>"
 RECIPE_MAINTAINER_pn-dbus-test = "Chen Qi <[email protected]>"
 RECIPE_MAINTAINER_pn-dbus-wait = "Chen Qi <[email protected]>"
 RECIPE_MAINTAINER_pn-debianutils = "Yi Zhao <[email protected]>"
+RECIPE_MAINTAINER_pn-dejagnu = "Nathan Rossi <[email protected]>"
 RECIPE_MAINTAINER_pn-depmodwrapper-cross = "Mark Hatle <[email protected]>"
 RECIPE_MAINTAINER_pn-desktop-file-utils = "Alexander Kanavin <[email protected]>"
 RECIPE_MAINTAINER_pn-dhcp = "Hongxu Jia <[email protected]>"
@@ -219,6 +221,7 @@ RECIPE_MAINTAINER_pn-glibc-initial = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-glibc-locale = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-glibc-mtrace = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-glibc-scripts = "Khem Raj <[email protected]>"
+RECIPE_MAINTAINER_pn-glibc-testsuite = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-glide = "Otavio Salvador <[email protected]>"
 RECIPE_MAINTAINER_pn-gmp = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-gnome-desktop-testing = "Ross Burton <[email protected]>"

---
2.23.0.rc1

#3 lore raw

PATCH 4/4 oeqa/selftest: Toolchain tests suffix "-user" for qemu usermode results

In reply to Nathan Rossi

Suffix the ptestresults suite with "-user" for tests that are executing against usermode qemu.

---
 meta/lib/oeqa/selftest/cases/gcc.py   | 1 +
 meta/lib/oeqa/selftest/cases/glibc.py | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
meta/lib/oeqa/selftest/cases/gcc.py +1 -0
index 4f7ffdcb2a..ef85df5e36 100644
@@ -79,6 +79,7 @@ class GccSelfTest(OESelftestTestCase):
                 sumspath = os.path.join(builddir, target_sys, suite, "testsuite", "{0}.sum".format(suite.split("-")[0]))
 
             ptestsuite = "gcc-{}".format(suite) if suite != "gcc" else suite
+            ptestsuite = ptestsuite + "-user" if ssh is None else ptestsuite
             self.tc.extraresults["ptestresult.sections"][ptestsuite] = {}
             with open(sumspath, "r") as f:
                 for test, result in parse_values(f):
meta/lib/oeqa/selftest/cases/glibc.py +3 -2
index 7992ea6bf2..4d0c13131b 100644
@@ -43,10 +43,11 @@ class GlibcSelfTest(OESelftestTestCase):
 
         builddir = get_bb_var("B", "glibc-testsuite")
 
-        self.tc.extraresults["ptestresult.sections"]["glibc"] = {}
+        ptestsuite = "glibc-user" if ssh is None else "glibc"
+        self.tc.extraresults["ptestresult.sections"][ptestsuite] = {}
         with open(os.path.join(builddir, "tests.sum"), "r") as f:
             for test, result in parse_values(f):
-                self.tc.extraresults["ptestresult.glibc.{}".format(test)] = {"status" : result}
+                self.tc.extraresults["ptestresult.{}.{}".format(ptestsuite, test)] = {"status" : result}
 
 class GlibcSelfTestSystemEmulated(GlibcSelfTest):
     default_installed_packages = [

---
2.23.0.rc1

#4 lore raw

✗ patchtest: failure for "oeqa/selftest/cases/glibc.py: ..." and 3 more

In reply to Nathan Rossi

== Series Details ==

Series: "oeqa/selftest/cases/glibc.py: ..." and 3 more
Revision: 1
URL : https://patchwork.openembedded.org/series/19688/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at aa36510ebe)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe