python3native, pythonnative: export PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
PATCH v2 1/1 python3native, pythonnative: export PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
packages can use
find_package(PythonInterp REQUIRED)find_package(PythonLibs REQUIRED)
while we control PYTHON pointing to native py3 the libs and include directories will then point to build host version, which can result in unexpected combination and if we are lucky we get errors if its quite different e.g. py2 libs/includes and py3 executable
This variable can be then used to export PYTHON_LIBRARY and PYTHON_INCLUDE_DIR so that above find_packages can work correctly
see [1] for how it happens in cmake
LLDB uses it see [2]
[1] https://github.com/Kitware/CMake/blob/master/Modules/FindPythonLibs.cmake
[2] https://github.com/llvm/llvm-project/blob/master/lldb/cmake/modules/LLDBConfig.cmake#L226
---
v2: Use PYTHON_DIR variable
meta/classes/python3native.bbclass | 8 ++++++++ meta/classes/pythonnative.bbclass | 8 ++++++++ 2 files changed, 16 insertions(+)
meta/classes/python3native.bbclass +8 -0
@@ -9,6 +9,14 @@ DEPENDS_append = " python3-native " export STAGING_INCDIR export STAGING_LIBDIR +# Packages can use +# find_package(PythonInterp REQUIRED) +# find_package(PythonLibs REQUIRED) +# which ends up using libs/includes from build host +# Therefore pre-empt that effort +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_DIR}" +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}" + export _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata" # suppress host user's site-packages dirs.
meta/classes/pythonnative.bbclass +8 -0
@@ -12,6 +12,14 @@ DEPENDS_append = " python-native " export STAGING_INCDIR export STAGING_LIBDIR +# Packages can use +# find_package(PythonInterp REQUIRED) +# find_package(PythonLibs REQUIRED) +# which ends up using libs/includes from build host +# Therefore pre-empt that effort +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_DIR}" +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}" + # suppress host user's site-packages dirs. export PYTHONNOUSERSITE = "1"
Signature · 1 line
2.23.0
Thanks, this looks good now.
Alex
Quoted 79 lines · Khem Raj
packages can use
find_package(PythonInterp REQUIRED)find_package(PythonLibs REQUIRED)while we control PYTHON pointing to native py3 the libs and include directories will then point to build host version, which can result in unexpected combination and if we are lucky we get errors if its quite different e.g. py2 libs/includes and py3 executable
This variable can be then used to export
PYTHON_LIBRARYandPYTHON_INCLUDE_DIRso that abovefind_packagescan work correctlysee [1] for how it happens in cmake
LLDB uses it see [2]
[1]
https://github.com/Kitware/CMake/blob/master/Modules/FindPythonLibs.cmake
[2]
https://github.com/llvm/llvm-project/blob/master/lldb/cmake/modules/LLDBConfig.cmake#L226Signed-off-by Khem Raj <[email protected]>---
v2: UsePYTHON_DIRvariablemeta/classes/python3native.bbclass | 8 ++++++++ meta/classes/pythonnative.bbclass | 8 ++++++++ 2 files changed, 16 insertions(+)meta/classes/python3native.bbclass +8
-0@@ -9,6 +9,14 @@ DEPENDS_append = " python3-native " export STAGING_INCDIR export STAGING_LIBDIR +# Packages can use +# find_package(PythonInterp REQUIRED) +# find_package(PythonLibs REQUIRED) +# which ends up using libs/includes from build host +# Therefore pre-empt that effort +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_DIR}" +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}" + export _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata" # suppress host user's site-packages dirs.meta/classes/pythonnative.bbclass +8
-1@@ -12,6 +12,14 @@ DEPENDS_append = " python-native " export STAGING_INCDIR export STAGING_LIBDIR +# Packages can use +# find_package(PythonInterp REQUIRED) +# find_package(PythonLibs REQUIRED) +# which ends up using libs/includes from build host +# Therefore pre-empt that effort +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_DIR}" +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}" + # suppress host user's site-packages dirs. export PYTHONNOUSERSITE = "1" --2.23.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
wait for v3 on this I am doing a build which is still not done yet.
Quoted 81 lines · Alexander Kanavin
Thanks, this looks good now.
Alex
Quoted 75 lines · Khem Raj
packages can use
find_package(PythonInterp REQUIRED)find_package(PythonLibs REQUIRED)while we control PYTHON pointing to native py3 the libs and include directories will then point to build host version, which can result in unexpected combination and if we are lucky we get errors if its quite different e.g. py2 libs/includes and py3 executable
This variable can be then used to export
PYTHON_LIBRARYandPYTHON_INCLUDE_DIRso that abovefind_packagescan work correctlysee [1] for how it happens in cmake
LLDB uses it see [2]
[1] https://github.com/Kitware/CMake/blob/master/Modules/FindPythonLibs.cmake
[2] https://github.com/llvm/llvm-project/blob/master/lldb/cmake/modules/LLDBConfig.cmake#L226Signed-off-by Khem Raj <[email protected]>---
v2: UsePYTHON_DIRvariablemeta/classes/python3native.bbclass | 8 ++++++++ meta/classes/pythonnative.bbclass | 8 ++++++++ 2 files changed, 16 insertions(+)meta/classes/python3native.bbclass +8
-0@@ -9,6 +9,14 @@ DEPENDS_append = " python3-native " export STAGING_INCDIR export STAGING_LIBDIR +# Packages can use +# find_package(PythonInterp REQUIRED) +# find_package(PythonLibs REQUIRED) +# which ends up using libs/includes from build host +# Therefore pre-empt that effort +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_DIR}" +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}" + export _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata" # suppress host user's site-packages dirs.meta/classes/pythonnative.bbclass +8
-1@@ -12,6 +12,14 @@ DEPENDS_append = " python-native " export STAGING_INCDIR export STAGING_LIBDIR +# Packages can use +# find_package(PythonInterp REQUIRED) +# find_package(PythonLibs REQUIRED) +# which ends up using libs/includes from build host +# Therefore pre-empt that effort +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_DIR}" +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}" + # suppress host user's site-packages dirs. export PYTHONNOUSERSITE = "1" --2.23.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core