Skip to contentSkip to conversation

drm/amd/display: Move static keyword to the front of declaration

PATCH In review Krzysztof Wilczynski 2 participants 2 messages Sep 5, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: Move static keyword to the front of declaration

Move the static keyword to the front of declaration of DC_BUILD_ID, and resolve the following compiler warning that can be seen when building with warnings enabled (W=1):

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]

---
Related: https://lore.kernel.org/r/[email protected]

 drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc.c +1 -1
index 87ca5a290d12..a5a89bc0e1d1 100644
@@ -72,7 +72,7 @@
 #define DC_LOGGER \
 	dc->ctx->logger
 
-const static char DC_BUILD_ID[] = "production-build";
+static const char DC_BUILD_ID[] = "production-build";
 
 /**
  * DOC: Overview
Signature · 1 line
2.22.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Krzysztof Wilczynski

Move the static keyword to the front of declaration of DC_BUILD_ID, and resolve the following compiler warning that can be seen when building with warnings enabled (W=1):

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]

Harry

Quoted 12 lines

---
Related: https://lore.kernel.org/r/[email protected]

 drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc.c +0 -0
index 87ca5a290d12..a5a89bc0e1d1 100644

drivers/gpu/drm/amd/display/dc/core/dc.c line 78

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/core/dc.c +1 -1
@@ -72,7 +72,7 @@
 #define DC_LOGGER \
 	dc->ctx->logger
 
-const static char DC_BUILD_ID[] = "production-build";
+static const char DC_BUILD_ID[] = "production-build";
 
 /**
  * DOC: Overview

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel