Skip to contentSkip to conversation

remmina: Add recipe for the remmina remote desktop client

PATCH New Khem Raj 2 participants 6 messages Sep 6, 2019 – Sep 7, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v2 1/3 remmina: Add recipe for the remmina remote desktop client

From: "[email protected]" <[email protected]>

Remmina has become one of the most widely used RDP clients, it uses freeRDP 2.0 as a backend and also supports multiple network protocols like RSP, VNC, SPICE, NX, and SSH.

---
v2: Rebased

 .../recipes-support/remmina/remmina_1.3.6.bb  | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 meta-oe/recipes-support/remmina/remmina_1.3.6.bb
meta-oe/recipes-support/remmina/remmina_1.3.6.bb new file +28 -0
new file mode 100644
index 0000000000..a14a2592cd
@@ -0,0 +1,28 @@
+DESCRIPTION = "A feature rich Remote Desktop Application written in GTK+"
+HOMEPAGE = "https://remmina.org"
+SECTION = "Support"
+LICENSE = "GPLv2 & openssl"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
+DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui libsodium libssh vte json-glib libsoup-2.4 libvncserver spice spice-protocol libsecret"
+
+SRC_URI = "https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2 \
+"
+SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
+SRC_URI[sha256sum] = "fbed745438bb0c21467b60cbd67c8148a9289b5ebc7482d06db443bea556af1a"
+
+S = "${WORKDIR}/Remmina-v${PV}"
+
+inherit cmake
+
+EXTRA_OECMAKE += "-DWITH_APPINDICATOR=OFF -DWITH_GETTEXT=OFF -DWITH_TRANSLATIONS=OFF"
+
+do_install_append(){
+    # We dont need the extra stuff form other desktop environments
+    rm -rf ${D}/${datadir}/xsessions
+    rm -rf ${D}/${datadir}/metainfo
+    rm -rf ${D}/${datadir}/gnome-session
+}
+
+RDEPENDS_${PN} = "bash"
+
+FILES_${PN}_append = " ${datadir}/icons/hicolor/*"
Signature · 1 line
2.23.0
author
#1 lore raw

PATCH 2/3 remmina: Link with libexecinfo explicitly on musl

Cc Alejandro Enedino Hernandez Samaniego <[email protected]>
---
 meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-support/remmina/remmina_1.3.6.bb +3 -0
index a14a2592cd..a86deccc8f 100644
@@ -5,6 +5,9 @@ LICENSE = "GPLv2 & openssl"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
 DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui libsodium libssh vte json-glib libsoup-2.4 libvncserver spice spice-protocol libsecret"
 
+DEPENDS_append_libc-musl = "libexecinfo"
+LDFLAGS_append_libc-musl = " -lexecinfo"
+
 SRC_URI = "https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2 \
 "
 SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
Signature · 1 line
2.23.0
#2 lore raw

Re: [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl

Hey Khem,

Thanks for this, I hadn't fixed it because I have no access to my laptop for now, looks good to me though.

Alejandro

Quoted 30 lines · Khem Raj
Cc Alejandro Enedino Hernandez Samaniego <[email protected]>
---
 meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-support/remmina/remmina_1.3.6.bb +0 -0
index a14a2592cd..a86deccc8f 100644
@@ -5,6 +5,9 @@ LICENSE = "GPLv2 & openssl"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f

file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui
libsodium libssh vte json-glib libsoup-2.4 libvncserver spice spice-protocol libsecret"

meta-oe/recipes-support/remmina/remmina_1.3.6.bb +3 -0
+DEPENDS_append_libc-musl = "libexecinfo"
+LDFLAGS_append_libc-musl = " -lexecinfo"
+
 SRC_URI = "

https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2
\
"
SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
--
2.23.0

author
#3 lore raw

Re: [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl

another issue on arm

ERROR: Nothing PROVIDES 'spice' (but /mnt/b/yoe/sources/meta-openembedded/meta-oe/recipes-support/remmina/remmina_1.3.6.bb DEPENDS on
or otherwise requires it)
spice was skipped: incompatible with host arm-yoe-linux-gnueabi (not
in COMPATIBLE_HOST)

I think you need to mold arch support for it as per deps

Quoted 32 lines · Alejandro Enedino Hernandez Samaniego

Hey Khem,

Thanks for this, I hadn't fixed it because I have no access to my laptop for now, looks good to me though.

Alejandro

Quoted 24 lines · Khem Raj
Cc Alejandro Enedino Hernandez Samaniego <[email protected]>
---
 meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-support/remmina/remmina_1.3.6.bb +3 -1
index a14a2592cd..a86deccc8f 100644
@@ -5,6 +5,9 @@ LICENSE = "GPLv2 & openssl"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
 DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui libsodium libssh vte json-glib libsoup-2.4 libvncserver spice spice-protocol libsecret"
 
+DEPENDS_append_libc-musl = "libexecinfo"
+LDFLAGS_append_libc-musl = " -lexecinfo"
+
 SRC_URI = "https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2 \
 "
 SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
--

2.23.0

#4 lore raw

Re: [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl

Quoted 10 lines · Khem Raj

another issue on arm

ERROR: Nothing PROVIDES 'spice' (but /mnt/b/yoe/sources/meta-openembedded/meta-oe/recipes-support/remmina/ remmina_1.3.6.bb
DEPENDS on
or otherwise requires it)
spice was skipped: incompatible with host arm-yoe-linux-gnueabi (not in COMPATIBLE_HOST)

Quoted 2 lines

I think you need to mold arch support for it as per deps

I'll take a look later tonight, thanks.

Alejandro

Quoted 43 lines
Quoted 4 lines · Alejandro Enedino Hernandez Samaniego

Hey Khem,

Thanks for this, I hadn't fixed it because I have no access to my laptop

for now, looks good to me though.

Quoted 5 lines

Alejandro

Quoted 1 line · Khem Raj
Quoted 7 lines

Review

Quoted 7 lines
Cc Alejandro Enedino Hernandez Samaniego <[email protected]>
---
 meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb

Quoted 5 lines

meta-oe/recipes-support/remmina/remmina_1.3.6.bb LICENSE = "GPLv2 & openssl" · line 5

Quoted 5 lines

index a14a2592cd..a86deccc8f 100644

meta-oe/recipes-support/remmina/remmina_1.3.6.bb +0 -0
@@ -5,6 +5,9 @@ LICENSE = "GPLv2 & openssl"
 LIC_FILES_CHKSUM =

"file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"

Quoted 1 line

meta-oe/recipes-support/remmina/remmina_1.3.6.bb LICENSE = "GPLv2 & openssl" · line 6

Quoted 1 line
meta-oe/recipes-support/remmina/remmina_1.3.6.bb +0 -0
 DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui

libsodium libssh vte json-glib libsoup-2.4 libvncserver spice spice-protocol libsecret"

Quoted 5 lines

meta-oe/recipes-support/remmina/remmina_1.3.6.bb LICENSE = "GPLv2 & openssl"

Quoted 5 lines
meta-oe/recipes-support/remmina/remmina_1.3.6.bb +3 -0
+DEPENDS_append_libc-musl = "libexecinfo"
+LDFLAGS_append_libc-musl = " -lexecinfo"
+
 SRC_URI = "

https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2
\

Quoted 5 lines
Quoted 5 lines
meta-oe/recipes-support/remmina/remmina_1.3.6.bb +0 -1
 "
 SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
--

2.23.0

author
#5 lore raw

PATCH 3/3 samba: Fix configure tests to work with clang

In reply to Khem Raj

Do not use nested functions ( main inside main )
Use global scope for __thread variables

---
 ...ipt-Avoid-generating-nested-main-fun.patch | 30 ++++++++++
 ...ve-__thread-variable-to-global-scope.patch | 58 +++++++++++++++++++
 .../samba/samba_4.10.7.bb                     |  2 +
 3 files changed, 90 insertions(+)
 create mode 100644 meta-networking/recipes-connectivity/samba/samba/0001-lib-replace-wscript-Avoid-generating-nested-main-fun.patch
 create mode 100644 meta-networking/recipes-connectivity/samba/samba/0002-util_sec.c-Move-__thread-variable-to-global-scope.patch
meta-networking/recipes-connectivity/samba/samba/0001-lib-replace-wscript-Avoid-generating-nested-main-fun.patch new file +30 -0
new file mode 100644
index 0000000000..de7f311834
@@ -0,0 +1,30 @@
+From 3a935c638605bfb392ca7780d22c08c1a0a71e71 Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Thu, 5 Sep 2019 21:37:33 -0700
+Subject: [PATCH 1/2] lib/replace/wscript: Avoid generating nested main
+ function
+
+clang is not happy when it sees another main nested inside the main
+function and fails the test for prctl syscall, therefore avoid adding
+implicit main() here
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ lib/replace/wscript | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/lib/replace/wscript b/lib/replace/wscript
+index a7fd25d..d6767fc 100644
+--- a/lib/replace/wscript
++++ b/lib/replace/wscript
+@@ -137,6 +137,7 @@ def configure(conf):
+                     }
+                     ''',
+                     'HAVE_PRCTL',
++                    addmain=False,
+                     headers='sys/prctl.h',
+                     msg='Checking for prctl syscall')
+ 
+-- 
+2.23.0
+
meta-networking/recipes-connectivity/samba/samba/0002-util_sec.c-Move-__thread-variable-to-global-scope.patch new file +58 -0

58 lines not on this page · raw message

meta-networking/recipes-connectivity/samba/samba_4.10.7.bb +2 -0
index d13a6b4dbb..1b2bc087d5 100644
@@ -24,6 +24,8 @@ SRC_URI = "${SAMBA_MIRROR}/stable/samba-${PV}.tar.gz \
            file://smb_conf-4.7.0.patch \
            file://volatiles.03_samba \
            file://0001-waf-add-support-of-cross_compile.patch \
+           file://0001-lib-replace-wscript-Avoid-generating-nested-main-fun.patch \
+           file://0002-util_sec.c-Move-__thread-variable-to-global-scope.patch \
            "
 SRC_URI_append_libc-musl = " \
            file://samba-pam.patch \
Signature · 1 line
2.23.0