Skip to contentSkip to conversation

arm64: dts: renesas: Add /soc dma-ranges

PATCH In review [email protected] 3 participants 17 messages Sep 7, 2019 – Sep 30, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: renesas: Add /soc dma-ranges

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

To: [email protected]
---
NOTE: This is needed for the following patches to work correctly:

      https://patchwork.ozlabs.org/patch/1144870/
      https://patchwork.ozlabs.org/patch/1144871/
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +
 3 files changed, 3 insertions(+)
arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -0
index 95deff66eeb6..2102140a6723 100644
@@ -330,6 +330,7 @@
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;
+		dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;
 
 		rwdt: watchdog@e6020000 {
 			compatible = "renesas,r8a7795-wdt", "renesas,rcar-gen3-wdt";
arch/arm64/boot/dts/renesas/r8a7796.dtsi +1 -0
index 3dc9d73f589a..d115ff34d0db 100644
@@ -300,6 +300,7 @@
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;
+		dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;
 
 		rwdt: watchdog@e6020000 {
 			compatible = "renesas,r8a7796-wdt",
arch/arm64/boot/dts/renesas/r8a77965.dtsi +1 -0
index 4ae163220f60..74d934cfe44e 100644
@@ -183,6 +183,7 @@
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;
+		dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;
 
 		rwdt: watchdog@e6020000 {
 			compatible = "renesas,r8a77965-wdt",
Signature · 1 line
2.23.0.rc1
#1 lore raw

Hi Marek,

Quoted 7 lines · On Sat, Sep 7, 2019 at 6:16 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

Thanks for your patch!

Quoted 3 lines

NOTE: This is needed for the following patches to work correctly:

      https://patchwork.ozlabs.org/patch/1144870/
      https://patchwork.ozlabs.org/patch/1144871/

What happens with the above patches applied, and without this one?

As PCI/OF driver patches go in through different trees, is it safe to apply this patch now?
Should they go in together?

Quoted 3 lines
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +

Do we need similar patches for the other R-Car Gen3 and RZ/G2 DTS files? What about R-Car Gen2 and RZ/G1?

Thanks!

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw
Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

Quoted 9 lines · On Sat, Sep 7, 2019 at 6:16 PM <[email protected]> wrote:
Quoted 7 lines

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

Quoted 7 lines

Thanks for your patch!

Quoted 3 lines

NOTE: This is needed for the following patches to work correctly:

      https://patchwork.ozlabs.org/patch/1144870/
      https://patchwork.ozlabs.org/patch/1144871/

What happens with the above patches applied, and without this one?

It triggers https://patchwork.kernel.org/patch/11087391/#22811745

Quoted 3 lines

As PCI/OF driver patches go in through different trees, is it safe to apply this patch now?
Should they go in together?

I didn't get any feedback on the other two patches, but this one here is safe to go in either way.

Quoted 6 lines
Quoted 3 lines
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +

Do we need similar patches for the other R-Car Gen3 and RZ/G2 DTS files? What about R-Car Gen2 and RZ/G1?

I suspect we need such patches for any ARM64 machine with PCIe with this 32bit limitation.

Signature · 2 lines
Best regards,
Marek Vasut
#3 lore raw

Hi Marek,

Quoted 12 lines · Marek Vasut
Quoted 11 lines · Geert Uytterhoeven
Quoted 7 lines · On Sat, Sep 7, 2019 at 6:16 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

Thanks for your patch!

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

NOTE: This is needed for the following patches to work correctly:

      https://patchwork.ozlabs.org/patch/1144870/
      https://patchwork.ozlabs.org/patch/1144871/

What happens with the above patches applied, and without this one?

It triggers https://patchwork.kernel.org/patch/11087391/#22811745

Sure. But what does that mean?
PCI devices just not working?
Random memory corruption?
System lockup?
Anything else?

Quoted 7 lines
Quoted 3 lines

As PCI/OF driver patches go in through different trees, is it safe to apply this patch now?
Should they go in together?

I didn't get any feedback on the other two patches, but this one here is safe to go in either way.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +

Do we need similar patches for the other R-Car Gen3 and RZ/G2 DTS files? What about R-Car Gen2 and RZ/G1?

I suspect we need such patches for any ARM64 machine with PCIe with this 32bit limitation.

What about R-Car Gen2 and RZ/G1, which are ARM32, with LPAE?

Thanks!

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#4 lore raw
Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

Quoted 19 lines · Marek Vasut
Quoted 18 lines · Geert Uytterhoeven
Quoted 16 lines · On Sat, Sep 7, 2019 at 6:16 PM <[email protected]> wrote:
Quoted 7 lines

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

Thanks for your patch!

Quoted 3 lines

NOTE: This is needed for the following patches to work correctly:

      https://patchwork.ozlabs.org/patch/1144870/
      https://patchwork.ozlabs.org/patch/1144871/

What happens with the above patches applied, and without this one?

Quoted 7 lines
Quoted 1 line

It triggers https://patchwork.kernel.org/patch/11087391/#22811745

Sure. But what does that mean?
PCI devices just not working?
Random memory corruption?
System lockup?
Anything else?

Instead of translating the PCI DMA range to 0x40000000-0xffffffff , the PCI code in the aforementioned patches defaults to maximum range, which prevents various devices from working correctly, as the buffers get allocated above the 32bit boundary.

Quoted 11 lines
Quoted 11 lines
Quoted 3 lines

As PCI/OF driver patches go in through different trees, is it safe to apply this patch now?
Should they go in together?

I didn't get any feedback on the other two patches, but this one here is safe to go in either way.

Quoted 4 lines
Quoted 3 lines
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Do we need similar patches for the other R-Car Gen3 and RZ/G2 DTS files? What about R-Car Gen2 and RZ/G1?

I suspect we need such patches for any ARM64 machine with PCIe with this 32bit limitation.

What about R-Car Gen2 and RZ/G1, which are ARM32, with LPAE?

Presumably we need that too ?

Signature · 2 lines
Best regards,
Marek Vasut
#5 lore raw
In reply to [email protected]

Hi Marek,

Quoted 11 lines · On Sat, Sep 7, 2019 at 6:16 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

arch/arm64/boot/dts/renesas/r8a7795.dtsi line 333

Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -0
@@ -330,6 +330,7 @@
                #address-cells = <2>;
                #size-cells = <2>;
                ranges;
+               dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;

Shouldn't the length be 0x80000000 (for all SoCs)? Or should we allow DMA to internal System RAM, too?

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
maintainer
#10 lore raw
In reply to [email protected]
Quoted 6 lines · On Sat, Sep 7, 2019 at 5:16 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

FYI, I've started working on this problem and issues around dma-ranges/dma_mask. Hopefully I'll get some patches out next week.

Quoted 10 lines

To: [email protected]
---
NOTE: This is needed for the following patches to work correctly:

      https://patchwork.ozlabs.org/patch/1144870/
      https://patchwork.ozlabs.org/patch/1144871/

First I'm seeing those... Well, I do have v7 from 2+ years ago...

Not sure if these take into account the new dma_bus_mask, but that should simplify solving the issue.

Quoted 11 lines
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +
 3 files changed, 3 insertions(+)
arch/arm64/boot/dts/renesas/r8a7795.dtsi +0 -0
index 95deff66eeb6..2102140a6723 100644

arch/arm64/boot/dts/renesas/r8a7795.dtsi line 333

Quoted 4 lines
arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -0
@@ -330,6 +330,7 @@
                #address-cells = <2>;
                #size-cells = <2>;
                ranges;
+               dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;

Is the limitation in the bus or the PCI bridge or both? The commit message sounds like it's the PCI bridge in which case this is wrong (or incomplete). 'dma-ranges' should be on the bus node where the restriction/translation exists. For PCI devices, that's the PCI bridge node. So a 32-bit only PCI bridge should have a dma-ranges size of 4GB. If the SoC bus has more restrictions, then that should be in the PCI bridge parent assuming that restriction also applies to other devices.

Rob

#11 lore raw
Quoted 10 lines · Rob Herring
Quoted 6 lines · On Sat, Sep 7, 2019 at 5:16 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

FYI, I've started working on this problem and issues around dma-ranges/dma_mask. Hopefully I'll get some patches out next week.

Thanks

Quoted 6 lines
Quoted 4 lines

---
NOTE: This is needed for the following patches to work correctly:

      https://patchwork.ozlabs.org/patch/1144870/
      https://patchwork.ozlabs.org/patch/1144871/

First I'm seeing those... Well, I do have v7 from 2+ years ago...

Right, this issue was dragging on for a very long time.

Quoted 2 lines

Not sure if these take into account the new dma_bus_mask, but that should simplify solving the issue.

What's that about ?

Quoted 6 lines
Quoted 6 lines
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +
 3 files changed, 3 insertions(+)
Quoted 13 lines

arch/arm64/boot/dts/renesas/r8a7795.dtsi line 333

Quoted 9 lines
arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -0
index 95deff66eeb6..2102140a6723 100644
@@ -330,6 +330,7 @@
                #address-cells = <2>;
                #size-cells = <2>;
                ranges;
+               dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;

Is the limitation in the bus or the PCI bridge or both? The commit message sounds like it's the PCI bridge in which case this is wrong (or incomplete).

I believe it is the PCI bridge too.

Quoted 6 lines

'dma-ranges' should be on the bus node where the restriction/translation exists. For PCI devices, that's the PCI bridge node. So a 32-bit only PCI bridge should have a dma-ranges size of 4GB. If the SoC bus has more restrictions, then that should be in the PCI bridge parent assuming that restriction also applies to other devices.

Would that mean the dma-ranges for /soc/pcie@fe000000/ [1], which is already present in the DTSi, is the one that should be used to determine the controller limitations ?

[1]
https://elixir.bootlin.com/linux/v5.3-rc8/source/arch/arm64/boot/dts/renesas/r8a7795.dtsi#L2653

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw
In reply to Geert Uytterhoeven
Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

Quoted 6 lines · Marek Vasut
Quoted 4 lines

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

Quoted 9 lines

arch/arm64/boot/dts/renesas/r8a7795.dtsi line 333

Quoted 7 lines
arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -0
@@ -330,6 +330,7 @@
                #address-cells = <2>;
                #size-cells = <2>;
                ranges;
+               dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;

Shouldn't the length be 0x80000000 (for all SoCs)?

Or should that match the amount of DRAM below 32bit boundary ?

Quoted 1 line

Or should we allow DMA to internal System RAM, too?

I think we should include SRAM, yes.

Signature · 2 lines
Best regards,
Marek Vasut
#7 lore raw

Hi Marek,

Quoted 16 lines · Marek Vasut
Quoted 5 lines · Geert Uytterhoeven
Quoted 3 lines · Marek Vasut

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

Quoted 9 lines

arch/arm64/boot/dts/renesas/r8a7795.dtsi line 333

Quoted 7 lines
arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -0
@@ -330,6 +330,7 @@
                #address-cells = <2>;
                #size-cells = <2>;
                ranges;
+               dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;

Shouldn't the length be 0x80000000 (for all SoCs)?

Quoted 1 line

Or should that match the amount of DRAM below 32bit boundary ?

Which is 0x80000000, according to the memory area section for the various R-Car Gen3 SoCs.

Quoted 3 lines
Quoted 1 line

Or should we allow DMA to internal System RAM, too?

I think we should include SRAM, yes.

So that needs a separate range.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#8 lore raw
Quoted 1 line · Geert Uytterhoeven

Hi Marek,

Hi,

Quoted 17 lines · Marek Vasut
Quoted 16 lines · Geert Uytterhoeven
Quoted 14 lines · Marek Vasut

arch/arm64/boot/dts/renesas/r8a7795.dtsi line 333

Quoted 11 lines

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -0
@@ -330,6 +330,7 @@
                #address-cells = <2>;
                #size-cells = <2>;
                ranges;
+               dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;

Shouldn't the length be 0x80000000 (for all SoCs)?

Quoted 4 lines
Quoted 1 line

Or should that match the amount of DRAM below 32bit boundary ?

Which is 0x80000000, according to the memory area section for the various R-Car Gen3 SoCs.

What if you have a system with 1 GiB of DRAM ?

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Or should we allow DMA to internal System RAM, too?

I think we should include SRAM, yes.

So that needs a separate range.

Let's see how the discussion pans out about the placement of the dma-ranges in the first place.

Signature · 2 lines
Best regards,
Marek Vasut
#9 lore raw

Hi Marek,

Quoted 18 lines · Marek Vasut
Quoted 17 lines · Geert Uytterhoeven
Quoted 16 lines · Marek Vasut
Quoted 14 lines · Geert Uytterhoeven

arch/arm64/boot/dts/renesas/r8a7795.dtsi line 333

Quoted 11 lines · Marek Vasut

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -0
@@ -330,6 +330,7 @@
                #address-cells = <2>;
                #size-cells = <2>;
                ranges;
+               dma-ranges = <0 0x40000000 0 0x40000000 0 0xc0000000>;

Shouldn't the length be 0x80000000 (for all SoCs)?

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Or should that match the amount of DRAM below 32bit boundary ?

Which is 0x80000000, according to the memory area section for the various R-Car Gen3 SoCs.

What if you have a system with 1 GiB of DRAM ?

Should be covered by 0x80000000, no?
Linux will never ask a PCI device to do bus mastering to an area not backed by populated memory, will it?

However, you ask a good question: does this property specify the limits of the bridge, or the limits of the bridge combined with the actual populated or available memory?

In the former case, offset and length should be "0 0x0" resp. "1 0x00000000". In the latter case, it depends on the actual board (SiP is board, too) configuration.
Which means U-Boot may need to update this ("AND" mask the value we specify here?), based on what it writes into the memory node?

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Or should we allow DMA to internal System RAM, too?

I think we should include SRAM, yes.

So that needs a separate range.

Let's see how the discussion pans out about the placement of the dma-ranges in the first place.

Yep.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
maintainer
#12 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring
Quoted 6 lines · On Sat, Sep 7, 2019 at 5:16 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

FYI, I've started working on this problem and issues around dma-ranges/dma_mask. Hopefully I'll get some patches out next week.

I've pushed out a branch here:

git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dma-masks

Can you test it on Renesas. I don't have a real platform having the issue.

Rob

#13 lore raw
Quoted 10 lines · Rob Herring
Quoted 9 lines · Rob Herring
Quoted 6 lines · On Sat, Sep 7, 2019 at 5:16 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

Quoted 8 lines
Quoted 2 lines

FYI, I've started working on this problem and issues around dma-ranges/dma_mask. Hopefully I'll get some patches out next week.

I've pushed out a branch here:

git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dma-masks

Can you test it on Renesas. I don't have a real platform having the issue.

Due to ER/KR, I can only test it Monday-ish. I hope that's OK ?

Signature · 2 lines
Best regards,
Marek Vasut
#14 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring
Quoted 9 lines · Rob Herring
Quoted 6 lines · On Sat, Sep 7, 2019 at 5:16 PM wrote:

From: Marek Vasut

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

Quoted 8 lines
Quoted 2 lines

FYI, I've started working on this problem and issues around dma-ranges/dma_mask. Hopefully I'll get some patches out next week.

I've pushed out a branch here:

git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dma-masks

Can you test it on Renesas. I don't have a real platform having the issue.

With the following patches applied:

      https://patchwork.ozlabs.org/patch/1144870/
      https://patchwork.ozlabs.org/patch/1144871/

on R8A7795 Salvator-XS, works fine.

Signature · 2 lines
Best regards,
Marek Vasut
maintainer
#15 lore raw
Quoted 17 lines · Marek Vasut
Quoted 15 lines · Rob Herring
Quoted 11 lines · Rob Herring
Quoted 6 lines · On Sat, Sep 7, 2019 at 5:16 PM wrote:

From: Marek Vasut

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

FYI, I've started working on this problem and issues around dma-ranges/dma_mask. Hopefully I'll get some patches out next week.

I've pushed out a branch here:

Quoted 7 lines
Quoted 3 lines

git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dma-masks

Can you test it on Renesas. I don't have a real platform having the issue.

With the following patches applied:

      https://patchwork.ozlabs.org/patch/1144870/

I'd rather not have yet another instance of {dma-}ranges parsing code. With this series[1], dma-ranges gets parsed into resource list for you.

Quoted 1 line
      https://patchwork.ozlabs.org/patch/1144871/

How can this one be applied? It would conflict horribly. Plus I think it duplicates what's in my series.

Rob

Quoted 1 line

on R8A7795 Salvator-XS, works fine.

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/T/

#16 lore raw
Quoted 26 lines · Rob Herring
Quoted 17 lines · Marek Vasut
Quoted 15 lines · Rob Herring
Quoted 11 lines · Rob Herring
Quoted 6 lines · On Sat, Sep 7, 2019 at 5:16 PM wrote:

From: Marek Vasut

Add dma-ranges property into /soc node to describe the DMA capabilities of the bus. This is currently needed to translate PCI DMA ranges, which are limited to 32bit addresses.

FYI, I've started working on this problem and issues around dma-ranges/dma_mask. Hopefully I'll get some patches out next week.

I've pushed out a branch here:

Quoted 7 lines
Quoted 3 lines

git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dma-masks

Can you test it on Renesas. I don't have a real platform having the issue.

With the following patches applied:

      https://patchwork.ozlabs.org/patch/1144870/
Quoted 8 lines

I'd rather not have yet another instance of {dma-}ranges parsing code. With this series[1], dma-ranges gets parsed into resource list for you.

Quoted 1 line
      https://patchwork.ozlabs.org/patch/1144871/

How can this one be applied? It would conflict horribly. Plus I think it duplicates what's in my series.

I fixed it up real quick, but apparently these are not needed indeed.

[...]

Signature · 2 lines
Best regards,
Marek Vasut