Skip to contentSkip to conversation

next-20190904: build failure in cp210x usb serial, gpio related?

DISCUSSION Pavel Machek 2 participants 2 messages Sep 8, 2019 – Sep 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi!

I'm getting this compiling the -next:

CC drivers/net/wireless/intel/iwlwifi/mvm/mac80211.o
In file included from drivers/usb/serial/cp210x.c:23:
./include/linux/gpio/driver.h:722:19: error: static declaration of ‘gpiochip_lock_as_irq’ follows non-static declaration
722 | static inline int gpiochip_lock_as_irq(struct gpio_chip
*chip,

        |                   ^~~~~~~~~~~~~~~~~~~~
	./include/linux/gpio/driver.h:706:5: note: previous
  declaration of ‘gpiochip_lock_as_irq’ was here
    706 | int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned
  int offset);
        |     ^~~~~~~~~~~~~~~~~~~~
	./include/linux/gpio/driver.h:729:20: error: static
  declaration of ‘gpiochip_unlock_as_irq’ follows non-static
  declaration
    729 | static inline void gpiochip_unlock_as_irq(struct gpio_chip
  *chip,
        |                    ^~~~~~~~~~~~~~~~~~~~~~
	./include/linux/gpio/driver.h:707:6: note: previous
  declaration of ‘gpiochip_unlock_as_irq’ was here
    707 | void gpiochip_unlock_as_irq(struct gpio_chip *chip, unsigned
  int offset);
        |      ^~~~~~~~~~~~~~~~~~~~~~
	make[3]: *** [scripts/Makefile.build:265:

drivers/usb/serial/cp210x.o] Error 1
make[2]: *** [scripts/Makefile.build:509: drivers/usb/serial] Error 2
make[2]: *** Waiting for unfinished jobs....
CC drivers/gpu/drm/ttm/ttm_page_alloc.o
AR drivers/usb/storage/built-in.a

Sounds like some fixes are needed in gpio headers?

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 1 line · Pavel Machek

I'm getting this compiling the -next:

(...)

Quoted 4 lines

./include/linux/gpio/driver.h:722:19: error: static declaration of ‘gpiochip_lock_as_irq’ follows non-static declaration
722 | static inline int gpiochip_lock_as_irq(struct gpio_chip
*chip,

Yes this was fixed pretty much the same day the next release came out, and by now I got like 4 different patches solving the same problem, because no new next releases are coming out right now...
bad timing with no next releases during the kernel summit, sorry!

Yours,
Linus Walleij