Skip to contentSkip to conversation

crypto: talitos - fix missing break in switch statement

PATCH In review Gustavo A. R. Silva 3 participants 4 messages Sep 9, 2019 – Sep 20, 2019 Crypto API

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 crypto: talitos - fix missing break in switch statement

Add missing break statement in order to prevent the code from falling through to case CRYPTO_ALG_TYPE_AHASH.

Fixes aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
Cc [email protected]
Reported-by kbuild test robot <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/talitos.c | 1 +
 1 file changed, 1 insertion(+)
drivers/crypto/talitos.c +1 -0
index c9d686a0e805..4818ae427098 100644
@@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
 			break;
 		case CRYPTO_ALG_TYPE_AEAD:
 			crypto_unregister_aead(&t_alg->algt.alg.aead);
+			break;
 		case CRYPTO_ALG_TYPE_AHASH:
 			crypto_unregister_ahash(&t_alg->algt.alg.hash);
 			break;
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw

Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :

Quoted 7 lines

Add missing break statement in order to prevent the code from falling through to case CRYPTO_ALG_TYPE_AHASH.

Fixes aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
Cc [email protected]
Reported-by kbuild test robot <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Christophe Leroy <[email protected]>
Quoted 17 lines
---
  drivers/crypto/talitos.c | 1 +
  1 file changed, 1 insertion(+)
drivers/crypto/talitos.c +1 -0
index c9d686a0e805..4818ae427098 100644
@@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
  			break;
  		case CRYPTO_ALG_TYPE_AEAD:
  			crypto_unregister_aead(&t_alg->algt.alg.aead);
+			break;
  		case CRYPTO_ALG_TYPE_AHASH:
  			crypto_unregister_ahash(&t_alg->algt.alg.hash);
  			break;
author
#2 lore raw

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

Quoted 30 lines · Christophe Leroy

Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :

Quoted 7 lines

Add missing break statement in order to prevent the code from falling through to case CRYPTO_ALG_TYPE_AHASH.

Fixes aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
Cc [email protected]
Reported-by kbuild test robot <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Christophe Leroy <[email protected]>
Quoted 17 lines

---
  drivers/crypto/talitos.c | 1 +

  1 file changed, 1 insertion(+)
drivers/crypto/talitos.c +0 -0
index c9d686a0e805..4818ae427098 100644
@@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
               break;

          case CRYPTO_ALG_TYPE_AEAD:
              crypto_unregister_aead(&t_alg->algt.alg.aead); +            break;
          case CRYPTO_ALG_TYPE_AHASH:
              crypto_unregister_ahash(&t_alg->algt.alg.hash); break;

maintainer
#3 lore raw
In reply to Gustavo A. R. Silva
Quoted 10 lines · Gustavo A. R. Silva

Add missing break statement in order to prevent the code from falling through to case CRYPTO_ALG_TYPE_AHASH.

Fixes aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
Cc [email protected]
Reported-by kbuild test robot <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/talitos.c | 1 +
 1 file changed, 1 insertion(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt