Skip to contentSkip to conversation

Few loose end intel_gt cleanups

PATCH In review Tvrtko Ursulin 3 participants 13 messages Sep 10, 2019 – Sep 11, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Few loose end intel_gt cleanups

From: Tvrtko Ursulin <[email protected]>

A few patches left hanging since late July. First one old in spirit but adjusted and renamed and the rest update for latest drm-tip.

Happy to receive thoughts on whether this cleanup makes sense.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>

Tvrtko Ursulin (4):
drm/i915: Move GT init to intel_gt.c drm/i915: Make wait_for_timelines take struct intel_gt drm/i915: Avoid round-trip via i915 in intel_gt_park drm/i915: Make pm_notify take intel_gt

 drivers/gpu/drm/i915/gem/i915_gem_pm.c    |   2 +-
 drivers/gpu/drm/i915/gt/intel_gt.c        |  92 ++++++++++++++++++-
 drivers/gpu/drm/i915/gt/intel_gt.h        |   3 +-
 drivers/gpu/drm/i915/gt/intel_gt_pm.c     |  14 +--
 drivers/gpu/drm/i915/gt/intel_reset.c     |   2 +-
 drivers/gpu/drm/i915/i915_drv.c           |   2 +-
 drivers/gpu/drm/i915/i915_drv.h           |   1 -
 drivers/gpu/drm/i915/i915_gem.c           | 102 ++--------------------
 drivers/gpu/drm/i915/selftests/mock_gtt.c |   2 +-
 9 files changed, 111 insertions(+), 109 deletions(-)
Signature · 5 lines
2.20.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 1/4 drm/i915: Move GT init to intel_gt.c

From: Tvrtko Ursulin <[email protected]>

Code in i915_gem_init_hw is all about GT init so move it to intel_gt.c renaming to intel_gt_init_hw.

Existing intel_gt_init_hw is renamed to intel_gt_init_hw_early since it is currently called from driver probe.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_pm.c    |  2 +-
 drivers/gpu/drm/i915/gt/intel_gt.c        | 92 ++++++++++++++++++++++-
 drivers/gpu/drm/i915/gt/intel_gt.h        |  3 +-
 drivers/gpu/drm/i915/gt/intel_reset.c     |  2 +-
 drivers/gpu/drm/i915/i915_drv.c           |  2 +-
 drivers/gpu/drm/i915/i915_drv.h           |  1 -
 drivers/gpu/drm/i915/i915_gem.c           | 91 +---------------------
 drivers/gpu/drm/i915/selftests/mock_gtt.c |  2 +-
 8 files changed, 98 insertions(+), 97 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_pm.c +1 -1
index 9b1129aaacfe..3bd764104d41 100644
@@ -242,7 +242,7 @@ void i915_gem_resume(struct drm_i915_private *i915)
 	mutex_lock(&i915->drm.struct_mutex);
 	intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
 
-	if (i915_gem_init_hw(i915))
+	if (intel_gt_init_hw(&i915->gt))
 		goto err_wedged;
 
 	/*
drivers/gpu/drm/i915/gt/intel_gt.c +91 -1

110 lines not on this page · raw message

drivers/gpu/drm/i915/gt/intel_gt.h +2 -1
index 17af21cb7ed3..e6ab0bff0efb 100644
@@ -28,7 +28,8 @@ static inline struct intel_gt *huc_to_gt(struct intel_huc *huc)
 }
 
 void intel_gt_init_early(struct intel_gt *gt, struct drm_i915_private *i915);
-void intel_gt_init_hw(struct drm_i915_private *i915);
+void intel_gt_init_hw_early(struct drm_i915_private *i915);
+int __must_check intel_gt_init_hw(struct intel_gt *gt);
 int intel_gt_init(struct intel_gt *gt);
 void intel_gt_driver_register(struct intel_gt *gt);
 
drivers/gpu/drm/i915/gt/intel_reset.c +1 -1
index b9d84d52e986..296bbc7745fb 100644
@@ -972,7 +972,7 @@ void intel_gt_reset(struct intel_gt *gt,
 	 * was running at the time of the reset (i.e. we weren't VT
 	 * switched away).
 	 */
-	ret = i915_gem_init_hw(gt->i915);
+	ret = intel_gt_init_hw(gt);
 	if (ret) {
 		DRM_ERROR("Failed to initialise HW following reset (%d)\n",
 			  ret);
drivers/gpu/drm/i915/i915_drv.c +1 -1
index 1af4eba968c0..b1a942fc43c8 100644
@@ -1232,7 +1232,7 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)
 	if (ret)
 		goto err_ggtt;
 
-	intel_gt_init_hw(dev_priv);
+	intel_gt_init_hw_early(dev_priv);
 
 	ret = i915_ggtt_enable_hw(dev_priv);
 	if (ret) {
drivers/gpu/drm/i915/i915_drv.h +0 -1
index e289b4ffd34b..2e704402b99d 100644
@@ -2318,7 +2318,6 @@ static inline u32 i915_reset_engine_count(struct i915_gpu_error *error,
 
 void i915_gem_init_mmio(struct drm_i915_private *i915);
 int __must_check i915_gem_init(struct drm_i915_private *dev_priv);
-int __must_check i915_gem_init_hw(struct drm_i915_private *dev_priv);
 void i915_gem_driver_register(struct drm_i915_private *i915);
 void i915_gem_driver_unregister(struct drm_i915_private *i915);
 void i915_gem_driver_remove(struct drm_i915_private *dev_priv);
drivers/gpu/drm/i915/i915_gem.c +1 -90

103 lines not on this page · raw message

drivers/gpu/drm/i915/selftests/mock_gtt.c +1 -1
index e62a67e0f79c..7d5fb60b43bb 100644
@@ -118,7 +118,7 @@ void mock_init_ggtt(struct drm_i915_private *i915, struct i915_ggtt *ggtt)
 
 	i915_address_space_init(&ggtt->vm, VM_CLASS_GGTT);
 
-	intel_gt_init_hw(i915);
+	intel_gt_init_hw_early(i915);
 }
 
 void mock_fini_ggtt(struct i915_ggtt *ggtt)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

PATCH 2/4 drm/i915: Make wait_for_timelines take struct intel_gt

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Timelines live in struct intel_gt so make wait_for_timelines take exactly what it needs.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +6 -5
index db2681514a0b..2da9544fa9a4 100644
@@ -888,10 +888,9 @@ void i915_gem_runtime_suspend(struct drm_i915_private *i915)
 }
 
 static long
-wait_for_timelines(struct drm_i915_private *i915,
-		   unsigned int wait, long timeout)
+wait_for_timelines(struct intel_gt *gt, unsigned int wait, long timeout)
 {
-	struct intel_gt_timelines *timelines = &i915->gt.timelines;
+	struct intel_gt_timelines *timelines = &gt->timelines;
 	struct intel_timeline *tl;
 	unsigned long flags;
 
@@ -934,15 +933,17 @@ wait_for_timelines(struct drm_i915_private *i915,
 int i915_gem_wait_for_idle(struct drm_i915_private *i915,
 			   unsigned int flags, long timeout)
 {
+	struct intel_gt *gt = &i915->gt;
+
 	/* If the device is asleep, we have no requests outstanding */
-	if (!intel_gt_pm_is_awake(&i915->gt))
+	if (!intel_gt_pm_is_awake(gt))
 		return 0;
 
 	GEM_TRACE("flags=%x (%s), timeout=%ld%s\n",
 		  flags, flags & I915_WAIT_LOCKED ? "locked" : "unlocked",
 		  timeout, timeout == MAX_SCHEDULE_TIMEOUT ? " (forever)" : "");
 
-	timeout = wait_for_timelines(i915, flags, timeout);
+	timeout = wait_for_timelines(gt, flags, timeout);
 	if (timeout < 0)
 		return timeout;
 
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

PATCH 3/4 drm/i915: Avoid round-trip via i915 in intel_gt_park

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Both in the container_of and getting to gt->awake there is no need to go via i915 since both the wakeref and awake are members of gt.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt_pm.c +3 -3
index 6ba0d2069f87..a2e29bcc9671 100644
@@ -56,9 +56,9 @@ static int __gt_unpark(struct intel_wakeref *wf)
 
 static int __gt_park(struct intel_wakeref *wf)
 {
-	struct drm_i915_private *i915 =
-		container_of(wf, typeof(*i915), gt.wakeref);
-	intel_wakeref_t wakeref = fetch_and_zero(&i915->gt.awake);
+	struct intel_gt *gt = container_of(wf, typeof(*gt), wakeref);
+	intel_wakeref_t wakeref = fetch_and_zero(&gt->awake);
+	struct drm_i915_private *i915 = gt->i915;
 
 	GEM_TRACE("\n");
 
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

PATCH 4/4 drm/i915: Make pm_notify take intel_gt

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

These notifications operate on intel_gt so make the code take what it needs.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt_pm.c +4 -4
index a2e29bcc9671..2ccf8cacaa0a 100644
@@ -13,9 +13,9 @@
 #include "intel_pm.h"
 #include "intel_wakeref.h"
 
-static void pm_notify(struct drm_i915_private *i915, int state)
+static void pm_notify(struct intel_gt *gt, int state)
 {
-	blocking_notifier_call_chain(&i915->gt.pm_notifications, state, i915);
+	blocking_notifier_call_chain(&gt->pm_notifications, state, gt->i915);
 }
 
 static int __gt_unpark(struct intel_wakeref *wf)
@@ -49,7 +49,7 @@ static int __gt_unpark(struct intel_wakeref *wf)
 
 	intel_gt_queue_hangcheck(gt);
 
-	pm_notify(i915, INTEL_GT_UNPARK);
+	pm_notify(gt, INTEL_GT_UNPARK);
 
 	return 0;
 }
@@ -62,7 +62,7 @@ static int __gt_park(struct intel_wakeref *wf)
 
 	GEM_TRACE("\n");
 
-	pm_notify(i915, INTEL_GT_PARK);
+	pm_notify(gt, INTEL_GT_PARK);
 
 	i915_pmu_gt_parked(i915);
 	if (INTEL_GEN(i915) >= 6)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw

✗ Fi.CI.CHECKPATCH: warning for Few loose end intel_gt cleanups

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: Few loose end intel_gt cleanups
URL : https://patchwork.freedesktop.org/series/66490/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4144570a45a2 drm/i915: Move GT init to intel_gt.c
-:89: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#89: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:72:
+	BUG_ON(!i915->kernel_context);

total: 0 errors, 1 warnings, 0 checks, 261 lines checked 98290456e271 drm/i915: Make wait_for_timelines take struct intel_gt f3e26c80db02 drm/i915: Avoid round-trip via i915 in intel_gt_park ec71271e3802 drm/i915: Make pm_notify take intel_gt

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/4
#2 lore raw

Re: [PATCH 1/4] drm/i915: Move GT init to intel_gt.c

In reply to Tvrtko Ursulin

Quoting Tvrtko Ursulin (2019-09-10 15:38:20)

Quoted 11 lines

From: Tvrtko Ursulin <[email protected]>

Code in i915_gem_init_hw is all about GT init so move it to intel_gt.c renaming to intel_gt_init_hw.

Existing intel_gt_init_hw is renamed to intel_gt_init_hw_early since it is currently called from driver probe.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 2/4
#4 lore raw

Re: [PATCH 2/4] drm/i915: Make wait_for_timelines take struct intel_gt

In reply to Tvrtko Ursulin

Quoting Tvrtko Ursulin (2019-09-10 15:38:21)

Quoted 8 lines

From: Tvrtko Ursulin <[email protected]>

Timelines live in struct intel_gt so make wait_for_timelines take exactly what it needs.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>

I've deleted this code, fwiw, merged it with request management and ended up with intel_gt_retire_requests()

Still,

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 3/4
#6 lore raw

Re: [PATCH 3/4] drm/i915: Avoid round-trip via i915 in intel_gt_park

In reply to Tvrtko Ursulin

Quoting Tvrtko Ursulin (2019-09-10 15:38:22)

Quoted 8 lines

From: Tvrtko Ursulin <[email protected]>

Both in the container_of and getting to gt->awake there is no need to go via i915 since both the wakeref and awake are members of gt.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>

Have same chunk somewhere as well,

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 4/4
#8 lore raw

Re: [PATCH 4/4] drm/i915: Make pm_notify take intel_gt

In reply to Tvrtko Ursulin

Quoting Tvrtko Ursulin (2019-09-10 15:38:23)

Quoted 8 lines

From: Tvrtko Ursulin <[email protected]>

These notifications operate on intel_gt so make the code take what it needs.

Cc Andi Shyti <[email protected]>
Cc Chris Wilson <[email protected]>

Soon the blocking_notifier will be relieved of duty...

I think it might be better if we pass gt to the notify_cb and have it extract its i915 from that, but my goal is to remove it, so it really doesn't matter!

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

✓ Fi.CI.BAT: success for Few loose end intel_gt cleanups

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: Few loose end intel_gt cleanups
URL : https://patchwork.freedesktop.org/series/66490/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6861 -> Patchwork_14342
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_14342:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_sync@basic-each:
- {fi-tgl-u}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-tgl-u/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_14342 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_basic@create-close:
- fi-icl-u3: [PASS][2] -> [DMESG-WARN][3] ([fdo#107724]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u3/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u3/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_switch@legacy-render:
- {fi-icl-guc}: [INCOMPLETE][4] ([fdo#107713] / [fdo#111381]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-guc/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-guc/igt@[email protected]
- fi-icl-u2: [INCOMPLETE][6] ([fdo#107713] / [fdo#111381]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u2/igt@[email protected]

* igt@gem_exec_gttfill@basic:
- {fi-tgl-u}: [INCOMPLETE][8] ([fdo#111593]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-tgl-u/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-tgl-u/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- fi-icl-u3: [DMESG-WARN][10] ([fdo#107724]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u3/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [DMESG-FAIL][12] ([fdo#111108]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html

#### Warnings ####

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][14] ([fdo#111096]) -> [FAIL][15] ([fdo#111407])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-kbl-7500u/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-kbl-7500u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593

Participating hosts (54 -> 46)
------------------------------

Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_6861 -> Patchwork_14342

CI-20190529: 20190529
CI_DRM_6861: 32c81a3173640f165510de65b8e4137aa049b33f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14342: ec71271e3802895ae608065d4914d63157adae2c @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

ec71271e3802 drm/i915: Make pm_notify take intel_gt f3e26c80db02 drm/i915: Avoid round-trip via i915 in intel_gt_park 98290456e271 drm/i915: Make wait_for_timelines take struct intel_gt 4144570a45a2 drm/i915: Move GT init to intel_gt.c

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

✓ Fi.CI.IGT: success for Few loose end intel_gt cleanups

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: Few loose end intel_gt cleanups
URL : https://patchwork.freedesktop.org/series/66490/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6861_full -> Patchwork_14342_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_14342_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-apl4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-apl4/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110841])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb1/igt@[email protected]

* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb1/igt@[email protected]

* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +9 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb7/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([fdo#107713] / [fdo#109100])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb3/igt@[email protected]
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([fdo#104108])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-skl5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-skl8/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][13] -> [FAIL][14] ([fdo#104873])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-glk5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-glk8/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([fdo#103540])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-hsw8/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-hsw8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-apl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-apl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render:
- shard-skl: [PASS][21] -> [DMESG-WARN][22] ([fdo#106107])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-skl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-skl3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render.html

* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb2/igt@kms_psr@psr2_dpms.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb6/igt@kms_psr@psr2_dpms.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][25] -> [FAIL][26] ([fdo#99912])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-apl1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-apl2/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][27] ([fdo#111325]) -> [PASS][28] +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-apl7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-apl3/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [FAIL][31] ([fdo#105363]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-glk3/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-glk2/igt@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [FAIL][33] ([fdo#100368]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-skl9/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-skl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
- shard-iclb: [FAIL][35] ([fdo#103167]) -> [PASS][36] +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb6/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][37] ([fdo#104108] / [fdo#106978]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-skl4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-skl2/igt@[email protected]

* igt@perf@polling:
- shard-apl: [INCOMPLETE][39] ([fdo#103927]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-apl7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-apl7/igt@[email protected]

* igt@prime_busy@after-bsd2:
- shard-iclb: [SKIP][41] ([fdo#109276]) -> [PASS][42] +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/shard-iclb8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/shard-iclb1/igt@[email protected]

[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_6861 -> Patchwork_14342

CI-20190529: 20190529
CI_DRM_6861: 32c81a3173640f165510de65b8e4137aa049b33f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14342: ec71271e3802895ae608065d4914d63157adae2c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

Re: ✓ Fi.CI.BAT: success for Few loose end intel_gt cleanups

In reply to Patchwork
Quoted 116 lines · Patchwork

== Series Details ==

Series: Few loose end intel_gt cleanups
URL : https://patchwork.freedesktop.org/series/66490/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6861 -> Patchwork_14342
====================================================

Summary
-------

   **SUCCESS**

   No regressions found.

   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_14342:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_sync@basic-each:
- {fi-tgl-u}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-tgl-u/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_14342 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_basic@create-close:

     - fi-icl-u3:          [PASS][2] -> [DMESG-WARN][3] ([fdo#107724]) +1 similar issue
    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u3/igt@[email protected]
    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u3/igt@[email protected]

#### Possible fixes ####

   * igt@gem_ctx_switch@legacy-render:
     - {fi-icl-guc}:       [INCOMPLETE][4] ([fdo#107713] / [fdo#111381]) -> [PASS][5]
    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-guc/igt@[email protected]
    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-guc/igt@[email protected]
     - fi-icl-u2:          [INCOMPLETE][6] ([fdo#107713] / [fdo#111381]) -> [PASS][7]
    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u2/igt@[email protected]
    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u2/igt@[email protected]

   * igt@gem_exec_gttfill@basic:
     - {fi-tgl-u}:         [INCOMPLETE][8] ([fdo#111593]) -> [PASS][9]
    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-tgl-u/igt@[email protected]
    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-tgl-u/igt@[email protected]

   * igt@gem_render_tiled_blits@basic:
     - fi-icl-u3:          [DMESG-WARN][10] ([fdo#107724]) -> [PASS][11]
    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u3/igt@[email protected]
    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u3/igt@[email protected]

   * igt@i915_selftest@live_execlists:
     - fi-skl-gvtdvm:      [DMESG-FAIL][12] ([fdo#111108]) -> [PASS][13]
    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html

#### Warnings ####

   * igt@kms_chamelium@hdmi-hpd-fast:
     - fi-kbl-7500u:       [FAIL][14] ([fdo#111096]) -> [FAIL][15] ([fdo#111407])
    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-kbl-7500u/igt@[email protected]
    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-kbl-7500u/igt@[email protected]

   
   {name}: This element is suppressed. This means it is ignored when computing
           the status of the difference (SUCCESS, WARNING, or FAILURE).

   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
   [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
   [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
   [fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
   [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
   [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593

Participating hosts (54 -> 46)
------------------------------

   Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

   * CI: CI-20190529 -> None
   * Linux: CI_DRM_6861 -> Patchwork_14342

   CI-20190529: 20190529
   CI_DRM_6861: 32c81a3173640f165510de65b8e4137aa049b33f @ git://anongit.freedesktop.org/gfx-ci/linux
   IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_14342: ec71271e3802895ae608065d4914d63157adae2c @ git://anongit.freedesktop.org/gfx-ci/linux
Quoted 6 lines

== Linux commits ==

ec71271e3802 drm/i915: Make pm_notify take intel_gt f3e26c80db02 drm/i915: Avoid round-trip via i915 in intel_gt_park 98290456e271 drm/i915: Make wait_for_timelines take struct intel_gt 4144570a45a2 drm/i915: Move GT init to intel_gt.c

I've pushed these four, thanks for the review. Now lets see if there are some other easy pickings..

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx