Skip to contentSkip to conversation

mm/mmap.c: remove a never trigger warning in __vma_adjust()

PATCH New Wei Yang 1 participant 1 message Sep 12, 2019

Subsystems (2)
Memory management Memory mapping
lore
Share & tools
lore

Wei Yang

author
#0 lore raw

PATCH 1/1 mm/mmap.c: remove a never trigger warning in __vma_adjust()

The upper level of "if" makes sure (end >= next->vm_end), which means there are only two possibilities:

1) end == next->vm_end
2) end > next->vm_end

remove_next is assigned to be (1 + end > next->vm_end). This means if remove_next is 1, end must equal to next->vm_end.

The VM_WARN_ON will never trigger.

Signed-off-by Wei Yang <[email protected]>
---
 mm/mmap.c | 2 --
 1 file changed, 2 deletions(-)
mm/mmap.c +0 -2
index 907939690a30..18ef68f00f51 100644
@@ -738,8 +738,6 @@ int __vma_adjust(struct vm_area_struct *vma, unsigned long start,
 				remove_next = 1 + (end > next->vm_end);
 				VM_WARN_ON(remove_next == 2 &&
 					   end != next->vm_next->vm_end);
-				VM_WARN_ON(remove_next == 1 &&
-					   end != next->vm_end);
 				/* trim end to next, for case 6 first pass */
 				end = next->vm_end;
 			}
Signature · 1 line
2.17.1