Staging: exfat: Avoid use of strcpy
PATCH v5 1/1 Staging: exfat: Avoid use of strcpy
Use strscpy instead of strcpy in exfat_core.c, and add a check for length that will return already known FFS_INVALIDPATH.
Suggested-by Rasmus Villemoes <[email protected]>
Signed-off-by Sandro Volery <[email protected]>
---
v5: Fixed some whitespaces
v4: Replaced strlen check
v3: Failed to replace check
v2: Forgot to replace strlen check
v1: original patch
drivers/staging/exfat/exfat_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/exfat/exfat_core.c +1 -3
@@ -2961,11 +2961,9 @@ s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir,struct fs_info_t *p_fs = &(EXFAT_SB (sb)->fs_info);struct file_id_t *fid = &(EXFAT_I (inode)->fid); -if (strlen (path) >= (MAX_NAME_LENGTH *MAX_CHARSET_SIZE )) +if (strscpy (name_buf, path,sizeof (name_buf)) <0 )return FFS_INVALIDPATH ; -strcpy (name_buf, path); -nls_cstring_to_uniname (sb, p_uniname, name_buf, &lossy);if (lossy)return FFS_INVALIDPATH ;
Signature · 1 line
2.23.0
Quoted 6 lines · Dan Carpenter
You did it. Well done. :P
Reviewed-by Dan Carpenter <[email protected]>
Thanks :D Had some issues with my git configuration setting up a home workstation but now it is all fine