KVM: PPC: Book3S HV: Implement LPCR[AIL]=3 mode for injected interrupts
Subsystems (2)
Nicholas Piggin
reviewerPATCH v2 4/5 KVM: PPC: Book3S HV: Implement LPCR[AIL]=3 mode for injected interrupts
kvmppc_inject_interrupt does not implement LPCR[AIL]!=0 modes, which can result in the guest receiving interrupts as if LPCR[AIL]=0 contrary to the ISA.
In practice, Linux guests cope with this deviation, but it should be fixed.
Signed-off-by Nicholas Piggin <[email protected]>
--- arch/powerpc/kvm/book3s_hv_builtin.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
arch/powerpc/kvm/book3s_hv_builtin.c +14 -0
@@ -792,6 +792,20 @@ static void inject_interrupt(struct kvm_vcpu *vcpu, int vec, u64 srr1_flags)else new_msr |= msr &MSR_TS_MASK ; +/* +* LPCR[AIL]=2 deliveries are not supported. +* +* AIL does not apply to SRESET, MCE, or HMI (which is never +* delivered to the guest). +*/ +if (vec !=BOOK3S_INTERRUPT_SYSTEM_RESET && + vec !=BOOK3S_INTERRUPT_MACHINE_CHECK && + (vcpu->arch.vcore->lpcr &LPCR_AIL ) =LPCR_AIL_3 && + (msr & (MSR_IR |MSR_DR )) = (MSR_IR |MSR_DR ) ) { + new_msr |=MSR_IR |MSR_DR ; + new_pc +=0xC000000000004000ULL ; + } +kvmppc_set_srr0 (vcpu, pc);kvmppc_set_srr1 (vcpu, (msr &SRR1_MSR_BITS ) | srr1_flags);kvmppc_set_pc (vcpu, new_pc);
Signature · 1 line
2.23.0