i2c: qup: remove explicit conversion to boolean
PATCH 1/3 i2c: qup: remove explicit conversion to boolean
Relational and logical operators evaluate to bool, explicit conversion is overly verbose and unneeded.
Found using - Coccinelle (http://coccinelle.lip6.fr)
Signed-off-by Saiyam Doshi <[email protected]>
--- drivers/i2c/busses/i2c-qup.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/i2c/busses/i2c-qup.c +6 -8
@@ -961,10 +961,8 @@ static void qup_i2c_conf_v1(struct qup_i2c_dev *qup)u32 qup_config =I2C_MINI_CORE |I2C_N_VAL ;u32 io_mode =QUP_REPACK_EN ; - blk->is_tx_blk_mode = - blk->total_tx_len > qup->out_fifo_sz ? true : false; - blk->is_rx_blk_mode = - blk->total_rx_len > qup->in_fifo_sz ? true : false; + blk->is_tx_blk_mode = blk->total_tx_len > qup->out_fifo_sz; + blk->is_rx_blk_mode = blk->total_rx_len > qup->in_fifo_sz;if (blk->is_tx_blk_mode) { io_mode |=QUP_OUTPUT_BLK_MODE ;
@@ -1532,10 +1530,10 @@ qup_i2c_determine_mode_v2(struct qup_i2c_dev *qup, (total_len > qup->out_fifo_sz || total_len > qup->in_fifo_sz)) { qup->use_dma = true; } else { - qup->blk.is_tx_blk_mode = max_tx_len > qup->out_fifo_sz - -QUP_MAX_TAGS_LEN ? true : false; - qup->blk.is_rx_blk_mode = max_rx_len > qup->in_fifo_sz - -READ_RX_TAGS_LEN ? true : false; + qup->blk.is_tx_blk_mode = + max_tx_len > qup->out_fifo_sz -QUP_MAX_TAGS_LEN ; + qup->blk.is_rx_blk_mode = + max_rx_len > qup->in_fifo_sz -READ_RX_TAGS_LEN ; }return 0 ;
--
2.20.1
Quoted 1 line
Found using - Coccinelle (http://coccinelle.lip6.fr)
Can a tag like “Generated by: scripts/coccinelle/misc/boolconv.cocci” be more helpful for this change description?
Regards,
Markus
Quoted 4 lines · Markus Elfring
Quoted 1 line
Found using - Coccinelle (http://coccinelle.lip6.fr)
Can a tag like “Generated by: scripts/coccinelle/misc/boolconv.cocci” be more helpful for this change description?
Yes, will do.
-Saiyam