i2c: qup: Use devm_platform_ioremap_resource helper
PATCH 3/3 i2c: qup: Use devm_platform_ioremap_resource helper
Use devm_platform_ioremap_resource helper which wraps platform_get_resource() and devm_ioremap_resource() together.
The semantic patch that makes this report is available in scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.
Found using - http://coccinelle.lip6.fr/
--- drivers/i2c/busses/i2c-qup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/i2c/busses/i2c-qup.c +1 -3
@@ -1663,7 +1663,6 @@ static int qup_i2c_probe(struct platform_device *pdev)static const int blk_sizes[] = {4 ,16 ,32 };struct qup_i2c_dev *qup;unsigned long one_bit_t; -struct resource *res;u32 io_mode, hw_ver, size;int ret, fs_div, hs_div;u32 src_clk_freq =DEFAULT_SRC_CLK ;
@@ -1760,8 +1759,7 @@ static int qup_i2c_probe(struct platform_device *pdev)return -EINVAL ; } - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - qup->base =devm_ioremap_resource (qup->dev, res); + qup->base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (qup->base))return PTR_ERR (qup->base);
--
2.20.1
Quoted 2 lines
Use
devm_platform_ioremap_resourcehelper which wrapsplatform_get_resource()anddevm_ioremap_resource()together.
Can a wording like “Simplify this function implementation by using a known wrapper function.” be nicer for this change description?
Quoted 4 lines
The semantic patch that makes this report is available in
scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.Found using - http://coccinelle.lip6.fr/
Can a tag like “Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci” be more helpful than the other description variant?
Regards,
Markus
Quoted 5 lines · Markus Elfring
Quoted 2 lines
Use
devm_platform_ioremap_resourcehelper which wrapsplatform_get_resource()anddevm_ioremap_resource()together.Can a wording like “Simplify this function implementation by using a known wrapper function.” be nicer for this change description?
Okay. I will change as actual change and changelog is almost similar :)
Quoted 7 lines
Quoted 4 lines
The semantic patch that makes this report is available in
scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.Found using - http://coccinelle.lip6.fr/
Can a tag like “Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci” be more helpful than the other description variant?
will update this in changelog and resend this series.
-Saiyam