Skip to contentSkip to conversation

armv8: ls1028a: add more personalities support

PATCH Superseded Yuantian Tang 2 participants 6 messages Sep 18, 2019 – Oct 22, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 armv8: ls1028a: add more personalities support

Add LS1027A, LS1018A and LS1017A personalities support to LS1028A processor soc family.

LS1028A processor is the prime personality of LS1028A soc family. LS1027A processor is a lower funtionality version of QorIQ LS1028A which does not support the multimedia subsystems, such as LCD controller, GPU, and eDP PHY.
The QorIQ LS1018A and LS1017A are low power versions of the QorIQ LS1028A and LS1027A processors, respectively which integrate single 64-bit Arm A72 core.

---
v2:
- refine description

 arch/arm/cpu/armv8/fsl-layerscape/cpu.c        | 3 +++
 arch/arm/include/asm/arch-fsl-layerscape/soc.h | 3 +++
 2 files changed, 6 insertions(+)
arch/arm/cpu/armv8/fsl-layerscape/cpu.c +3 -0
index 3e2a24fe80..dee96afe2d 100644
@@ -58,6 +58,9 @@ static struct cpu_type cpu_type_list[] = {
 	CPU_TYPE_ENTRY(LS1026A, LS1026A, 2),
 	CPU_TYPE_ENTRY(LS2040A, LS2040A, 4),
 	CPU_TYPE_ENTRY(LS1012A, LS1012A, 1),
+	CPU_TYPE_ENTRY(LS1017A, LS1017A, 1),
+	CPU_TYPE_ENTRY(LS1018A, LS1018A, 1),
+	CPU_TYPE_ENTRY(LS1027A, LS1027A, 2),
 	CPU_TYPE_ENTRY(LS1028A, LS1028A, 2),
 	CPU_TYPE_ENTRY(LS1088A, LS1088A, 8),
 	CPU_TYPE_ENTRY(LS1084A, LS1084A, 8),
arch/arm/include/asm/arch-fsl-layerscape/soc.h +0 -0
arch/arm/include/asm/arch-fsl-layerscape/soc.h +3 -0
@@ -83,6 +83,9 @@ enum boot_src get_boot_src(void);
 /* LS1043A/LS1023A 23x23 package silicon has different value of VAR_PER */
 #define SVR_LS1043A_P23		0x879202
 #define SVR_LS1023A_P23		0x87920A
+#define SVR_LS1017A		0x870B24
+#define SVR_LS1018A		0x870B20
+#define SVR_LS1027A		0x870B04
 #define SVR_LS1028A		0x870B00
 #define SVR_LS1046A		0x870700
 #define SVR_LS1026A		0x870708
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 armv8: ls1028a: add more personalities support

Quoted 9 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Yuantian Tang
Sent: Wednesday, September 18, 2019 2:21 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Please update subject to be more specific about Soc personalities. Something like
armv8: ls1028a: add LS1027A, LS1018A, LS1017A support you can skip this line in description

--priyankajain

Quoted 61 lines

Add LS1027A, LS1018A and LS1017A personalities support to LS1028A processor soc family.

LS1028A processor is the prime personality of LS1028A soc family. LS1027A processor is a lower funtionality version of QorIQ LS1028A which does not support the multimedia subsystems, such as LCD controller, GPU, and eDP PHY.
The QorIQ LS1018A and LS1017A are low power versions of the QorIQ LS1028A and LS1027A processors, respectively which integrate single 64-bit Arm A72 core.

---
v2:
- refine description
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 +++
arch/arm/include/asm/arch-fsl-layerscape/soc.h | 3 +++

2 files changed, 6 insertions(+)
arch/arm/cpu/armv8/fsl-layerscape/cpu.c +3 -0
index 3e2a24fe80..dee96afe2d 100644
@@ -58,6 +58,9 @@ static struct cpu_type cpu_type_list[] = {
 	CPU_TYPE_ENTRY(LS1026A, LS1026A, 2),
 	CPU_TYPE_ENTRY(LS2040A, LS2040A, 4),
 	CPU_TYPE_ENTRY(LS1012A, LS1012A, 1),
+	CPU_TYPE_ENTRY(LS1017A, LS1017A, 1),
+	CPU_TYPE_ENTRY(LS1018A, LS1018A, 1),
+	CPU_TYPE_ENTRY(LS1027A, LS1027A, 2),
 	CPU_TYPE_ENTRY(LS1028A, LS1028A, 2),
 	CPU_TYPE_ENTRY(LS1088A, LS1088A, 8),
 	CPU_TYPE_ENTRY(LS1084A, LS1084A, 8),
arch/arm/include/asm/arch-fsl-layerscape/soc.h +3 -1
@@ -83,6 +83,9 @@ enum boot_src get_boot_src(void);
 /* LS1043A/LS1023A 23x23 package silicon has different value of VAR_PER */
 #define SVR_LS1043A_P23		0x879202
 #define SVR_LS1023A_P23		0x87920A
+#define SVR_LS1017A		0x870B24
+#define SVR_LS1018A		0x870B20
+#define SVR_LS1027A		0x870B04
 #define SVR_LS1028A		0x870B00
 #define SVR_LS1046A		0x870700
 #define SVR_LS1026A		0x870708
--

2.17.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.de
nx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7Cpriyanka.jain%40nxp.com%7Cad5af7711fa6403 9450208d73c16cc16%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C 637043940922465590&amp;sdata=dtSR0EQhGhJYBzhKAOWWGCMRbxYax%2F uuJmKY%2FKAhQBY%3D&amp;reserved=0

author
#2 lore raw

PATCH v2 1/1 armv8: ls1028a: add more personalities support

Hi Priyanka,

Please see my reply inline.

Quoted 18 lines

-----Original Message-----
From: Priyanka Jain
Sent: 2019年9月25日 13:05
To: Andy Tang <[email protected]>; Priyanka Jain <[email protected]>
Cc: Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Quoted 8 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Yuantian Tang
Sent: Wednesday, September 18, 2019 2:21 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Quoted 4 lines

Please update subject to be more specific about Soc personalities. Something like
armv8: ls1028a: add LS1027A, LS1018A, LS1017A support you can skip this line in description

Any reason it must be put in patch subject?

BR,
Andy

Quoted 68 lines

--priyankajain

Quoted 40 lines

Add LS1027A, LS1018A and LS1017A personalities support to LS1028A processor soc family.

LS1028A processor is the prime personality of LS1028A soc family. LS1027A processor is a lower funtionality version of QorIQ LS1028A which does not support the multimedia subsystems, such as LCD controller, GPU, and eDP PHY.
The QorIQ LS1018A and LS1017A are low power versions of the QorIQ LS1028A and LS1027A processors, respectively which integrate single 64-bit Arm A72 core.

---
v2:
- refine description
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 +++
arch/arm/include/asm/arch-fsl-layerscape/soc.h | 3 +++

2 files changed, 6 insertions(+)
arch/arm/cpu/armv8/fsl-layerscape/cpu.c +3 -0
index 3e2a24fe80..dee96afe2d 100644
@@ -58,6 +58,9 @@ static struct cpu_type cpu_type_list[] = {
 	CPU_TYPE_ENTRY(LS1026A, LS1026A, 2),
 	CPU_TYPE_ENTRY(LS2040A, LS2040A, 4),
 	CPU_TYPE_ENTRY(LS1012A, LS1012A, 1),
+	CPU_TYPE_ENTRY(LS1017A, LS1017A, 1),
+	CPU_TYPE_ENTRY(LS1018A, LS1018A, 1),
+	CPU_TYPE_ENTRY(LS1027A, LS1027A, 2),
 	CPU_TYPE_ENTRY(LS1028A, LS1028A, 2),
 	CPU_TYPE_ENTRY(LS1088A, LS1088A, 8),
 	CPU_TYPE_ENTRY(LS1084A, LS1084A, 8),

arch/arm/include/asm/arch-fsl-layerscape/soc.h enum boot_src get_boot_src(void); · line 83

Quoted 1 line
arch/arm/include/asm/arch-fsl-layerscape/soc.h +0 -0
@@ -83,6 +83,9 @@ enum boot_src get_boot_src(void);
 /* LS1043A/LS1023A 23x23 package silicon has different value of VAR_PER

*/

Quoted 11 lines
arch/arm/include/asm/arch-fsl-layerscape/soc.h +3 -1
 #define SVR_LS1043A_P23		0x879202
 #define SVR_LS1023A_P23		0x87920A
+#define SVR_LS1017A		0x870B24
+#define SVR_LS1018A		0x870B20
+#define SVR_LS1027A		0x870B04
 #define SVR_LS1028A		0x870B00
 #define SVR_LS1046A		0x870700
 #define SVR_LS1026A		0x870708
--

2.17.1

Quoted 7 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists
.de
nx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7Cpriyanka.jain%40nxp.com%7Cad5af7711fa64

03

Quoted 1 line

9450208d73c16cc16%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%

7C

Quoted 1 line

637043940922465590&amp;sdata=dtSR0EQhGhJYBzhKAOWWGCMRbxYax

%2F

Quoted 1 line

uuJmKY%2FKAhQBY%3D&amp;reserved=0

#3 lore raw

PATCH v2 1/1 armv8: ls1028a: add more personalities support

Quoted 34 lines

-----Original Message-----
From: Andy Tang
Sent: Wednesday, September 25, 2019 11:06 AM
To: Priyanka Jain <[email protected]>
Cc: u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Hi Priyanka,

Please see my reply inline.

Quoted 20 lines

-----Original Message-----
From: Priyanka Jain
Sent: 2019年9月25日 13:05
To: Andy Tang <[email protected]>; Priyanka Jain <[email protected]>
Cc: Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Quoted 9 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Yuantian Tang
Sent: Wednesday, September 18, 2019 2:21 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Quoted 5 lines
Quoted 4 lines

Please update subject to be more specific about Soc personalities. Something like
armv8: ls1028a: add LS1027A, LS1018A, LS1017A support you can skip this line in description

Any reason it must be put in patch subject?

It’s a suggestion as subject are supposed to specific summary about the content of patch "Add more personalities" is a bit vague
--priyankajain

Quoted 74 lines

BR,
Andy

Quoted 71 lines

--priyankajain

Quoted 41 lines

Add LS1027A, LS1018A and LS1017A personalities support to LS1028A processor soc family.

LS1028A processor is the prime personality of LS1028A soc family. LS1027A processor is a lower funtionality version of QorIQ LS1028A which does not support the multimedia subsystems, such as LCD controller, GPU, and eDP PHY.
The QorIQ LS1018A and LS1017A are low power versions of the QorIQ LS1028A and LS1027A processors, respectively which integrate single 64-bit Arm A72 core.

---
v2:
- refine description
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 +++
arch/arm/include/asm/arch-fsl-layerscape/soc.h | 3 +++

2 files changed, 6 insertions(+)
arch/arm/cpu/armv8/fsl-layerscape/cpu.c +3 -0
index 3e2a24fe80..dee96afe2d 100644
@@ -58,6 +58,9 @@ static struct cpu_type cpu_type_list[] = {
 	CPU_TYPE_ENTRY(LS1026A, LS1026A, 2),
 	CPU_TYPE_ENTRY(LS2040A, LS2040A, 4),
 	CPU_TYPE_ENTRY(LS1012A, LS1012A, 1),
+	CPU_TYPE_ENTRY(LS1017A, LS1017A, 1),
+	CPU_TYPE_ENTRY(LS1018A, LS1018A, 1),
+	CPU_TYPE_ENTRY(LS1027A, LS1027A, 2),
 	CPU_TYPE_ENTRY(LS1028A, LS1028A, 2),
 	CPU_TYPE_ENTRY(LS1088A, LS1088A, 8),
 	CPU_TYPE_ENTRY(LS1084A, LS1084A, 8), diff --git

a/arch/arm/include/asm/arch-fsl-layerscape/soc.h
b/arch/arm/include/asm/arch-fsl-layerscape/soc.h

arch/arm/include/asm/arch-fsl-layerscape/soc.h +0 -0
@@ -83,6 +83,9 @@ enum boot_src get_boot_src(void);
 /* LS1043A/LS1023A 23x23 package silicon has different value of
Quoted 1 line

VAR_PER

*/

Quoted 11 lines

#define SVR_LS1043A_P23 0x879202
#define SVR_LS1023A_P23 0x87920A

arch/arm/include/asm/arch-fsl-layerscape/soc.h +3 -0
+#define SVR_LS1017A		0x870B24
+#define SVR_LS1018A		0x870B20
+#define SVR_LS1027A		0x870B04

#define SVR_LS1028A 0x870B00
#define SVR_LS1046A 0x870700
#define SVR_LS1026A 0x870708
--
2.17.1

Quoted 8 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
ts
.de
nx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7Cpriyanka.jain%40nxp.com%7Cad5af7711fa64

03

9450208d73c16cc16%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% 7C

Quoted 1 line

637043940922465590&amp;sdata=dtSR0EQhGhJYBzhKAOWWGCMRbxYax

%2F

Quoted 1 line

uuJmKY%2FKAhQBY%3D&amp;reserved=0

author
#4 lore raw

PATCH v2 1/1 armv8: ls1028a: add more personalities support

Hi Priyanka,

Please see my reply inline.

Quoted 42 lines

-----Original Message-----
From: Priyanka Jain
Sent: 2019年9月25日 13:43
To: Andy Tang <[email protected]>
Cc: u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Quoted 32 lines

-----Original Message-----
From: Andy Tang
Sent: Wednesday, September 25, 2019 11:06 AM
To: Priyanka Jain <[email protected]>
Cc: u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Hi Priyanka,

Please see my reply inline.

Quoted 20 lines

-----Original Message-----
From: Priyanka Jain
Sent: 2019年9月25日 13:05
To: Andy Tang <[email protected]>; Priyanka Jain <[email protected]>
Cc: Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: RE: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Quoted 9 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Yuantian Tang
Sent: Wednesday, September 18, 2019 2:21 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

Please update subject to be more specific about Soc personalities. Something like
armv8: ls1028a: add LS1027A, LS1018A, LS1017A support you can skip this line in description

Any reason it must be put in patch subject?

It’s a suggestion as subject are supposed to specific summary about the content of patch "Add more personalities" is a bit vague --priyankajain

We can put the "more personalities" in subject or in description.
Either way is ok. I prefer to put it in description. Subject should be as concise as possible.

Thanks for your suggestion.
BR,
Andy

Quoted 78 lines
Quoted 59 lines

BR,
Andy

Quoted 56 lines

--priyankajain

Quoted 41 lines

Add LS1027A, LS1018A and LS1017A personalities support to LS1028A processor soc family.

LS1028A processor is the prime personality of LS1028A soc family. LS1027A processor is a lower funtionality version of QorIQ LS1028A which does not support the multimedia subsystems, such as LCD controller, GPU, and eDP PHY.
The QorIQ LS1018A and LS1017A are low power versions of the QorIQ LS1028A and LS1027A processors, respectively which integrate single 64-bit Arm A72 core.

---
v2:
- refine description
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 +++
arch/arm/include/asm/arch-fsl-layerscape/soc.h | 3 +++

2 files changed, 6 insertions(+)
arch/arm/cpu/armv8/fsl-layerscape/cpu.c +3 -0
index 3e2a24fe80..dee96afe2d 100644
@@ -58,6 +58,9 @@ static struct cpu_type cpu_type_list[] = {
 	CPU_TYPE_ENTRY(LS1026A, LS1026A, 2),
 	CPU_TYPE_ENTRY(LS2040A, LS2040A, 4),
 	CPU_TYPE_ENTRY(LS1012A, LS1012A, 1),
+	CPU_TYPE_ENTRY(LS1017A, LS1017A, 1),
+	CPU_TYPE_ENTRY(LS1018A, LS1018A, 1),
+	CPU_TYPE_ENTRY(LS1027A, LS1027A, 2),
 	CPU_TYPE_ENTRY(LS1028A, LS1028A, 2),
 	CPU_TYPE_ENTRY(LS1088A, LS1088A, 8),
 	CPU_TYPE_ENTRY(LS1084A, LS1084A, 8), diff --git

a/arch/arm/include/asm/arch-fsl-layerscape/soc.h
b/arch/arm/include/asm/arch-fsl-layerscape/soc.h

arch/arm/include/asm/arch-fsl-layerscape/soc.h +0 -0
@@ -83,6 +83,9 @@ enum boot_src get_boot_src(void);
 /* LS1043A/LS1023A 23x23 package silicon has different value of
Quoted 1 line

VAR_PER

*/

Quoted 11 lines

#define SVR_LS1043A_P23 0x879202
#define SVR_LS1023A_P23 0x87920A

arch/arm/include/asm/arch-fsl-layerscape/soc.h +3 -0
+#define SVR_LS1017A		0x870B24
+#define SVR_LS1018A		0x870B20
+#define SVR_LS1027A		0x870B04

#define SVR_LS1028A 0x870B00
#define SVR_LS1046A 0x870700
#define SVR_LS1026A 0x870708
--
2.17.1

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fli
s
ts
.de
nx.de%2Flistinfo%2Fu- boot&amp;data=02%7C01%7Cpriyanka.jain%40nxp.com%7Cad5af7711f

a64

Quoted 3 lines
Quoted 3 lines

03

9450208d73c16cc16%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0

%

Quoted 2 lines
Quoted 2 lines

7C

Quoted 1 line

637043940922465590&amp;sdata=dtSR0EQhGhJYBzhKAOWWGCMRbxY

ax

Quoted 2 lines
Quoted 2 lines

%2F

Quoted 1 line

uuJmKY%2FKAhQBY%3D&amp;reserved=0

#5 lore raw

PATCH v2 1/1 armv8: ls1028a: add more personalities support

In reply to Yuantian Tang
Quoted 20 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Yuantian Tang
Sent: Wednesday, September 18, 2019 2:21 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: [U-Boot] [PATCH v2] armv8: ls1028a: add more personalities support

Add LS1027A, LS1018A and LS1017A personalities support to LS1028A processor soc family.

LS1028A processor is the prime personality of LS1028A soc family. LS1027A processor is a lower funtionality version of QorIQ LS1028A which does not support the multimedia subsystems, such as LCD controller, GPU, and eDP PHY.
The QorIQ LS1018A and LS1017A are low power versions of the QorIQ LS1028A and LS1027A processors, respectively which integrate single 64-bit Arm A72 core.

Quoted 1 line

<snip>

Slight update in description.
Applied to fsl-qoriq master, awaiting upstream.

Thanks
priyankajain