Skip to contentSkip to conversation

mmc: host: bcm2835: use devm_platform_ioremap_resource wrapper

PATCH In review Saiyam Doshi 2 participants 2 messages Sep 18, 2019 – Oct 3, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: host: bcm2835: use devm_platform_ioremap_resource wrapper

Use devm_platform_ioremap_resource helper which wraps platform_get_resource() and devm_ioremap_resource() together.

Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

---
 drivers/mmc/host/bcm2835.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/mmc/host/bcm2835.c +1 -3
index 148414d7f0c9..99f61fd2a658 100644
@@ -1357,7 +1357,6 @@ static int bcm2835_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct clk *clk;
-	struct resource *iomem;
 	struct bcm2835_host *host;
 	struct mmc_host *mmc;
 	const __be32 *regaddr_p;
@@ -1373,8 +1372,7 @@ static int bcm2835_probe(struct platform_device *pdev)
 	host->pdev = pdev;
 	spin_lock_init(&host->lock);
 
-	iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	host->ioaddr = devm_ioremap_resource(dev, iomem);
+	host->ioaddr = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(host->ioaddr)) {
 		ret = PTR_ERR(host->ioaddr);
 		goto err;
Signature · 1 line
2.20.1
#1 lore raw
Quoted 10 lines · Saiyam Doshi

Use devm_platform_ioremap_resource helper which wraps platform_get_resource() and devm_ioremap_resource() together.

Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

Applied for next, thanks!

Kind regards
Uffe

Quoted 29 lines
---
 drivers/mmc/host/bcm2835.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/mmc/host/bcm2835.c +1 -4
index 148414d7f0c9..99f61fd2a658 100644
@@ -1357,7 +1357,6 @@ static int bcm2835_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct clk *clk;
-       struct resource *iomem;
        struct bcm2835_host *host;
        struct mmc_host *mmc;
        const __be32 *regaddr_p;
@@ -1373,8 +1372,7 @@ static int bcm2835_probe(struct platform_device *pdev)
        host->pdev = pdev;
        spin_lock_init(&host->lock);
 
-       iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       host->ioaddr = devm_ioremap_resource(dev, iomem);
+       host->ioaddr = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(host->ioaddr)) {
                ret = PTR_ERR(host->ioaddr);
                goto err;
--

2.20.1