Skip to contentSkip to conversation

platform/x86: asus-wmi: add ACPI_BATTERY dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Sep 18, 2019 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: asus-wmi: add ACPI_BATTERY dependency

Without this dependency, we can run into a link failure:

drivers/platform/x86/asus-wmi.o: In function `asus_wmi_remove':
asus-wmi.c:(.text+0x430): undefined reference to battery_hook_unregister' drivers/platform/x86/asus-wmi.o: In function asus_wmi_probe':
asus-wmi.c:(.text+0x2c6f): undefined reference to `battery_hook_register'

Fixes 7973353e92ee ("platform/x86: asus-wmi: Refactor charge threshold to use the battery hooking API")
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/Kconfig +1 -0
index 1b67bb578f9f..d81de3f4f72e 100644
@@ -680,6 +680,7 @@ config ASUS_WMI
 	depends on RFKILL || RFKILL = n
 	depends on HOTPLUG_PCI
 	depends on ACPI_VIDEO || ACPI_VIDEO = n
+	depends on ACPI_BATTERY
 	select INPUT_SPARSEKMAP
 	select LEDS_CLASS
 	select NEW_LEDS
Signature · 1 line
2.20.0
#1 lore raw
Quoted 8 lines · Arnd Bergmann

Without this dependency, we can run into a link failure:

drivers/platform/x86/asus-wmi.o: In function `asus_wmi_remove':
asus-wmi.c:(.text+0x430): undefined reference to battery_hook_unregister' drivers/platform/x86/asus-wmi.o: In function asus_wmi_probe':
asus-wmi.c:(.text+0x2c6f): undefined reference to `battery_hook_register'

Thanks, the similar is in my tree. I will send it later.

Quoted 21 lines
Fixes 7973353e92ee ("platform/x86: asus-wmi: Refactor charge threshold to use the battery hooking API")
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/Kconfig +1 -1
index 1b67bb578f9f..d81de3f4f72e 100644
@@ -680,6 +680,7 @@ config ASUS_WMI
        depends on RFKILL || RFKILL = n
        depends on HOTPLUG_PCI
        depends on ACPI_VIDEO || ACPI_VIDEO = n
+       depends on ACPI_BATTERY
        select INPUT_SPARSEKMAP
        select LEDS_CLASS
        select NEW_LEDS
--

2.20.0

Signature · 2 lines
With Best Regards,
Andy Shevchenko