Skip to contentSkip to conversation

MAINTAINERS: Update Allwinner DRM drivers entry

PATCH In review Maxime Ripard 4 participants 11 messages Sep 19, 2019 – Sep 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 MAINTAINERS: Update Allwinner DRM drivers entry

The DRM drivers are more than about the A10 now, so let's make the entry name a bit more generic.

Also, Chen-Yu has been a de-facto maintainer for the DRM driver for a while, is a maintainer of the Allwinner platform for an even longer time, and has drm-misc commit access. Let's make it formal and add him as a maintainer.

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index b2326dece28e..54e222e1d0d6 100644
@@ -5352,8 +5352,9 @@ F:	include/drm/drm*
 F:	include/uapi/drm/drm*
 F:	include/linux/vga*
 
-DRM DRIVERS FOR ALLWINNER A10
+DRM DRIVERS FOR ALLWINNER SOCS
 M:	Maxime Ripard <[email protected]>
+M:	Chen-Yu Tsai <[email protected]>
 L:	[email protected]
 S:	Supported
 F:	drivers/gpu/drm/sun4i/
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH 2/2 MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

The newer Allwinner SoCs have a different layers controller than the older ones. Jernej wrote that support and has been reviewing patches for a while now, so let's make him a formal reviewer.

---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +9 -0
index 54e222e1d0d6..fae328f06c17 100644
@@ -5361,6 +5361,15 @@ F:	drivers/gpu/drm/sun4i/
 F:	Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 
+DRM DRIVER FOR ALLWINNER DE2 ENGINE
+M:	Maxime Ripard <[email protected]>
+M:	Chen-Yu Tsai <[email protected]>
+R:	Jernej Škrabec <[email protected]>
+L:	[email protected]
+S:	Supported
+F:	drivers/gpu/drm/sun4i/sun8i*
+T:	git git://anongit.freedesktop.org/drm/drm-misc
+
 DRM DRIVERS FOR AMLOGIC SOCS
 M:	Neil Armstrong <[email protected]>
 L:	[email protected]
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v1 1/2
#9 lore raw
In reply to Maxime Ripard
Quoted 7 lines · Maxime Ripard

The DRM drivers are more than about the A10 now, so let's make the entry name a bit more generic.

Also, Chen-Yu has been a de-facto maintainer for the DRM driver for a while, is a maintainer of the Allwinner platform for an even longer time, and has drm-misc commit access. Let's make it formal and add him as a

Although I have an account, I haven't actually tried if I have commit access. I also don't think my account was properly migrated over to GitLab, as I had to re-create one.

Quoted 3 lines

maintainer.

Quoted 20 lines
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index b2326dece28e..54e222e1d0d6 100644
@@ -5352,8 +5352,9 @@ F:        include/drm/drm*
 F:     include/uapi/drm/drm*
 F:     include/linux/vga*
 
-DRM DRIVERS FOR ALLWINNER A10
+DRM DRIVERS FOR ALLWINNER SOCS
 M:     Maxime Ripard <[email protected]>
+M:     Chen-Yu Tsai <[email protected]>
 L:     [email protected]
 S:     Supported
 F:     drivers/gpu/drm/sun4i/
--
Quoted 2 lines

2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

In reply to Maxime Ripard

Dne četrtek, 19. september 2019 ob 19:30:20 CEST je Maxime Ripard napisal(a):

Quoted 14 lines

The newer Allwinner SoCs have a different layers controller than the older ones. Jernej wrote that support and has been reviewing patches for a while now, so let's make him a formal reviewer.

---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +0 -0
index 54e222e1d0d6..fae328f06c17 100644

MAINTAINERS F: drivers/gpu/drm/sun4i/ · line 5364

Quoted 4 lines
MAINTAINERS +1 -0
@@ -5361,6 +5361,15 @@ F:	drivers/gpu/drm/sun4i/
 F:	Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 
+DRM DRIVER FOR ALLWINNER DE2 ENGINE

Please make that DE2 and DE3 engine, they share almost all code.

MAINTAINERS F: drivers/gpu/drm/sun4i/ · line 5367

Quoted 3 lines
MAINTAINERS +3 -0
+M:	Maxime Ripard <[email protected]>
+M:	Chen-Yu Tsai <[email protected]>
+R:	Jernej Škrabec <[email protected]>

Please make that "S" for consistency with other entry.

With that:

MAINTAINERS F: drivers/gpu/drm/sun4i/ · line 5375

Quoted 8 lines
MAINTAINERS +5 -0
+L:	[email protected]
+S:	Supported
+F:	drivers/gpu/drm/sun4i/sun8i*
+T:	git git://anongit.freedesktop.org/drm/drm-misc
+
 DRM DRIVERS FOR AMLOGIC SOCS
 M:	Neil Armstrong <[email protected]>
 L:	[email protected]

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#10 lore raw
In reply to Chen-Yu Tsai
Quoted 6 lines · Chen-Yu Tsai
Quoted 4 lines · Maxime Ripard

The DRM drivers are more than about the A10 now, so let's make the entry name a bit more generic.

Quoted 7 lines
Quoted 3 lines

Also, Chen-Yu has been a de-facto maintainer for the DRM driver for a while, is a maintainer of the Allwinner platform for an even longer time, and has drm-misc commit access. Let's make it formal and add him as a

Although I have an account, I haven't actually tried if I have commit access. I also don't think my account was properly migrated over to GitLab, as I had to re-create one.

The git repo is still on legacy git fd.o servers, it's not yet migrated over to gitlab.
-Daniel

Quoted 33 lines
Quoted 4 lines

maintainer.

Quoted 20 lines
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index b2326dece28e..54e222e1d0d6 100644
@@ -5352,8 +5352,9 @@ F:        include/drm/drm*
 F:     include/uapi/drm/drm*
 F:     include/linux/vga*
 
-DRM DRIVERS FOR ALLWINNER A10
+DRM DRIVERS FOR ALLWINNER SOCS
 M:     Maxime Ripard <[email protected]>
+M:     Chen-Yu Tsai <[email protected]>
 L:     [email protected]
 S:     Supported
 F:     drivers/gpu/drm/sun4i/
--
Quoted 2 lines

2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw

Re: [PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

In reply to Maxime Ripard
Quoted 6 lines · Maxime Ripard

The newer Allwinner SoCs have a different layers controller than the older ones. Jernej wrote that support and has been reviewing patches for a while now, so let's make him a formal reviewer.

Haz commit rights already, or do we need to fix that? -Daniel

Quoted 31 lines
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +9 -1
index 54e222e1d0d6..fae328f06c17 100644
@@ -5361,6 +5361,15 @@ F:       drivers/gpu/drm/sun4i/
 F:     Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
 T:     git git://anongit.freedesktop.org/drm/drm-misc
 
+DRM DRIVER FOR ALLWINNER DE2 ENGINE
+M:     Maxime Ripard <[email protected]>
+M:     Chen-Yu Tsai <[email protected]>
+R:     Jernej Škrabec <[email protected]>
+L:     [email protected]
+S:     Supported
+F:     drivers/gpu/drm/sun4i/sun8i*
+T:     git git://anongit.freedesktop.org/drm/drm-misc
+
 DRM DRIVERS FOR AMLOGIC SOCS
 M:     Neil Armstrong <[email protected]>
 L:     [email protected]
--

2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#5 lore raw

Re: [PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

Hi

Quoted 9 lines · Daniel Vetter
Quoted 6 lines · Maxime Ripard

The newer Allwinner SoCs have a different layers controller than the older ones. Jernej wrote that support and has been reviewing patches for a while now, so let's make him a formal reviewer.

Haz commit rights already, or do we need to fix that?

He doesn't, as far as I'm remember.

Jernej, do you want to have drm-misc committers rights as well?

Maxime

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw

Re: [PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

Dne petek, 20. september 2019 ob 08:08:20 CEST je Maxime Ripard napisal(a):

Quoted 10 lines

Hi

Quoted 7 lines · Daniel Vetter
Quoted 6 lines · Maxime Ripard

The newer Allwinner SoCs have a different layers controller than the older
ones. Jernej wrote that support and has been reviewing patches for a while
now, so let's make him a formal reviewer.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Haz commit rights already, or do we need to fix that?

He doesn't, as far as I'm remember.

No, I don't.

Quoted 2 lines

Jernej, do you want to have drm-misc committers rights as well?

I would be nice, yes. Thanks!

Best regards,
Jernej

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Re: [PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

In reply to Jernej Škrabec
Quoted 22 lines · Jernej Škrabec

Dne četrtek, 19. september 2019 ob 19:30:20 CEST je Maxime Ripard napisal(a):

Quoted 14 lines

The newer Allwinner SoCs have a different layers controller than the older ones. Jernej wrote that support and has been reviewing patches for a while now, so let's make him a formal reviewer.

---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +0 -0
index 54e222e1d0d6..fae328f06c17 100644

MAINTAINERS F: drivers/gpu/drm/sun4i/ · line 5364

Quoted 4 lines
MAINTAINERS +1 -0
@@ -5361,6 +5361,15 @@ F:	drivers/gpu/drm/sun4i/
 F:	Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 
+DRM DRIVER FOR ALLWINNER DE2 ENGINE

Please make that DE2 and DE3 engine, they share almost all code.

Quoted 8 lines

MAINTAINERS F: drivers/gpu/drm/sun4i/ · line 5367

Quoted 3 lines
MAINTAINERS +3 -0
+M:	Maxime Ripard <[email protected]>
+M:	Chen-Yu Tsai <[email protected]>
+R:	Jernej Škrabec <[email protected]>

Please make that "S" for consistency with other entry.

With that:

Applied both patches, with your suggestions.

Thanks, and welcome to the team :)

Maxime

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw

Re: [PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

In reply to Jernej Škrabec
Quoted 15 lines · Jernej Škrabec

Dne petek, 20. september 2019 ob 08:08:20 CEST je Maxime Ripard napisal(a):

Quoted 14 lines

Hi

Quoted 10 lines · Daniel Vetter
Quoted 7 lines · Maxime Ripard

The newer Allwinner SoCs have a different layers controller than the older
ones. Jernej wrote that support and has been reviewing patches for a while
now, so let's make him a formal reviewer.

Haz commit rights already, or do we need to fix that?

Quoted 8 lines
Quoted 1 line

He doesn't, as far as I'm remember.

No, I don't.

Quoted 2 lines

Jernej, do you want to have drm-misc committers rights as well?

I would be nice, yes. Thanks!

You have everything needed (hopefully) there:
https://drm.pages.freedesktop.org/maintainer-tools/drm-misc.html

Once you have requested the account, please let us know so that we can ack it and move forward in the process.

Maxime

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#8 lore raw

Re: [PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

Dne ponedeljek, 23. september 2019 ob 17:32:53 CEST je Maxime Ripard napisal(a):

Quoted 2 lines · Jernej Škrabec
Quoted 1 line

Dne petek, 20. september 2019 ob 08:08:20 CEST je Maxime Ripard

napisal(a):

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Hi

Quoted 1 line · Daniel Vetter

On Thu, Sep 19, 2019 at 7:30 PM Maxime Ripard <[email protected]>

Quoted 16 lines · wrote:
Quoted 16 lines
Quoted 11 lines
Quoted 9 lines
Quoted 7 lines

The newer Allwinner SoCs have a different layers controller than the older
ones. Jernej wrote that support and has been reviewing patches for a while
now, so let's make him a formal reviewer.

Haz commit rights already, or do we need to fix that?

He doesn't, as far as I'm remember.

No, I don't.

Quoted 1 line

Jernej, do you want to have drm-misc committers rights as well?

Quoted 7 lines
Quoted 1 line

I would be nice, yes. Thanks!

You have everything needed (hopefully) there:
https://drm.pages.freedesktop.org/maintainer-tools/drm-misc.html

Once you have requested the account, please let us know so that we can ack it and move forward in the process.

Here it is: https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/192

Thanks!

Best regards,
Jernej

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel