Skip to contentSkip to conversation

arm: dts: integratorap: Remove top level dma-ranges

RFC PATCH In review Rob Herring 2 participants 2 messages Sep 20, 2019 – Oct 4, 2019 Device tree bindings

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

RFC PATCH 1/1 arm: dts: integratorap: Remove top level dma-ranges

'dma-ranges' at the top level doesn't make sense. 'dma-ranges' implies there is a parent bus node with '#address-cells' and '#size-cells' which is impossible here.

Likely this translation needs to be moved down to sub-nodes that need it.

---
This probably worked due to bugs in dma-ranges address translations (or lack of).

AFAICT, only PCI needs dma-ranges. The TRM says inbound PCI addresses are 1:1. So a translation from child address 0x80000000 to cpu address 0x0 seems wrong. The v3 PCI driver also fails to look at parent nodes for dma-ranges.

 arch/arm/boot/dts/integratorap.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/integratorap.dts +0 -1
index 94d2ff9836d0..198d66181c50 100644
@@ -9,7 +9,6 @@
 / {
 	model = "ARM Integrator/AP";
 	compatible = "arm,integrator-ap";
-	dma-ranges = <0x80000000 0x0 0x80000000>;
 
 	cpus {
 		#address-cells = <1>;
Signature · 1 line
2.20.1
#1 lore raw
Quoted 10 lines · Rob Herring

'dma-ranges' at the top level doesn't make sense. 'dma-ranges' implies there is a parent bus node with '#address-cells' and '#size-cells' which is impossible here.

Likely this translation needs to be moved down to sub-nodes that need it.

Patch applied! I'll get this to ARM SoC with some
other stuff.

Yours,
Linus Walleij