drm/panfrost: Reduce the amount of logs on deferred probe
Subsystems (3)
PATCH v2 1/1 drm/panfrost: Reduce the amount of logs on deferred probe
There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice.
In case of multiple probe tries this would pollute the dmesg.
---
Changes since v1:
1. Remove second error message from calling panfrost_regulator_init().
--- drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/panfrost/panfrost_device.c +4 -4
@@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev) pfdev->regulator =NULL ;if (ret == -ENODEV )return 0 ; -dev_err (pfdev->dev,"failed to get regulator: %d\n" , ret); +if (ret != -EPROBE_DEFER ) +dev_err (pfdev->dev,"failed to get regulator: %d\n" , + ret);return ret; }
@@ -133,10 +135,8 @@ int panfrost_device_init(struct panfrost_device *pfdev) } err =panfrost_regulator_init (pfdev); -if (err) { -dev_err (pfdev->dev,"regulator init failed %d\n" , err); +if (err) goto err_out0; - } err =panfrost_reset_init (pfdev);if (err) {
Signature · 1 line
2.17.1
Quoted 7 lines · Krzysztof Kozlowski
There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice.
In case of multiple probe tries this would pollute the dmesg.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 27 lines
---
Changes since v1:
1. Remove second error message from callingpanfrost_regulator_init().--- drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/panfrost/panfrost_device.c +3
-1@@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev) pfdev->regulator =NULL ;if (ret == -ENODEV )return 0 ; -dev_err (pfdev->dev,"failed to get regulator: %d\n" , ret); +if (ret != -EPROBE_DEFER ) +dev_err (pfdev->dev,"failed to get regulator: %d\n" , + ret);return ret; }@@ -133,10 +135,8 @@ int panfrost_device_init(struct panfrost_device *pfdev) }
drivers/gpu/drm/panfrost/panfrost_device.c int panfrost_device_init(struct panfrost_device *pfdev) · line 142
Quoted 10 lines
drivers/gpu/drm/panfrost/panfrost_device.c +1
-3err =panfrost_regulator_init (pfdev); -if (err) { -dev_err (pfdev->dev,"regulator init failed %d\n" , err); +if (err) goto err_out0; - } err =panfrost_reset_init (pfdev);if (err) {
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel