Skip to contentSkip to conversation

pinctrl: cherryview: restore Strago DMI workaround for all versions

PATCH Applied Dmitry Torokhov 4 participants 4 messages Sep 24, 2019 – Oct 1, 2019

Subsystems (3)
GPIO Pin control Pin controller - Intel
lore
Share & tools
lore

Dmitry Torokhov

author
#0 lore raw

PATCH 1/1 pinctrl: cherryview: restore Strago DMI workaround for all versions

This is essentially a revert of:

e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

because even with 1.1 versions of BIOS there are some pins that are configured as interrupts but not claimed by any driver, and they sometimes fire up and result in interrupt storms that cause touchpad stop functioning and other issues.

Given that we are unlikely to qualify another firmware version for a while it is better to keep the workaround active on all Strago boards.

Reported-by Alex Levin <[email protected]>
Fixes 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
Cc [email protected]
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/pinctrl/intel/pinctrl-cherryview.c +0 -4
index 03ec7a5d9d0b..bf049d1bbb87 100644
@@ -1513,7 +1513,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
 		},
 	},
 	{

@@ -1521,7 +1520,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
 		},
 	},
 	{

@@ -1529,7 +1527,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
 		},
 	},
 	{

@@ -1537,7 +1534,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
 		},
 	},
 	{}
Signature · 5 lines
2.23.0.351.gc4317032e6-goog


-- 
Dmitry
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dmitry Torokhov

This is essentially a revert of:

e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

Quoted 7 lines

because even with 1.1 versions of BIOS there are some pins that are configured as interrupts but not claimed by any driver, and they sometimes fire up and result in interrupt storms that cause touchpad stop functioning and other issues.

Given that we are unlikely to qualify another firmware version for a while it is better to keep the workaround active on all Strago boards.

Reviewed-by Andy Shevchenko <[email protected]>
Quoted 51 lines
Reported-by Alex Levin <[email protected]>
Fixes 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
Cc [email protected]
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/pinctrl/intel/pinctrl-cherryview.c +0 -4
index 03ec7a5d9d0b..bf049d1bbb87 100644
@@ -1513,7 +1513,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
 		},
 	},
 	{

@@ -1521,7 +1520,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
 		},
 	},
 	{

@@ -1529,7 +1527,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
 		},
 	},
 	{

@@ -1537,7 +1534,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
 		},
 	},
 	{}
Signature · 5 lines
2.23.0.351.gc4317032e6-goog


-- 
Dmitry
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Tested-by
#2 lore raw
Quoted 12 lines · Andy Shevchenko
Quoted 10 lines · Dmitry Torokhov

This is essentially a revert of:

e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

because even with 1.1 versions of BIOS there are some pins that are configured as interrupts but not claimed by any driver, and they sometimes fire up and result in interrupt storms that cause touchpad stop functioning and other issues.

Quoted 4 lines
Quoted 2 lines

Given that we are unlikely to qualify another firmware version for a while it is better to keep the workaround active on all Strago boards.

Reviewed-by Andy Shevchenko <[email protected]>
Tested-by Alex Levin <[email protected]>
Quoted 58 lines
Quoted 50 lines
Reported-by Alex Levin <[email protected]>
Fixes 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
Cc [email protected]
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/pinctrl/intel/pinctrl-cherryview.c +0 -5
index 03ec7a5d9d0b..bf049d1bbb87 100644
@@ -1513,7 +1513,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
              .matches = {
                      DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
                      DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
-                     DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
              },
      },
      {

@@ -1521,7 +1520,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
              .matches = {
                      DMI_MATCH(DMI_SYS_VENDOR, "HP"),
                      DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
-                     DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
              },
      },
      {

@@ -1529,7 +1527,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
              .matches = {
                      DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
                      DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
-                     DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
              },
      },
      {

@@ -1537,7 +1534,6 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
              .matches = {
                      DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
                      DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
-                     DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
              },
      },
      {}
--

2.23.0.351.gc4317032e6-goog

Quoted 2 lines

--
Dmitry

--
With Best Regards,
Andy Shevchenko

maintainer Applied
#3 lore raw
In reply to Dmitry Torokhov
Quoted 10 lines · Dmitry Torokhov

This is essentially a revert of:

e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

because even with 1.1 versions of BIOS there are some pins that are configured as interrupts but not claimed by any driver, and they sometimes fire up and result in interrupt storms that cause touchpad stop functioning and other issues.

Quoted 7 lines

Given that we are unlikely to qualify another firmware version for a while it is better to keep the workaround active on all Strago boards.

Reported-by Alex Levin <[email protected]>
Fixes 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
Cc [email protected]
Signed-off-by Dmitry Torokhov <[email protected]>

Applied to intel.git/fixes, thanks!