xfs: avoid unused to_mp() function warning
PATCH 1/1 xfs: avoid unused to_mp() function warning
to_mp() was first introduced with the following commit:
'commit 801cc4e17a34c ("xfs: debug mode forced buffered write failure")'
But the user of to_mp() was removed by below commit:
'commit f8c47250ba46e ("xfs: convert drop_writes to use the errortag mechanism")'
So kernel build with clang throws below warning message:
fs/xfs/xfs_sysfs.c:72:1: warning: unused function 'to_mp' [-Wunused-function] to_mp(struct kobject *kobject)
Hence to_mp() might be removed safely to get rid of warning message.
--- fs/xfs/xfs_sysfs.c | 13 ------------- 1 file changed, 13 deletions(-)
fs/xfs/xfs_sysfs.c +0 -13
@@ -63,19 +63,6 @@ static const struct sysfs_ops xfs_sysfs_ops = { .store = xfs_sysfs_object_store, }; -/* -* xfs_mount kobject. The mp kobject also serves as the per-mount parent object -* that is identified by the fsname under sysfs. -*/ - -static inline struct xfs_mount * -to_mp (struct kobject *kobject) -{ -struct xfs_kobj *kobj =to_kobj (kobject); - - return container_of(kobj, struct xfs_mount, m_kobj); -} -static struct attribute *xfs_mp_attrs[] = {NULL , };
Signature · 1 line
2.6.2
Quoted 9 lines · Austin Kim
to_mp()was first introduced with the following commit:
'commit801cc4e17a34c("xfs: debug mode forced buffered write failure")'But the user of
to_mp()was removed by below commit:
'commitf8c47250ba46e("xfs: convertdrop_writesto use the errortag mechanism")'So kernel build with clang throws below warning message:
Quoted 7 lines
fs/xfs/xfs_sysfs.c:72:1: warning: unused function 'to_mp' [-Wunused-function]to_mp(struct kobject *kobject)Hence
to_mp()might be removed safely to get rid of warning message.Signed-off-by Austin Kim <[email protected]>---
Quoted 30 lines
fs/xfs/xfs_sysfs.c | 13 ------------- 1 file changed, 13 deletions(-)fs/xfs/xfs_sysfs.c +0
-13@@ -63,19 +63,6 @@ static const struct sysfs_ops xfs_sysfs_ops = { .store = xfs_sysfs_object_store, }; -/* -* xfs_mount kobject. The mp kobject also serves as the per-mount parent object -* that is identified by the fsname under sysfs. -*/ - -static inline struct xfs_mount * -to_mp (struct kobject *kobject) -{ -struct xfs_kobj *kobj =to_kobj (kobject); - - return container_of(kobj, struct xfs_mount, m_kobj); -} -static struct attribute *xfs_mp_attrs[] = {NULL , };Signature · 1 line
2.6.2