watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
PATCH 1/1 watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
Normally, the watchdog is disabled when /dev/watchdog is closed, but if CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog should remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT is defined.
--- drivers/watchdog/intel-mid_wdt.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/intel-mid_wdt.c +1 -0
@@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev) wdt_dev->timeout =MID_WDT_DEFAULT_TIMEOUT ; wdt_dev->parent = dev; +watchdog_set_nowayout (wdt_dev,WATCHDOG_NOWAYOUT );watchdog_set_drvdata (wdt_dev, dev); ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
Signature · 1 line
2.23.0
Quoted 8 lines · Andy Shevchenko
Normally, the watchdog is disabled when
/dev/watchdogis closed, but ifCONFIG_WATCHDOG_NOWAYOUTis defined, then it means that the watchdog should remain enabled. So we should keep it enabled ifCONFIG_WATCHDOG_NOWAYOUTis defined.Reported-by Razvan Becheriu <[email protected]>Cc Ferry Toth <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Quoted 17 lines
--- drivers/watchdog/intel-mid_wdt.c | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/intel-mid_wdt.c +1
-0@@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev) wdt_dev->timeout =MID_WDT_DEFAULT_TIMEOUT ; wdt_dev->parent = dev; +watchdog_set_nowayout (wdt_dev,WATCHDOG_NOWAYOUT );watchdog_set_drvdata (wdt_dev, dev); ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
Quoted 4 lines · razvan becheriu
PS: sry for sending this several times, I get a message like:
Message may contain a virus
Your message wasn't delivered to [email protected] because it may contain a virus. Learn how to check for and prevent viruses.
You need to send the message as plain text. You may test yourself without spamming people by sending to some other address which you have access to.
All there messages I got have HTML part. Usually it shows MUA misconfiguration.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi,
regarding the test for the WATCHDOG_NOWAYOUT patch:
``` Tested-by: Razvan Becheriu <[email protected]> The patch works. By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping the watchdog.service, the board reboots. Previously, the watchdog.service was able to disable the watchdog counter, and no reboot was performed. ```
Thank you,
Razvan
Quoted 44 lines · razvan becheriu
Hi,
regarding the test for the
WATCHDOG_NOWAYOUTpatch:...
Tested-by Razvan Becheriu <[email protected]>The patch works.
By configuring theCONFIG_WATCHDOG_NOWAYOUTin the kernel and stopping the watchdog.service, the board reboots. Previously, the watchdog.service was able to disable the watchdog counter, and no reboot was performed.
...Thank you,
RazvanQuoted 28 lines · Andy Shevchenko
Normally, the watchdog is disabled when
/dev/watchdogis closed, but ifCONFIG_WATCHDOG_NOWAYOUTis defined, then it means that the watchdog should remain enabled. So we should keep it enabled ifCONFIG_WATCHDOG_NOWAYOUTis defined.Reported-by Razvan Becheriu <[email protected]>Cc Ferry Toth <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/watchdog/intel-mid_wdt.c | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/intel-mid_wdt.c +1
-1@@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev) wdt_dev->timeout =MID_WDT_DEFAULT_TIMEOUT ; wdt_dev->parent = dev; +watchdog_set_nowayout (wdt_dev,WATCHDOG_NOWAYOUT );watchdog_set_drvdata (wdt_dev, dev); ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq, --2.23.0
Quoted 10 lines · razvan becheriu
regarding the test for the
WATCHDOG_NOWAYOUTpatch:``` Tested-by: Razvan Becheriu <[email protected]> The patch works. By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping the watchdog.service, the board reboots. Previously, the watchdog.service was able to disable the watchdog counter, and no reboot was performed. ```
Thank you!
Now you can find it in archives [1].
For the future, please avoid top postings.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Op 30-09-2019 om 15:15 schreef Guenter Roeck:
Quoted 11 lines · Andy Shevchenko
Quoted 8 lines
Normally, the watchdog is disabled when
/dev/watchdogis closed, but ifCONFIG_WATCHDOG_NOWAYOUTis defined, then it means that the watchdog should remain enabled. So we should keep it enabled ifCONFIG_WATCHDOG_NOWAYOUTis defined.Reported-by Razvan Becheriu <[email protected]>Cc Ferry Toth <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Guenter Roeck <[email protected]>
Any chance of this going in v5.4?
Quoted 17 lines
Quoted 16 lines
---
drivers/watchdog/intel-mid_wdt.c| 1 +1 file changed, 1 insertion(+)drivers/watchdog/intel-mid_wdt.c +1
-0@@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev) wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT; wdt_dev->parent = dev; + watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT); watchdog_set_drvdata(wdt_dev, dev); ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
Guenter Roeck
maintainerQuoted 7 lines · Ferry Toth
Op 30-09-2019 om 15:15 schreef Guenter Roeck:
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines
Normally, the watchdog is disabled when
/dev/watchdogis closed, but ifCONFIG_WATCHDOG_NOWAYOUTis defined, then it means that the watchdog should remain enabled. So we should keep it enabled ifCONFIG_WATCHDOG_NOWAYOUTis defined.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Reported-by Razvan Becheriu <[email protected]>Cc Ferry Toth <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Guenter Roeck <[email protected]>Any chance of this going in v5.4?
Good question. There are a few other pending bug fixes, including one which fixes a build failure. Wim, any chance you can queue those up ?
Thanks,
Guenter
Quoted 18 lines
Quoted 16 lines
Quoted 15 lines
---
drivers/watchdog/intel-mid_wdt.c| 1 +1 file changed, 1 insertion(+)drivers/watchdog/intel-mid_wdt.c +1
-0@@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev) wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT; wdt_dev->parent = dev; + watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT); watchdog_set_drvdata(wdt_dev, dev); ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,