net: hisilicon: Fix signedness bug in hix5hd2_dev_probe()
PATCH 1/1 net: hisilicon: Fix signedness bug in hix5hd2_dev_probe()
The "priv->phy_mode" variable is an enum and in this context GCC will treat it as unsigned to the error handling will never trigger.
Fixes 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c +1 -1
@@ -1194,7 +1194,7 @@ static int hix5hd2_dev_probe(struct platform_device *pdev) goto err_free_mdio; priv->phy_mode =of_get_phy_mode (node); -if (priv->phy_mode <0 ) { +if ((int )priv->phy_mode <0 ) {netdev_err (ndev,"not find phy-mode\n" ); ret = -EINVAL ; goto err_mdiobus;
Signature · 1 line
2.20.1
From: Dan Carpenter <[email protected]>
Date: Wed, 25 Sep 2019 13:55:32 +0300
Quoted 5 lines
The "
priv->phy_mode" variable is an enum and in this context GCC will treat it as unsigned to the error handling will never trigger.Fixes 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver")Signed-off-by Dan Carpenter <[email protected]>
Applied.