net: netsec: Fix signedness bug in netsec_probe()
Subsystems (5)
PATCH 1/1 net: netsec: Fix signedness bug in netsec_probe()
The "priv->phy_interface" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling is never triggered.
Fixes 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/ethernet/socionext/netsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/socionext/netsec.c +1 -1
@@ -2007,7 +2007,7 @@ static int netsec_probe(struct platform_device *pdev)NETIF_MSG_LINK |NETIF_MSG_PROBE ; priv->phy_interface =device_get_phy_mode (&pdev->dev); -if (priv->phy_interface <0 ) { +if ((int )priv->phy_interface <0 ) {dev_err (&pdev->dev,"missing required property 'phy-mode'\n" ); ret = -ENODEV ; goto free_ndev;
Signature · 1 line
2.20.1
From: Dan Carpenter <[email protected]>
Date: Wed, 25 Sep 2019 13:56:38 +0300
Quoted 6 lines
The "
priv->phy_interface" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling is never triggered.Fixes 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")Signed-off-by Dan Carpenter <[email protected]>
Applied.