Skip to contentSkip to conversation

net: nixge: Fix a signedness bug in nixge_probe()

PATCH Applied Dan Carpenter 2 participants 2 messages Sep 25, 2019 – Sep 27, 2019

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 net: nixge: Fix a signedness bug in nixge_probe()

The "priv->phy_mode" is an enum and in this context GCC will treat it as an unsigned int so it can never be less than zero.

Fixes 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/net/ethernet/ni/nixge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/ni/nixge.c +1 -1
index 0b384f97d2fd..2761f3a3ae50 100644
@@ -1347,7 +1347,7 @@ static int nixge_probe(struct platform_device *pdev)
 	}
 
 	priv->phy_mode = of_get_phy_mode(pdev->dev.of_node);
-	if (priv->phy_mode < 0) {
+	if ((int)priv->phy_mode < 0) {
 		netdev_err(ndev, "not find \"phy-mode\" property\n");
 		err = -EINVAL;
 		goto unregister_mdio;
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 25 Sep 2019 14:05:24 +0300

Quoted 5 lines

The "priv->phy_mode" is an enum and in this context GCC will treat it as an unsigned int so it can never be less than zero.

Fixes 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev")
Signed-off-by Dan Carpenter <[email protected]>

Applied.